[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 0bdb12: rules.mak: quiet-command: Split comma

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 0bdb12: rules.mak: quiet-command: Split command name and a...
Date: Thu, 06 Oct 2016 05:30:04 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0bdb12c7c50e2e92f2e17fe29ca8a8ddee91b4a1
  Author: Peter Maydell <address@hidden>
  Date:   2016-10-06 (Thu, 06 Oct 2016)

  Changed paths:
    M Makefile
    M Makefile.target
    M pc-bios/optionrom/Makefile
    M pc-bios/s390-ccw/Makefile
    M pc-bios/spapr-rtas/Makefile
    M po/Makefile
    M qga/vss-win32/Makefile.objs
    M rules.mak
    M target-s390x/Makefile.objs
    M tests/Makefile.include
    M tests/docker/Makefile.include
    M trace/Makefile.objs

  Log Message:
  rules.mak: quiet-command: Split command name and args to print

The quiet-command make rule currently takes two arguments:
the command and arguments to run, and a string to print if
the V flag is not set (ie we are not being verbose).
By convention, the string printed is of the form
"  NAME   some args". Unfortunately to get nicely lined up
output all the strings have to agree about what column the
arguments should start in, which means that if we add a
new quiet-command usage which wants a slightly longer CMD
name then we either put up with misalignment or change
every quiet-command string.

Split the quiet-mode string into two, the "NAME" and
the "same args" part, and use printf(1) to format the
string automatically. This means we only need to change
one place if we want to support a longer maximum name.

In particular, we can now print 7-character names lined
up properly (they are needed for the OSX "SETTOOL" invocation).

Change all the uses of quiet-command to the new syntax.
(Any which are missed or inadvertently reintroduced
via later merges will result in slightly misformatted
quiet output rather than disaster.)

A few places in the pc-bios/ makefiles are updated to use
"BUILD", "SIGN" and "STRIP" rather than "Building",
"Signing" and "Stripping" for consistency and to keep them
below 7 characters. Module .mo links now print "LD" rather
than the nonstandard "LD -r".

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]