[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ac7568: rules: don't try to create missing in

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] ac7568: rules: don't try to create missing include dirs
Date: Tue, 07 Feb 2017 06:15:12 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ac7568bd3ff381e1e0624ac2c07954f01aa45aad
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-02-07 (Tue, 07 Feb 2017)

  Changed paths:
    M configure
    M rules.mak

  Log Message:
  rules: don't try to create missing include dirs


  commit ba78db44f6532d66a1e704bd44613e841baa2fc5
  Author: Daniel P. Berrange <address@hidden>
  Date:   Wed Jan 25 16:14:10 2017 +0000

  make: move top level dir to end of include search path

The dir $(BUILD_DIR)/$(@D) was added to the include
path. This would sometimes point to a non-existant
directory, if the sub-dir in question did not contain
any target-independant files (eg tcg/). To deal with
this the rules.mak attempted to create the directory.

While this was succesful, it also caused accidental
creation of files in the parent of the build dir.
e.g. when building common source files into target
specific output files.

Rather than trying to workaround this, just revert
the code that attempted to mkdir the missing include
directories. Instead just turn off the compiler warning
in question as the missing dir is expected & harmless
in general.

NB: you can clean up a build directory parent that has
been filled with empty directories by commit ba78db44f653
using this GNU find command in that parent directory:
  find audio backends block chardev crypto disas fsdev hw io linux-user \
    migration nbd net qapi qom replay slirp target ui util \
    -type d -empty -delete

Signed-off-by: Daniel P. Berrange <address@hidden>
Tested-by: Alberto Garcia <address@hidden>
[PMM: added note about how to clean up a polluted directory]
Signed-off-by: Peter Maydell <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]