[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ff5bbe: parallels: fix default options parsin

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] ff5bbe: parallels: fix default options parsing
Date: Thu, 23 Mar 2017 04:15:11 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ff5bbe56c6f9a74c2d77389a21d5d2368458c939
  Author: Edgar Kaziahmedov <address@hidden>
  Date:   2017-03-21 (Tue, 21 Mar 2017)

  Changed paths:
    M block/parallels.c

  Log Message:
  parallels: fix default options parsing

parallels block driver is completely broken since commit
    commit 75cdcd1553e74b5edc58aed23e3b2da8dabb1876
    Author: Markus Armbruster <address@hidden>
    Date:   Tue Feb 21 21:14:08 2017 +0100
    option: Fix checking of sizes for overflow and trailing crap
Right now even simple
    qemu-io -c "read 512 64k" 1.hds
ends up with
    Unexpected error in parse_option_size() at util/qemu-option.c:188:
    Parameter 'prealloc-size' expects a non-negative number below 2^64
    Aborted (core dumped)
The cure is simple - we should use 'M' as a suffix in default option value
instead of 'MiB'.

Signed-off-by: Edgar Kaziahmedov <address@hidden>
Signed-off-by: Denis V. Lunev <address@hidden>
Message-id: address@hidden
CC: Markus Armbruster <address@hidden>
CC: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>

  Commit: ad3c6418c2e282633a2f0e91754980d1a4d5b078
  Author: Peter Maydell <address@hidden>
  Date:   2017-03-23 (Thu, 23 Mar 2017)

  Changed paths:
    M block/parallels.c

  Log Message:
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 

# gpg: Signature made Wed 22 Mar 2017 12:54:29 GMT
# gpg:                using RSA key 0x9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* remotes/stefanha/tags/block-pull-request:
  parallels: fix default options parsing

Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/55a19ad8b2d0...ad3c6418c2e2

reply via email to

[Prev in Thread] Current Thread [Next in Thread]