[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c50126: configure: Fix cut-n-paste errors in

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] c50126: configure: Fix cut-n-paste errors in OS deprecatio...
Date: Thu, 23 Mar 2017 12:00:14 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c50126aac1e80f3ab255fbceffff953f5f17e4df
  Author: Peter Maydell <address@hidden>
  Date:   2017-03-23 (Thu, 23 Mar 2017)

  Changed paths:
    M configure

  Log Message:
  configure: Fix cut-n-paste errors in OS deprecation warning

Fix some cut-and-paste errors in the OS deprecation warning
pointed out by Thomas Huth.

Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Message-id: address@hidden

  Commit: 08329701199449bde497570dcfdb9c86062baf20
  Author: Eric Blake <address@hidden>
  Date:   2017-03-23 (Thu, 23 Mar 2017)

  Changed paths:
    M qom/object_interfaces.c

  Log Message:
  qom: Fix regression with 'qom-type'

Commit 9a6d1ac assumed that 'qom-type' could be removed from QemuOpts
with no ill effects.  However, this command line proves otherwise:

$ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio \
  -object rng-random,filename=/dev/urandom,id=rng0 \
  -device virtio-rng-pci,rng=rng0
qemu-system-x86_64: -object rng-random,filename=/dev/urandom,id=rng0: Parameter 
'qom-type' is missing

Fix the regression by restoring qom-type in opts after its temporary
removal that was needed for the duration of user_creatable_add_opts().

Reported-by: Richard W. M. Jones <address@hidden>
Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Tested-by: Richard W.M. Jones <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/032e95af5315...083297011994

reply via email to

[Prev in Thread] Current Thread [Next in Thread]