[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 8149e2: pseries: Enforce homogeneous threads-

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 8149e2: pseries: Enforce homogeneous threads-per-core
Date: Mon, 03 Apr 2017 04:30:11 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 8149e2992f7811355cc34721b79d69d1a3a667dd
  Author: David Gibson <address@hidden>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M hw/ppc/spapr.c

  Log Message:
  pseries: Enforce homogeneous threads-per-core

For reasons that may be useful in future, CPU core objects, as used on the
pseries machine type have their own nr-threads property, potentially
allowing cores with different numbers of threads in the same system.

If the user/management uses the values specified in query-hotpluggable-cpus
as they're expected to do, this will never matter in pratice.  But that's
not actually enforced - it's possible to manually specify a core with
a different number of threads from that in -smp.  That will confuse the
platform - most immediately, this can be used to create a CPU thread with
index above max_cpus which leads to an assertion failure in

For now, enforce that all cores must have the same, standard, number of

Signed-off-by: David Gibson <address@hidden>
Reviewed-by: Bharata B Rao <address@hidden>

  Commit: 9eb5adae26b828219e82f17c854cdf1f192f9565
  Author: Peter Maydell <address@hidden>
  Date:   2017-04-03 (Mon, 03 Apr 2017)

  Changed paths:
    M hw/ppc/spapr.c

  Log Message:
  Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.9-20170403' into 

ppc patch queue 2017-04-03

A single bugfix in this pull request, for an ugly assert() failure, if
the user ignores the information in query-hotpluggable-cpus and tries
to hot add CPUs to pseries with bad parameters.

# gpg: Signature made Mon 03 Apr 2017 11:06:58 BST
# gpg:                using RSA key 0x6C38CACA20D9B392
# gpg: Good signature from "David Gibson <address@hidden>"
# gpg:                 aka "David Gibson (Red Hat) <address@hidden>"
# gpg:                 aka "David Gibson (ozlabs.org) <address@hidden>"
# gpg:                 aka "David Gibson (kernel.org) <address@hidden>"
# Primary key fingerprint: 75F4 6586 AE61 A66C C44E  87DC 6C38 CACA 20D9 B392

* remotes/dgibson/tags/ppc-for-2.9-20170403:
  pseries: Enforce homogeneous threads-per-core

Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/6954cdc070b4...9eb5adae26b8

reply via email to

[Prev in Thread] Current Thread [Next in Thread]