[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5eceb0: sheepdog: Fix crash in co_read_respon

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 5eceb0: sheepdog: Fix crash in co_read_response()
Date: Tue, 11 Apr 2017 09:00:10 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5eceb01adfbe513c0309528293b0b86e32a6e27d
  Author: Kevin Wolf <address@hidden>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M block/sheepdog.c

  Log Message:
  sheepdog: Fix crash in co_read_response()

This fixes a regression introduced in commit 9d456654.

aio_co_wake() can only be used to reenter a coroutine that was already
previously entered, otherwise co->ctx is uninitialised and we access
garbage. Using it immediately after qemu_coroutine_create() like in
co_read_response() is wrong and causes segfaults.

Replace the call with aio_co_enter(), which gets an explicit AioContext
parameter and works even for new coroutines.

Signed-off-by: Kevin Wolf <address@hidden>
Tested-by: Kashyap Chamarthy <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>

  Commit: e3e0003a8f6570aba1421ef99a0b383a43371a74
  Author: Max Reitz <address@hidden>
  Date:   2017-04-11 (Tue, 11 Apr 2017)

  Changed paths:
    M block.c
    M block/io.c

  Log Message:
  block/io: Comment out permission assertions

In case of block migration, there may be writes to BlockBackends that do
not have the write permission taken. Before this issue is fixed (which
is not going to happen in 2.9), we therefore cannot assert that this is
the case.

Suggested-by: Kevin Wolf <address@hidden>
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Tested-by: Kevin Wolf <address@hidden>
Message-id: address@hidden
Tested-by: Laurent Vivier <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/f5ac5cfeb67c...e3e0003a8f65

reply via email to

[Prev in Thread] Current Thread [Next in Thread]