[Qemu-commits] [qemu/qemu] 3d0684: ram: Update all functions comments

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 3d0684: ram: Update all functions comments

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 3d0684: ram: Update all functions comments
Date:	Fri, 21 Apr 2017 09:09:23 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c
      
https://github.com/qemu/qemu/commit/3d0684b2ad82a5dde68e3f08b0d7786dccaf619c
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Update all functions comments

Added doc comments for existing functions comment and rewrite them in
a common style.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>

--

Fix Peter Xu comments
Improve postcopy comments as per reviews.


  Commit: 5e58f968f432cc079e2c53c07fdf0d4801d2bde5
      
https://github.com/qemu/qemu/commit/5e58f968f432cc079e2c53c07fdf0d4801d2bde5
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Rename flush_page_queue() to migration_page_queue_free()

It reflects better what it does.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 36449157267e7269bed698c0590a3e6feb1edba1
      
https://github.com/qemu/qemu/commit/36449157267e7269bed698c0590a3e6feb1edba1
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Rename block_name to rbname

So all places are consistent on the naming of a block name parameter.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 6f37bb8bf31e98be5cbe536aec881e65ec985526
      
https://github.com/qemu/qemu/commit/6f37bb8bf31e98be5cbe536aec881e65ec985526
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Create RAMState

We create a struct where to put all the ram state

Start with the following fields:

last_seen_block, last_sent_block, last_offset, last_version and
ram_bulk_stage are globals that are really related together.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>

--

Fix typo and warnings


  Commit: 8d820d6f675fe4c9391da4eb55561402c75fb05e
      
https://github.com/qemu/qemu/commit/8d820d6f675fe4c9391da4eb55561402c75fb05e
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Add dirty_rate_high_cnt to RAMState

We need to add a parameter to several functions to make this work.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 5a987738965d2f1d02b6f4e34e9ec64f2b6c79d8
      
https://github.com/qemu/qemu/commit/5a987738965d2f1d02b6f4e34e9ec64f2b6c79d8
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move bitmap_sync_count into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: f664da80fcc9120faecc1afd4b2af31019f0aff9
      
https://github.com/qemu/qemu/commit/f664da80fcc9120faecc1afd4b2af31019f0aff9
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move start time into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>

--

Renamed start_time to time_last_bitmap_sync(peterx suggestion)


  Commit: eac741595890ac3dec3c8addd02bf34cbf8fec25
      
https://github.com/qemu/qemu/commit/eac741595890ac3dec3c8addd02bf34cbf8fec25
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move bytes_xfer_prev into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: c4bdf0cf4b62a90b07f27f55d4650dc1cb3f8d7e
      
https://github.com/qemu/qemu/commit/c4bdf0cf4b62a90b07f27f55d4650dc1cb3f8d7e
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Change byte_xfer_{prev,now} type to uint64_t

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: a66cd90c74f2a521d2441ba591f822cc93291cab
      
https://github.com/qemu/qemu/commit/a66cd90c74f2a521d2441ba591f822cc93291cab
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move num_dirty_pages_period into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 68908ed665f4d97afb271c5d5b564d951951538c
      
https://github.com/qemu/qemu/commit/68908ed665f4d97afb271c5d5b564d951951538c
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/exec/ram_addr.h
    M migration/ram.c

  Log Message:
  -----------
  ram: Change num_dirty_pages_period type to uint64_t

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: b5833fde40b1c32eb80887cf55e971973856a412
      
https://github.com/qemu/qemu/commit/b5833fde40b1c32eb80887cf55e971973856a412
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move xbzrle_cache_miss_prev into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 36040d9cb25454d21a04d322423e36a0bd3975c5
      
https://github.com/qemu/qemu/commit/36040d9cb25454d21a04d322423e36a0bd3975c5
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move iterations_prev into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: f7ccd61b4ceee7c8bfaa78c943a179765ea745a6
      
https://github.com/qemu/qemu/commit/f7ccd61b4ceee7c8bfaa78c943a179765ea745a6
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move dup_pages into RAMState

Once there rename it to its actual meaning, zero_pages.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 5bb1272c38dea94fdded3048d7efac42a72f97f0
      
https://github.com/qemu/qemu/commit/5bb1272c38dea94fdded3048d7efac42a72f97f0
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/ram.c

  Log Message:
  -----------
  ram: Remove unused dup_mig_bytes_transferred()

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: bedf53c14c35f6121c11f81b6c72714804177550
      
https://github.com/qemu/qemu/commit/bedf53c14c35f6121c11f81b6c72714804177550
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Remove unused pages_skipped variable

For compatibility, we need to still send a value, but just specify it
and comment the fact.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: b4d1c6e722b0b754de08e72125ef50b37b4a1b6e
      
https://github.com/qemu/qemu/commit/b4d1c6e722b0b754de08e72125ef50b37b4a1b6e
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move norm_pages to RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 29cc3d8a9b595dfcd0c6fd75b8fd490b88fbb184
      
https://github.com/qemu/qemu/commit/29cc3d8a9b595dfcd0c6fd75b8fd490b88fbb184
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Remove norm_mig_bytes_transferred

Its value can be calculated by other exported.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 23b28c3c62fc95a9652a76d2257cce21b9b0b391
      
https://github.com/qemu/qemu/commit/23b28c3c62fc95a9652a76d2257cce21b9b0b391
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move iterations into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 07ed50a2bb66a4d5ab2d7e54a5dfc4b618cccacc
      
https://github.com/qemu/qemu/commit/07ed50a2bb66a4d5ab2d7e54a5dfc4b618cccacc
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move xbzrle_bytes into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: f36ada95dedefaf2a47f19ae3214913506716b90
      
https://github.com/qemu/qemu/commit/f36ada95dedefaf2a47f19ae3214913506716b90
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move xbzrle_pages into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>

--

Comment why we need bytes and pages


  Commit: 544c36f188cb10f0c07d31c135f863972799e25c
      
https://github.com/qemu/qemu/commit/544c36f188cb10f0c07d31c135f863972799e25c
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move xbzrle_cache_miss into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: b07016b674cb3e5393cb6365dd5628b57f7c03e6
      
https://github.com/qemu/qemu/commit/b07016b674cb3e5393cb6365dd5628b57f7c03e6
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move xbzrle_cache_miss_rate into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 180f61f75af4963e08e2204b207c74e4144ba150
      
https://github.com/qemu/qemu/commit/180f61f75af4963e08e2204b207c74e4144ba150
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move xbzrle_overflows into RAMState

Once there, remove the now unused AccountingInfo struct and var.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 0d8ec885ed899d20b14eb8a19544ad66f04937bc
      
https://github.com/qemu/qemu/commit/0d8ec885ed899d20b14eb8a19544ad66f04937bc
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move migration_dirty_pages to RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: ceb4d16898549e5b7d9123b830907de8908fca9d
      
https://github.com/qemu/qemu/commit/ceb4d16898549e5b7d9123b830907de8908fca9d
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Everything was init to zero, so use memset

And then init only things that are not zero by default.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 108cfae0195fc51c007017a3a5ab49f4e3c3f781
      
https://github.com/qemu/qemu/commit/108cfae0195fc51c007017a3a5ab49f4e3c3f781
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move migration_bitmap_mutex into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: eb859c53dd23deae527b3c259b4c1b639f879c4d
      
https://github.com/qemu/qemu/commit/eb859c53dd23deae527b3c259b4c1b639f879c4d
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move migration_bitmap_rcu into RAMState

Once there, rename the type to be shorter.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 2f4fde9352de8b43c4c9831f2cf58114e2b4000e
      
https://github.com/qemu/qemu/commit/2f4fde9352de8b43c4c9831f2cf58114e2b4000e
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move bytes_transferred into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 072c251157d0903f895bd05280867eb869d14854
      
https://github.com/qemu/qemu/commit/072c251157d0903f895bd05280867eb869d14854
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Use the RAMState bytes_transferred parameter

Somewhere it was passed by reference, just use it from RAMState.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 9edabd4de6babf36f110c99a05b1558834535ec8
      
https://github.com/qemu/qemu/commit/9edabd4de6babf36f110c99a05b1558834535ec8
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Remove ram_save_remaining

Just unfold it.  Move ram_bytes_remaining() with the rest of exported
functions.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 68a098f38652ad7f4883de7beeba0c3dae9b2a0b
      
https://github.com/qemu/qemu/commit/68a098f38652ad7f4883de7beeba0c3dae9b2a0b
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Move last_req_rb to RAMState

It was on MigrationState when it is only used inside ram.c for
postcopy.  Problem is that we need to access it without being able to
pass it RAMState directly.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: ec481c6c576fbac6c4b5a7a5874e313882a49a09
      
https://github.com/qemu/qemu/commit/ec481c6c576fbac6c4b5a7a5874e313882a49a09
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Move src_page_req* to RAMState

This are the last postcopy fields still at MigrationState.  Once there
Move MigrationSrcPageRequest to ram.c and remove MigrationState
parameters where appropiate.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 42d219d3b0211c00432c04658dc22da66785f062
      
https://github.com/qemu/qemu/commit/42d219d3b0211c00432c04658dc22da66785f062
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Create ram_dirty_sync_count()

This is a ram field that was inside MigrationState.  Move it to
RAMState and make it the same that the other ram stats.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: abbf1d7f9bb43ba5fac7a9c27b67d9a78749e67a
      
https://github.com/qemu/qemu/commit/abbf1d7f9bb43ba5fac7a9c27b67d9a78749e67a
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Remove dirty_bytes_rate

It can be recalculated from dirty_pages_rate.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>

--

Dave was the one that reviewed it O:-)


  Commit: 47ad861976d8490047c53d5a80b562776f3c951b
      
https://github.com/qemu/qemu/commit/47ad861976d8490047c53d5a80b562776f3c951b
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Move dirty_pages_rate to RAMState

Treat it like the rest of ram stats counters.  Export its value the
same way.  As an added bonus, no more MigrationState used in
migration_bitmap_sync();

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>

--

Again, dave was the one reviewing it


  Commit: 96506894a316bdb86ce9b78e906bc8ffb9697d5e
      
https://github.com/qemu/qemu/commit/96506894a316bdb86ce9b78e906bc8ffb9697d5e
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c

  Log Message:
  -----------
  ram: Move postcopy_requests into RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 204b88b869f9bf2b0e565650d51d664244d33a3d
      
https://github.com/qemu/qemu/commit/204b88b869f9bf2b0e565650d51d664244d33a3d
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Add QEMUFile to RAMState

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: ce25d33781c6c1d679ff6fd06b43188f4adb9c41
      
https://github.com/qemu/qemu/commit/ce25d33781c6c1d679ff6fd06b43188f4adb9c41
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Move QEMUFile into RAMState

We receive the file from save_live operations and we don't use it
until 3 or 4 levels of calls down.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 6d358d94943076846328cc292e4f45c31e1d5d96
      
https://github.com/qemu/qemu/commit/6d358d94943076846328cc292e4f45c31e1d5d96
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Remove compression_switch and inline its logic

We can calculate its value, so we don't create a variable for it.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>

--

After Peter and Dave review, I dropped the variable and just inlined
the condition.

Fix typo


  Commit: 5727309d254b4942645888574a16d36942ec439c
      
https://github.com/qemu/qemu/commit/5727309d254b4942645888574a16d36942ec439c
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c
    M migration/ram.c
    M migration/savevm.c

  Log Message:
  -----------
  migration: Remove MigrationState from migration_in_postcopy

We need to call for the migrate_get_current() in more that half of the
uses, so call that inside.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: a0a8aa147aaa81176f550fbd556594434a345c08
      
https://github.com/qemu/qemu/commit/a0a8aa147aaa81176f550fbd556594434a345c08
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: We don't need MigrationState parameter anymore

Remove it from callers and callees.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 20afaed98b7b1796f2e67213e4118bc64b50b03a
      
https://github.com/qemu/qemu/commit/20afaed98b7b1796f2e67213e4118bc64b50b03a
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M exec.c
    M include/sysemu/sysemu.h
    M migration/migration.c
    M migration/postcopy-ram.c
    M migration/savevm.c

  Log Message:
  -----------
  ram: Rename qemu_target_page_bits() to qemu_target_page_size()

It was used as a size in all cases except one.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 030ce1f8612215fcbe9d353dfeaeb2937f8e3f94
      
https://github.com/qemu/qemu/commit/030ce1f8612215fcbe9d353dfeaeb2937f8e3f94
  Author: Chao Fan <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hmp.c
    M migration/migration.c
    M qapi-schema.json

  Log Message:
  -----------
  ram: Add page-size to output in 'info migrate'

The number of dirty pages is output in 'pages' in the command
'info migrate', so add page-size to calculate the number of dirty
pages in bytes.

Signed-off-by: Chao Fan <address@hidden>
Signed-off-by: Li Zhijian <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 15440dd5a08a6b10538b9e62c6d95ac8a838d78a
      
https://github.com/qemu/qemu/commit/15440dd5a08a6b10538b9e62c6d95ac8a838d78a
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/exec/ram_addr.h
    M migration/ram.c

  Log Message:
  -----------
  ram: Pass RAMBlock to bitmap_sync

We change the meaning of start to be the offset from the beggining of
the block.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: aaa2064c2ae25ef833b3324aedeba9a6363bd5ec
      
https://github.com/qemu/qemu/commit/aaa2064c2ae25ef833b3324aedeba9a6363bd5ec
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/postcopy-ram.c
    M migration/ram.c
    M migration/savevm.c

  Log Message:
  -----------
  ram: ram_discard_range() don't use the mis parameter

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 247956946651ae0280f7b1ea88bb6237dd01c231
      
https://github.com/qemu/qemu/commit/247956946651ae0280f7b1ea88bb6237dd01c231
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: reorganize last_sent_block

We were setting it far away of when we changed it.  Now everything is
done inside save_page_header.  Once there, reorganize code to pass
RAMState.  We also set CONTINUE flag in a single place.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Peter Xu <address@hidden>


  Commit: 06b106889a09277617fc8c542397a9f595ee605a
      
https://github.com/qemu/qemu/commit/06b106889a09277617fc8c542397a9f595ee605a
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c
    M migration/trace-events

  Log Message:
  -----------
  ram: Use page number instead of an address for the bitmap operations

We use an unsigned long for the page number.  Notice that our bitmaps
already got that for the index, so we have that limit.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>

--

rename page to page_abs everywhere.
fix trace types for pages


  Commit: 269ace2951f14c230c36d7fcb5062594569a73e3
      
https://github.com/qemu/qemu/commit/269ace2951f14c230c36d7fcb5062594569a73e3
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Remember last_page instead of last_offset

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

--

Improve comment
Fix typo


  Commit: a935e30fbb46fe20459149a3be95eda54114fb85
      
https://github.com/qemu/qemu/commit/a935e30fbb46fe20459149a3be95eda54114fb85
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Change offset field in PageSearchStatus to page

We are moving everything to work on pages, not addresses.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: f20e2865167d2c147ccb42a445764e1ec99483e0
      
https://github.com/qemu/qemu/commit/f20e2865167d2c147ccb42a445764e1ec99483e0
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Use ramblock and page offset instead of absolute offset

This removes the needto pass also the absolute offset.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: b8c4899398126a1dd80377e14d4ba471018293d3
      
https://github.com/qemu/qemu/commit/b8c4899398126a1dd80377e14d4ba471018293d3
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M exec.c
    M include/exec/ram_addr.h
    M migration/ram.c

  Log Message:
  -----------
  ram: rename last_ram_offset() last_ram_pages()

We always use it as pages anyways.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 352b0de982f9d764661b5ab9c57951537ae7ac5c
      
https://github.com/qemu/qemu/commit/352b0de982f9d764661b5ab9c57951537ae7ac5c
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  ram: Use RAMBitmap type for coherence

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: fab350052698e27a1011d0d6f4257d8fecb84867
      
https://github.com/qemu/qemu/commit/fab350052698e27a1011d0d6f4257d8fecb84867
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/migration.h
    M migration/migration.c

  Log Message:
  -----------
  migration: Remove MigrationState parameter from migration_is_idle()

Only user don't have a MigrationState handly.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 9bed84c19138bd161e9a6157a93ae0b25b5f7a71
      
https://github.com/qemu/qemu/commit/9bed84c19138bd161e9a6157a93ae0b25b5f7a71
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: qdev_hotplug is really a bool

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 21def24a5a58ad0ea9f7b02c084387e71b11ff1b
      
https://github.com/qemu/qemu/commit/21def24a5a58ad0ea9f7b02c084387e71b11ff1b
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: Export qdev_hot_removed

I need to move qdev_unplug to qdev-monitor in the following patch, and
it needs access to this variable.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>


  Commit: 329006799f93265bff5e10a4e1dd50b66fe09e6b
      
https://github.com/qemu/qemu/commit/329006799f93265bff5e10a4e1dd50b66fe09e6b
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hw/core/qdev.c
    M qdev-monitor.c

  Log Message:
  -----------
  qdev: Move qdev_unplug() to qdev-monitor.c

It is not used by linux-user, otherwise I need to to create one stub
for migration_is_idle() on following patch.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: b06424de62b362034e41ddf77eb8cfaa641d9009
      
https://github.com/qemu/qemu/commit/b06424de62b362034e41ddf77eb8cfaa641d9009
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  migration: Disable hotplug/unplug during migration

Until we have reviewed what can/can't be hotplugged during migration,
disable it.  We can enable it later for the things that we know that
work.  For instance, memory hotplug during postcopy doesn't work
currently.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>

--

- Fix typo.  Thanks Thomas.
- Delay migration check after we have checked that we can hotplug that
  device.
- more typos


  Commit: 66103a5796d0003cb198c25d783dcdc1596aef1f
      
https://github.com/qemu/qemu/commit/66103a5796d0003cb198c25d783dcdc1596aef1f
  Author: Juan Quintela <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M exec.c
    M include/exec/ram_addr.h
    M migration/ram.c

  Log Message:
  -----------
  ram: Remove migration_bitmap_extend()

We have disabled memory hotplug, so we don't need to handle
migration_bitamp there.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>


  Commit: e8199e4895d34136735dea7e628d0de1a5afb630
      
https://github.com/qemu/qemu/commit/e8199e4895d34136735dea7e628d0de1a5afb630
  Author: Laurent Vivier <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: don't close a file descriptor while it can be in use

If we close the QEMUFile descriptor in process_incoming_migration_co()
while it has been stopped by an error, the postcopy_ram_listen_thread()
can try to continue to use it. And as the memory has been freed
it is working with an invalid pointer and crashes.

Fix this by releasing the memory after having managed the error
case (which, in fact, calls exit())

Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by:  Amit Shah <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: a23a6d183986ef38b705e85cabdd2af6cdc95276
      
https://github.com/qemu/qemu/commit/a23a6d183986ef38b705e85cabdd2af6cdc95276
  Author: Laurent Vivier <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hw/virtio/trace-events
    M hw/virtio/virtio-rng.c
    M include/hw/virtio/virtio-rng.h

  Log Message:
  -----------
  virtio-rng: stop virtqueue while the CPU is stopped

If we modify the virtio-rng virqueue while the
vmstate is already migrated we can have some
inconsistencies between the virtqueue state and
the memory content.

To avoid this, stop the virtqueue while the CPU
is stopped.

Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by:  Amit Shah <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 343001f68dd44d3052dea7d4db325aa8a4109b24
      
https://github.com/qemu/qemu/commit/343001f68dd44d3052dea7d4db325aa8a4109b24
  Author: Peter Xu <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration: set current_active_state once

We set it right above this one. No need to set it twice.

CC: Juan Quintela <address@hidden>
CC: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: faec066ab8c6ed078dd34a2735a67437673bd0f0
      
https://github.com/qemu/qemu/commit/faec066ab8c6ed078dd34a2735a67437673bd0f0
  Author: Peter Xu <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M include/migration/vmstate.h
    M migration/migration.c
    M migration/savevm.c

  Log Message:
  -----------
  migration: rename max_size to threshold_size

In migration codes (especially in migration_thread()), max_size is used
in many place for the threshold value that we will start to do the final
flush and jump to the next stage to dump the whole rest things to
destination. However its name is confusing to first readers. Let's
rename it to "threshold_size" when proper and add a comment for it. No
functional change is made.

CC: Juan Quintela <address@hidden>
CC: "Dr. David Alan Gilbert" <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: "Dr. David Alan Gilbert" <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: d80a0169e3e7e8e6ae9c2bdf512d0842554c02d1
      
https://github.com/qemu/qemu/commit/d80a0169e3e7e8e6ae9c2bdf512d0842554c02d1
  Author: Peter Xu <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hmp.c

  Log Message:
  -----------
  hmp: info migrate_capability format tunes

Dump the info in a single line is hard to read. Do it one per line.
Also, the first "capabilities:" didn't help much. Let's remove it.

CC: "Dr. David Alan Gilbert" <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: "Dr. David Alan Gilbert" <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 2c02468c9b1750aaa5fbeee49cdb55f101608c6a
      
https://github.com/qemu/qemu/commit/2c02468c9b1750aaa5fbeee49cdb55f101608c6a
  Author: Peter Xu <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M hmp.c

  Log Message:
  -----------
  hmp: info migrate_parameters format tunes

Do the same (one per line) to the parameter list.

CC: "Dr. David Alan Gilbert" <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: "Dr. David Alan Gilbert" <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 32c7e0ab755745e961f1772e95cac381cc68769d
      
https://github.com/qemu/qemu/commit/32c7e0ab755745e961f1772e95cac381cc68769d
  Author: Peter Maydell <address@hidden>
  Date:   2017-04-21 (Fri, 21 Apr 2017)

  Changed paths:
    M exec.c
    M hmp.c
    M hw/core/qdev.c
    M hw/virtio/trace-events
    M hw/virtio/virtio-rng.c
    M include/exec/ram_addr.h
    M include/hw/qdev-core.h
    M include/hw/virtio/virtio-rng.h
    M include/migration/migration.h
    M include/migration/vmstate.h
    M include/sysemu/sysemu.h
    M migration/migration.c
    M migration/postcopy-ram.c
    M migration/ram.c
    M migration/savevm.c
    M migration/trace-events
    M qapi-schema.json
    M qdev-monitor.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170421' 
into staging

migration/next for 20170421

# gpg: Signature made Fri 21 Apr 2017 11:28:13 BST
# gpg:                using RSA key 0xF487EF185872D723
# gpg: Good signature from "Juan Quintela <address@hidden>"
# gpg:                 aka "Juan Quintela <address@hidden>"
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* remotes/juanquintela/tags/migration/20170421: (65 commits)
  hmp: info migrate_parameters format tunes
  hmp: info migrate_capability format tunes
  migration: rename max_size to threshold_size
  migration: set current_active_state once
  virtio-rng: stop virtqueue while the CPU is stopped
  migration: don't close a file descriptor while it can be in use
  ram: Remove migration_bitmap_extend()
  migration: Disable hotplug/unplug during migration
  qdev: Move qdev_unplug() to qdev-monitor.c
  qdev: Export qdev_hot_removed
  qdev: qdev_hotplug is really a bool
  migration: Remove MigrationState parameter from migration_is_idle()
  ram: Use RAMBitmap type for coherence
  ram: rename last_ram_offset() last_ram_pages()
  ram: Use ramblock and page offset instead of absolute offset
  ram: Change offset field in PageSearchStatus to page
  ram: Remember last_page instead of last_offset
  ram: Use page number instead of an address for the bitmap operations
  ram: reorganize last_sent_block
  ram: ram_discard_range() don't use the mis parameter
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/af7ec403b213...32c7e0ab7557
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 3d0684: ram: Update all functions comments, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] c53eea: configure: eliminate Python dependency for --help
Next by Date: [Qemu-commits] [qemu/qemu] 66e2f3: cg3: remove TARGET_PAGE_SIZE rounding on dirty pag...
Previous by thread: [Qemu-commits] [qemu/qemu] c53eea: configure: eliminate Python dependency for --help
Next by thread: [Qemu-commits] [qemu/qemu] 66e2f3: cg3: remove TARGET_PAGE_SIZE rounding on dirty pag...
Index(es):
- Date
- Thread