[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] c7e47c: char: cast ARRAY_SIZE() as signed to
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] c7e47c: char: cast ARRAY_SIZE() as signed to silent warnin... |
Date: |
Mon, 05 Jun 2017 03:11:39 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: c7e47c63e0362ffded57db38684b88c270cff65f
https://github.com/qemu/qemu/commit/c7e47c63e0362ffded57db38684b88c270cff65f
Author: Philippe Mathieu-Daudé <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char.c
Log Message:
-----------
char: cast ARRAY_SIZE() as signed to silent warning on empty array
chardev/char.c: In function 'chardev_name_foreach':
chardev/char.c:546:19: error: comparison of unsigned expression < 0 is always
false [-Werror=type-limits]
for (i = 0; i < ARRAY_SIZE(chardev_alias_table); i++) {
^
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Commit: b88ee025942d1ed67232700ef8befa5e52a9f7bd
https://github.com/qemu/qemu/commit/b88ee025942d1ed67232700ef8befa5e52a9f7bd
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char-win.c
M chardev/char-win.h
Log Message:
-----------
char-win: simplify win_chr_read()
win_chr_read_poll() is always used before win_chr_read().
We can easily fold win_chr_readfile() too.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 6ce8e0eb587782e26a05a57134529cc598febd56
https://github.com/qemu/qemu/commit/6ce8e0eb587782e26a05a57134529cc598febd56
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char-win.c
M chardev/char-win.h
Log Message:
-----------
char-win: remove WinChardev.len
The "len" argument can be passed directly to win_chr_read()
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 221e659c3f37251b4312e0ac8ccf7799c67600b0
https://github.com/qemu/qemu/commit/221e659c3f37251b4312e0ac8ccf7799c67600b0
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char-serial.c
M chardev/char-win.c
M chardev/char-win.h
Log Message:
-----------
char-win: rename win_chr_init/poll win_chr_serial_init/poll
Those 2 functions are specific to serial chardev, make it more clear.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: ef0f272f38e1e534dd05a5a611aa0eb15dc60cc1
https://github.com/qemu/qemu/commit/ef0f272f38e1e534dd05a5a611aa0eb15dc60cc1
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char-pipe.c
M chardev/char-win.c
M chardev/char-win.h
Log Message:
-----------
char-win: rename hcom->file
hcom is the name of the file handle, regardless of the actual chardev
driver (serial, file, console etc..). Rename it to be more explicit.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 541815ff7f54f45a60d058b1c499c4affff094e0
https://github.com/qemu/qemu/commit/541815ff7f54f45a60d058b1c499c4affff094e0
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char-console.c
M chardev/char-file.c
M chardev/char-win.c
M chardev/char-win.h
Log Message:
-----------
char-win: close file handle except with console
Only the console handle shouldn't be closed, however, the "file" handle
should.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: f664b88247487c4cb020d016bef0f3b1daf9f4e5
https://github.com/qemu/qemu/commit/f664b88247487c4cb020d016bef0f3b1daf9f4e5
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M hw/arm/bcm2835_peripherals.c
M hw/char/imx_serial.c
M hw/display/xenfb.c
M hw/i386/xen/xen-hvm.c
M hw/mips/mips_fulong2e.c
M hw/mips/mips_malta.c
M hw/net/xgmac.c
M hw/ppc/spapr_events.c
M hw/ppc/spapr_rtas.c
M hw/sparc/leon3.c
M hw/usb/ccid-card-emulated.c
M hw/xen/xen_backend.c
M util/event_notifier-posix.c
Log Message:
-----------
Remove/replace sysemu/char.h inclusion
Those are apparently unnecessary includes.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 8228e353d8906bf43399ca0ef28446c5c48bb686
https://github.com/qemu/qemu/commit/8228e353d8906bf43399ca0ef28446c5c48bb686
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M MAINTAINERS
M backends/baum.c
M backends/msmouse.c
M backends/rng-egd.c
M backends/testdev.c
M backends/wctablet.c
M chardev/char-console.c
M chardev/char-fd.c
R chardev/char-fd.h
M chardev/char-file.c
M chardev/char-io.c
R chardev/char-io.h
M chardev/char-mux.c
R chardev/char-mux.h
M chardev/char-null.c
M chardev/char-parallel.c
R chardev/char-parallel.h
M chardev/char-pipe.c
M chardev/char-pty.c
M chardev/char-ringbuf.c
M chardev/char-serial.c
R chardev/char-serial.h
M chardev/char-socket.c
M chardev/char-stdio.c
M chardev/char-udp.c
M chardev/char-win-stdio.c
R chardev/char-win-stdio.h
M chardev/char-win.c
R chardev/char-win.h
M chardev/char.c
M gdbstub.c
M hmp.c
M hw/arm/fsl-imx25.c
M hw/arm/fsl-imx31.c
M hw/arm/fsl-imx6.c
M hw/arm/omap2.c
M hw/arm/pxa2xx.c
M hw/arm/strongarm.c
M hw/bt/hci-csr.c
M hw/char/cadence_uart.c
M hw/char/debugcon.c
M hw/char/digic-uart.c
M hw/char/escc.c
M hw/char/etraxfs_ser.c
M hw/char/exynos4210_uart.c
M hw/char/grlib_apbuart.c
M hw/char/ipoctal232.c
M hw/char/lm32_juart.c
M hw/char/lm32_uart.c
M hw/char/mcf_uart.c
M hw/char/milkymist-uart.c
M hw/char/omap_uart.c
M hw/char/parallel.c
M hw/char/pl011.c
M hw/char/sclpconsole-lm.c
M hw/char/sclpconsole.c
M hw/char/serial.c
M hw/char/sh_serial.c
M hw/char/spapr_vty.c
M hw/char/terminal3270.c
M hw/char/virtio-console.c
M hw/char/xen_console.c
M hw/char/xilinx_uartlite.c
M hw/core/qdev-properties-system.c
M hw/core/qdev-properties.c
M hw/ipmi/ipmi_bmc_extern.c
M hw/isa/pc87312.c
M hw/mips/boston.c
M hw/misc/ivshmem.c
M hw/usb/ccid-card-passthru.c
M hw/usb/dev-serial.c
M hw/usb/redirect.c
M hw/virtio/vhost-user.c
M hw/xen/xen-common.c
M hw/xtensa/xtfpga.c
A include/chardev/char-fd.h
A include/chardev/char-io.h
A include/chardev/char-mux.h
A include/chardev/char-parallel.h
A include/chardev/char-serial.h
A include/chardev/char-win-stdio.h
A include/chardev/char-win.h
A include/chardev/char.h
M include/hw/char/bcm2835_aux.h
M include/hw/char/cadence_uart.h
M include/hw/char/digic-uart.h
M include/hw/char/imx_serial.h
M include/hw/char/serial.h
M include/hw/char/stm32f2xx_usart.h
R include/sysemu/char.h
M monitor.c
M net/colo-compare.c
M net/filter-mirror.c
M net/slirp.c
M net/vhost-user.c
M qmp.c
M qtest.c
M replay/replay-char.c
M slirp/slirp.c
M spice-qemu-char.c
M tests/postcopy-test.c
M tests/test-char.c
M tests/vhost-user-test.c
M ui/console.c
M ui/gtk.c
M vl.c
Log Message:
-----------
chardev: move headers to include/chardev
So they are all in one place. The following patch will move serial &
parallel declarations to the respective headers.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 7566c6efe75572c63a8841fc09d0a8935b188c2f
https://github.com/qemu/qemu/commit/7566c6efe75572c63a8841fc09d0a8935b188c2f
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M backends/wctablet.c
M hw/arm/strongarm.c
M hw/bt/hci-csr.c
M hw/char/cadence_uart.c
M hw/char/escc.c
M hw/char/exynos4210_uart.c
M hw/char/parallel.c
M hw/char/serial.c
M hw/usb/dev-serial.c
M include/chardev/char-parallel.h
M include/chardev/char-serial.h
M include/chardev/char.h
Log Message:
-----------
chardev: serial & parallel declaration to own headers
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 93a78e41242ba164ae6af1690ea68fe22165ad4b
https://github.com/qemu/qemu/commit/93a78e41242ba164ae6af1690ea68fe22165ad4b
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M hw/bt/hci-csr.c
Log Message:
-----------
be-hci: use backend functions
Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead.
be->chr_read should exists if qemu_chr_be_can_write() is true.
(use qemu_chr_be_write(), _impl() bypasses replay)
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Andrzej Zaborowski <address@hidden>
Commit: c90e9392efa6579e714fe9aa2993e7d89e3792dc
https://github.com/qemu/qemu/commit/c90e9392efa6579e714fe9aa2993e7d89e3792dc
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char.c
Log Message:
-----------
char: generalize qemu_chr_write_all()
qemu_chr_fe_write() is similar to qemu_chr_write_all(): the later write
all with a chardev backend.
Make qemu_chr_write() and qemu_chr_fe_write_buffer() take an 'all'
argument. If false, handle 'partial' write the way qemu_chr_fe_write()
use to, and call qemu_chr_write() from qemu_chr_fe_write().
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 4d43a603c71d0eb92534bc82b72933f329d8a64c
https://github.com/qemu/qemu/commit/4d43a603c71d0eb92534bc82b72933f329d8a64c
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M backends/rng-egd.c
M chardev/Makefile.objs
A chardev/char-fe.c
M chardev/char.c
M gdbstub.c
M hw/arm/omap2.c
M hw/arm/pxa2xx.c
M hw/arm/strongarm.c
M hw/char/cadence_uart.c
M hw/char/debugcon.c
M hw/char/digic-uart.c
M hw/char/escc.c
M hw/char/etraxfs_ser.c
M hw/char/exynos4210_uart.c
M hw/char/grlib_apbuart.c
M hw/char/ipoctal232.c
M hw/char/lm32_juart.c
M hw/char/lm32_uart.c
M hw/char/mcf_uart.c
M hw/char/milkymist-uart.c
M hw/char/parallel.c
M hw/char/pl011.c
M hw/char/sclpconsole-lm.c
M hw/char/sclpconsole.c
M hw/char/sh_serial.c
M hw/char/spapr_vty.c
M hw/char/terminal3270.c
M hw/char/virtio-console.c
M hw/char/xen_console.c
M hw/char/xilinx_uartlite.c
M hw/core/qdev-properties-system.c
M hw/ipmi/ipmi_bmc_extern.c
M hw/misc/ivshmem.c
M hw/usb/ccid-card-passthru.c
M hw/usb/dev-serial.c
M hw/usb/redirect.c
M hw/virtio/vhost-user.c
A include/chardev/char-fe.h
M include/chardev/char-mux.h
M include/chardev/char.h
M include/hw/char/bcm2835_aux.h
M include/hw/char/cadence_uart.h
M include/hw/char/digic-uart.h
M include/hw/char/imx_serial.h
M include/hw/char/serial.h
M include/hw/char/stm32f2xx_usart.h
M monitor.c
M net/colo-compare.c
M net/filter-mirror.c
M net/slirp.c
M net/vhost-user.c
M qtest.c
M slirp/slirp.c
M tests/test-char.c
M tests/vhost-user-test.c
M ui/console.c
Log Message:
-----------
char: move CharBackend handling in char-fe unit
Move all the frontend struct and methods to a seperate unit. This avoids
accidentally mixing backend and frontend calls, and helps with readabilty.
Make qemu_chr_replay() a macro shared by both char and char-fe.
Export qemu_chr_write(), and use a macro for qemu_chr_write_all()
(nb: yes, CharBackend is for char frontend :)
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: a9b1ca38c2b1f062f22d4847e3b4c848d0fb84c3
https://github.com/qemu/qemu/commit/a9b1ca38c2b1f062f22d4847e3b4c848d0fb84c3
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M chardev/char.c
Log Message:
-----------
char: rename functions that are not part of fe
There is no clear reason to have those functions associated with
frontend.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 1ce2610c106d925387669b3133fc18ea986f0476
https://github.com/qemu/qemu/commit/1ce2610c106d925387669b3133fc18ea986f0476
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M backends/rng-egd.c
M chardev/char-fe.c
M chardev/char-mux.c
M gdbstub.c
M hw/char/serial.c
M hw/char/xen_console.c
M hw/core/qdev-properties-system.c
M hw/usb/ccid-card-passthru.c
M hw/usb/redirect.c
M include/chardev/char-fe.h
M monitor.c
M net/colo-compare.c
M net/filter-mirror.c
M net/vhost-user.c
M tests/test-char.c
M tests/vhost-user-test.c
Log Message:
-----------
char: make chr_fe_deinit() optionaly delete backend
This simplifies removing a backend for a frontend user (no need to
retrieve the associated driver and separate delete call etc).
NB: many frontends have questionable handling of ending a chardev. They
should probably delete the backend to prevent broken reusage.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: 6b10e573d15ef82dbc5c5b3726028e6642e134f6
https://github.com/qemu/qemu/commit/6b10e573d15ef82dbc5c5b3726028e6642e134f6
Author: Marc-André Lureau <address@hidden>
Date: 2017-06-02 (Fri, 02 Jun 2017)
Changed paths:
M MAINTAINERS
M Makefile.objs
M backends/Makefile.objs
R backends/baum.c
R backends/msmouse.c
R backends/testdev.c
M backends/trace-events
R backends/wctablet.c
M chardev/Makefile.objs
A chardev/baum.c
A chardev/msmouse.c
A chardev/spice.c
A chardev/testdev.c
A chardev/trace-events
A chardev/wctablet.c
R spice-qemu-char.c
M trace-events
Log Message:
-----------
char: move char devices to chardev/
Suggested by Paolo Bonzini during series review.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Commit: cb8b8ef4578dc17c350fd4b27700a9f178e2dad0
https://github.com/qemu/qemu/commit/cb8b8ef4578dc17c350fd4b27700a9f178e2dad0
Author: Peter Maydell <address@hidden>
Date: 2017-06-05 (Mon, 05 Jun 2017)
Changed paths:
M MAINTAINERS
M Makefile.objs
M backends/Makefile.objs
R backends/baum.c
R backends/msmouse.c
M backends/rng-egd.c
R backends/testdev.c
M backends/trace-events
R backends/wctablet.c
M chardev/Makefile.objs
A chardev/baum.c
M chardev/char-console.c
M chardev/char-fd.c
R chardev/char-fd.h
A chardev/char-fe.c
M chardev/char-file.c
M chardev/char-io.c
R chardev/char-io.h
M chardev/char-mux.c
R chardev/char-mux.h
M chardev/char-null.c
M chardev/char-parallel.c
R chardev/char-parallel.h
M chardev/char-pipe.c
M chardev/char-pty.c
M chardev/char-ringbuf.c
M chardev/char-serial.c
R chardev/char-serial.h
M chardev/char-socket.c
M chardev/char-stdio.c
M chardev/char-udp.c
M chardev/char-win-stdio.c
R chardev/char-win-stdio.h
M chardev/char-win.c
R chardev/char-win.h
M chardev/char.c
A chardev/msmouse.c
A chardev/spice.c
A chardev/testdev.c
A chardev/trace-events
A chardev/wctablet.c
M gdbstub.c
M hmp.c
M hw/arm/bcm2835_peripherals.c
M hw/arm/fsl-imx25.c
M hw/arm/fsl-imx31.c
M hw/arm/fsl-imx6.c
M hw/arm/omap2.c
M hw/arm/pxa2xx.c
M hw/arm/strongarm.c
M hw/bt/hci-csr.c
M hw/char/cadence_uart.c
M hw/char/debugcon.c
M hw/char/digic-uart.c
M hw/char/escc.c
M hw/char/etraxfs_ser.c
M hw/char/exynos4210_uart.c
M hw/char/grlib_apbuart.c
M hw/char/imx_serial.c
M hw/char/ipoctal232.c
M hw/char/lm32_juart.c
M hw/char/lm32_uart.c
M hw/char/mcf_uart.c
M hw/char/milkymist-uart.c
M hw/char/omap_uart.c
M hw/char/parallel.c
M hw/char/pl011.c
M hw/char/sclpconsole-lm.c
M hw/char/sclpconsole.c
M hw/char/serial.c
M hw/char/sh_serial.c
M hw/char/spapr_vty.c
M hw/char/terminal3270.c
M hw/char/virtio-console.c
M hw/char/xen_console.c
M hw/char/xilinx_uartlite.c
M hw/core/qdev-properties-system.c
M hw/core/qdev-properties.c
M hw/display/xenfb.c
M hw/i386/xen/xen-hvm.c
M hw/ipmi/ipmi_bmc_extern.c
M hw/isa/pc87312.c
M hw/mips/boston.c
M hw/mips/mips_fulong2e.c
M hw/mips/mips_malta.c
M hw/misc/ivshmem.c
M hw/net/xgmac.c
M hw/ppc/spapr_events.c
M hw/ppc/spapr_rtas.c
M hw/sparc/leon3.c
M hw/usb/ccid-card-emulated.c
M hw/usb/ccid-card-passthru.c
M hw/usb/dev-serial.c
M hw/usb/redirect.c
M hw/virtio/vhost-user.c
M hw/xen/xen-common.c
M hw/xen/xen_backend.c
M hw/xtensa/xtfpga.c
A include/chardev/char-fd.h
A include/chardev/char-fe.h
A include/chardev/char-io.h
A include/chardev/char-mux.h
A include/chardev/char-parallel.h
A include/chardev/char-serial.h
A include/chardev/char-win-stdio.h
A include/chardev/char-win.h
A include/chardev/char.h
M include/hw/char/bcm2835_aux.h
M include/hw/char/cadence_uart.h
M include/hw/char/digic-uart.h
M include/hw/char/imx_serial.h
M include/hw/char/serial.h
M include/hw/char/stm32f2xx_usart.h
R include/sysemu/char.h
M monitor.c
M net/colo-compare.c
M net/filter-mirror.c
M net/slirp.c
M net/vhost-user.c
M qmp.c
M qtest.c
M replay/replay-char.c
M slirp/slirp.c
R spice-qemu-char.c
M tests/postcopy-test.c
M tests/test-char.c
M tests/vhost-user-test.c
M trace-events
M ui/console.c
M ui/gtk.c
M util/event_notifier-posix.c
M vl.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/elmarco/tags/chrfe-pull-request' into
staging
# gpg: Signature made Fri 02 Jun 2017 20:12:48 BST
# gpg: using RSA key 0xDAE8E10975969CE5
# gpg: Good signature from "Marc-André Lureau <address@hidden>"
# gpg: aka "Marc-André Lureau <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg: It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276 F62D DAE8 E109 7596 9CE5
* remotes/elmarco/tags/chrfe-pull-request:
char: move char devices to chardev/
char: make chr_fe_deinit() optionaly delete backend
char: rename functions that are not part of fe
char: move CharBackend handling in char-fe unit
char: generalize qemu_chr_write_all()
be-hci: use backend functions
chardev: serial & parallel declaration to own headers
chardev: move headers to include/chardev
Remove/replace sysemu/char.h inclusion
char-win: close file handle except with console
char-win: rename hcom->file
char-win: rename win_chr_init/poll win_chr_serial_init/poll
char-win: remove WinChardev.len
char-win: simplify win_chr_read()
char: cast ARRAY_SIZE() as signed to silent warning on empty array
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/c6e84fbd447a...cb8b8ef4578d
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] c7e47c: char: cast ARRAY_SIZE() as signed to silent warnin...,
GitHub <=