[Qemu-commits] [qemu/qemu] f9f65a: docker: Run tests with current user

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] f9f65a: docker: Run tests with current user

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] f9f65a: docker: Run tests with current user
Date:	Tue, 20 Jun 2017 09:11:58 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f9f65a4af0ea8162d2339a979350f891942e3037
      
https://github.com/qemu/qemu/commit/f9f65a4af0ea8162d2339a979350f891942e3037
  Author: Fam Zheng <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M tests/docker/Makefile.include

  Log Message:
  -----------
  docker: Run tests with current user

We've used --add-current-user to create a user in the image, use it to
run tests, because root has too much priviledge, and can surprise test
cases.

Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 73a27bbb698202243d2092d802079dd6a0be7325
      
https://github.com/qemu/qemu/commit/73a27bbb698202243d2092d802079dd6a0be7325
  Author: Fam Zheng <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M tests/docker/dockerfiles/fedora.docker

  Log Message:
  -----------
  docker: Add bzip2 and hostname to fedora image

It is used by qemu-iotests.

Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 80c58a5b1b1ff1bc447f64c8aec981d5c6226cec
      
https://github.com/qemu/qemu/commit/80c58a5b1b1ff1bc447f64c8aec981d5c6226cec
  Author: Fam Zheng <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M tests/docker/dockerfiles/fedora.docker

  Log Message:
  -----------
  docker: Add libaio to fedora image

Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 79f24568e5e70892b9bf4712f88b26f52255077f
      
https://github.com/qemu/qemu/commit/79f24568e5e70892b9bf4712f88b26f52255077f
  Author: Fam Zheng <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M tests/docker/dockerfiles/centos6.docker

  Log Message:
  -----------
  docker: Add flex and bison to centos6 image

Currently there are warnings about flex and bison being missing when
building in the centos6 image:

    make[1]: flex: Command not found
       BISON dtc-parser.tab.c
    make[1]: bison: Command not found

Add them.

Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: d3faa13e5ffda779dcd58f39e8745370adb05d67
      
https://github.com/qemu/qemu/commit/d3faa13e5ffda779dcd58f39e8745370adb05d67
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block.c
    M block/io.c
    M blockdev.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: access copy_on_read with atomic ops

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 414c2ec3585408a5c7b458664db180e91480bb03
      
https://github.com/qemu/qemu/commit/414c2ec3585408a5c7b458664db180e91480bb03
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/io.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: access quiesce_counter with atomic ops

Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: d993b85804b7ec099d4e1d377161ac8af398d855
      
https://github.com/qemu/qemu/commit/d993b85804b7ec099d4e1d377161ac8af398d855
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/block-backend.c
    M block/throttle-groups.c
    M include/sysemu/block-backend.h

  Log Message:
  -----------
  block: access io_limits_disabled with atomic ops

Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 20fc71b25cfd8102b7f12a2b44133894ad90040a
      
https://github.com/qemu/qemu/commit/20fc71b25cfd8102b7f12a2b44133894ad90040a
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/io.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: access serialising_in_flight with atomic ops

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: e2a6ae7fe57c17199624e4d47826ec46ca57d546
      
https://github.com/qemu/qemu/commit/e2a6ae7fe57c17199624e4d47826ec46ca57d546
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/io.c
    M block/nfs.c
    M block/sheepdog.c
    M include/block/block.h
    M include/block/block_int.h

  Log Message:
  -----------
  block: access wakeup with atomic ops

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 850d54a2a9cf16f589f4aa40272515294671633f
      
https://github.com/qemu/qemu/commit/850d54a2a9cf16f589f4aa40272515294671633f
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/io.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: access io_plugged with atomic ops

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 7258ed930c78e7b85a064c7a0aff5d415efb8fbb
      
https://github.com/qemu/qemu/commit/7258ed930c78e7b85a064c7a0aff5d415efb8fbb
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/throttle-groups.c

  Log Message:
  -----------
  throttle-groups: only start one coroutine from drained_begin

Starting all waiting coroutines from bdrv_drain_all is unnecessary;
throttle_group_co_io_limits_intercept calls schedule_next_request as
soon as the coroutine restarts, which in turn will restart the next
request if possible.

If we only start the first request and let the coroutines dance from
there the code is simpler and there is more reuse between
throttle_group_config, throttle_group_restart_blk and timer_cb.  The
next patch will benefit from this.

We also stop accessing from throttle_group_restart_blk the
blkp->throttled_reqs CoQueues even when there was no
attached throttling group.  This worked but is not pretty.

The only thing that can interrupt the dance is the QEMU_CLOCK_VIRTUAL
timer when switching from one block device to the next, because the
timer is set to "now + 1" but QEMU_CLOCK_VIRTUAL might not be running.
Set that timer to point in the present ("now") rather than the future
and things work.

Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 3b170dc86732539ebc5927880097d32d4f11df8c
      
https://github.com/qemu/qemu/commit/3b170dc86732539ebc5927880097d32d4f11df8c
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/throttle-groups.c

  Log Message:
  -----------
  throttle-groups: do not use qemu_co_enter_next

Prepare for removing this function; always restart throttled requests
from coroutine context.  This will matter when restarting throttled
requests will have to acquire a CoMutex.

Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 93001e9d87ae40e7569eb0ece0eb86d9c9582e41
      
https://github.com/qemu/qemu/commit/93001e9d87ae40e7569eb0ece0eb86d9c9582e41
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/block-backend.c
    M block/throttle-groups.c
    M include/sysemu/block-backend.h

  Log Message:
  -----------
  throttle-groups: protect throttled requests with a CoMutex

Another possibility is to use tg->lock, which we're holding anyway in
both schedule_next_request and throttle_group_co_io_limits_intercept.
This would require open-coding the CoQueue however, so I've chosen this
alternative.

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: ae2d489c341ee98f2daad819a3812c6199481848
      
https://github.com/qemu/qemu/commit/ae2d489c341ee98f2daad819a3812c6199481848
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    A include/qemu/stats64.h
    M util/Makefile.objs
    A util/stats64.c

  Log Message:
  -----------
  util: add stats64 module

This module provides fast paths for 64-bit atomic operations on machines
that only have 32-bit atomic access.

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: f7946da274cf451d66e5207f21286fea14c4795d
      
https://github.com/qemu/qemu/commit/f7946da274cf451d66e5207f21286fea14c4795d
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/io.c
    M block/qapi.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: use Stat64 for wr_highest_offset

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 47fec59941a7182380bc8dde3faf17cfb05b770f
      
https://github.com/qemu/qemu/commit/47fec59941a7182380bc8dde3faf17cfb05b770f
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block.c
    M block/io.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: access write_gen with atomics

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 3783fa3dd3d0104e9780bde073f66f1e37f1ce1c
      
https://github.com/qemu/qemu/commit/3783fa3dd3d0104e9780bde073f66f1e37f1ce1c
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block.c
    M block/io.c
    M include/block/block_int.h

  Log Message:
  -----------
  block: protect tracked_requests and flush_queue with reqs_lock

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 2119882c7eb7e2c612b24fc0c8d86f5887d6f1c3
      
https://github.com/qemu/qemu/commit/2119882c7eb7e2c612b24fc0c8d86f5887d6f1c3
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block.c
    M block/dirty-bitmap.c
    M block/mirror.c
    M blockdev.c
    M include/block/block_int.h
    M migration/block.c

  Log Message:
  -----------
  block: introduce dirty_bitmap_mutex

It protects only the list of dirty bitmaps; in the next patch we will
also protect their content.

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: c0bad49946287ef218e871608b753b9991f6e54c
      
https://github.com/qemu/qemu/commit/c0bad49946287ef218e871608b753b9991f6e54c
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M migration/block.c

  Log Message:
  -----------
  migration/block: reset dirty bitmap before reading

Any data that is returned by read may be stale already, the bitmap
has to be cleared before issuing the read.

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: b64bd51efa9bbf30df1b2f91477d2805678d0b93
      
https://github.com/qemu/qemu/commit/b64bd51efa9bbf30df1b2f91477d2805678d0b93
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/dirty-bitmap.c
    M block/mirror.c
    M include/block/block_int.h
    M include/block/dirty-bitmap.h
    M migration/block.c

  Log Message:
  -----------
  block: protect modification of dirty bitmaps with a mutex

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 39c1b4254e6200519d747f6cb8c888004e2446e2
      
https://github.com/qemu/qemu/commit/39c1b4254e6200519d747f6cb8c888004e2446e2
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/accounting.c

  Log Message:
  -----------
  block: introduce block_account_one_io

This is the common code to account operations that produced actual I/O.

Reviewed-by: Alberto Garcia <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 9caa6f3dbe20f2c506df6698386fce941fc6238a
      
https://github.com/qemu/qemu/commit/9caa6f3dbe20f2c506df6698386fce941fc6238a
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/accounting.c
    M block/block-backend.c
    M blockdev.c
    M include/block/accounting.h

  Log Message:
  -----------
  block: split BlockAcctStats creation and setup

block_acct_destroy is called unconditionally in blk_delete, but there is
no BlockAcctStats function that is called unconditionally in blk_new.
Split block_acct_init in two, so that it will be possible to create a
QemuMutex in block_acct_init and destroy it in block_acct_cleanup.

Cc: Alberto Garcia <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 5b50bf77ce6e773b04a303a2912876c9a1bfca43
      
https://github.com/qemu/qemu/commit/5b50bf77ce6e773b04a303a2912876c9a1bfca43
  Author: Paolo Bonzini <address@hidden>
  Date:   2017-06-16 (Fri, 16 Jun 2017)

  Changed paths:
    M block/accounting.c
    M include/block/accounting.h

  Log Message:
  -----------
  block: make accounting thread-safe

I'm not trying too hard yet.  Later, with multiqueue support,
this may cause mutex contention or cacheline bouncing.

Cc: Alberto Garcia <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>


  Commit: 65a0e3e842df7f73ff2e4a61948f992a41e570a8
      
https://github.com/qemu/qemu/commit/65a0e3e842df7f73ff2e4a61948f992a41e570a8
  Author: Peter Maydell <address@hidden>
  Date:   2017-06-20 (Tue, 20 Jun 2017)

  Changed paths:
    M block.c
    M block/accounting.c
    M block/block-backend.c
    M block/dirty-bitmap.c
    M block/io.c
    M block/mirror.c
    M block/nfs.c
    M block/qapi.c
    M block/sheepdog.c
    M block/throttle-groups.c
    M blockdev.c
    M include/block/accounting.h
    M include/block/block.h
    M include/block/block_int.h
    M include/block/dirty-bitmap.h
    A include/qemu/stats64.h
    M include/sysemu/block-backend.h
    M migration/block.c
    M tests/docker/Makefile.include
    M tests/docker/dockerfiles/centos6.docker
    M tests/docker/dockerfiles/fedora.docker
    M util/Makefile.objs
    A util/stats64.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/famz/tags/docker-and-block-pull-request' into staging

# gpg: Signature made Fri 16 Jun 2017 01:18:46 BST
# gpg:                using RSA key 0xCA35624C6A9171C6
# gpg: Good signature from "Fam Zheng <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 5003 7CB7 9706 0F76 F021  AD56 CA35 624C 6A91 71C6

* remotes/famz/tags/docker-and-block-pull-request: (23 commits)
  block: make accounting thread-safe
  block: split BlockAcctStats creation and setup
  block: introduce block_account_one_io
  block: protect modification of dirty bitmaps with a mutex
  migration/block: reset dirty bitmap before reading
  block: introduce dirty_bitmap_mutex
  block: protect tracked_requests and flush_queue with reqs_lock
  block: access write_gen with atomics
  block: use Stat64 for wr_highest_offset
  util: add stats64 module
  throttle-groups: protect throttled requests with a CoMutex
  throttle-groups: do not use qemu_co_enter_next
  throttle-groups: only start one coroutine from drained_begin
  block: access io_plugged with atomic ops
  block: access wakeup with atomic ops
  block: access serialising_in_flight with atomic ops
  block: access io_limits_disabled with atomic ops
  block: access quiesce_counter with atomic ops
  block: access copy_on_read with atomic ops
  docker: Add flex and bison to centos6 image
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7e56accdaf35...65a0e3e842df
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] f9f65a: docker: Run tests with current user, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] e45e7a: exec: check kvm mmu notifiers earlier
Next by Date: [Qemu-commits] [qemu/qemu] 2f2951: q35/mch: implement extended TSEG sizes
Previous by thread: [Qemu-commits] [qemu/qemu] e45e7a: exec: check kvm mmu notifiers earlier
Next by thread: [Qemu-commits] [qemu/qemu] 2f2951: q35/mch: implement extended TSEG sizes
Index(es):
- Date
- Thread