qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b1fde1: hmp: fix "dump-quest-memory" segfault

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] b1fde1: hmp: fix "dump-quest-memory" segfault (ppc)
Date: Thu, 14 Sep 2017 09:58:13 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b1fde1ef5106c92dd12f1f0cfcb8c76e57d7f681
      
https://github.com/qemu/qemu/commit/b1fde1ef5106c92dd12f1f0cfcb8c76e57d7f681
  Author: Laurent Vivier <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M target/ppc/arch_dump.c

  Log Message:
  -----------
  hmp: fix "dump-quest-memory" segfault (ppc)

Running QEMU with
    qemu-system-ppc64 -M none -nographic -m 256
and executing
    dump-guest-memory /dev/null 0 8192
results in segfault

Fix by checking if we have CPU, and exit with
error if there is no CPU:

    (qemu) dump-guest-memory /dev/null
    this feature or command is not currently supported

Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 6dba634097d54db60017f10c160a052e46bdf60d
      
https://github.com/qemu/qemu/commit/6dba634097d54db60017f10c160a052e46bdf60d
  Author: Laurent Vivier <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M target/arm/arch_dump.c

  Log Message:
  -----------
  hmp: fix "dump-quest-memory" segfault (arm)

Running QEMU with
    qemu-system-aarch64 -M none -nographic -m 256
and executing
    dump-guest-memory /dev/null 0 8192
results in segfault

Fix by checking if we have CPU, and exit with
error if there is no CPU:

    (qemu) dump-guest-memory /dev/null
    this feature or command is not currently supported

Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Tested-by: Eric Auger <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: d1e6994abcd12c7f54aa73ff848fb6215c783898
      
https://github.com/qemu/qemu/commit/d1e6994abcd12c7f54aa73ff848fb6215c783898
  Author: Cornelia Huck <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: do not dump non-existent guest memory

It does not really make sense to dump memory that is not there.

Moreover, that fixes a segmentation fault when calling dump-guest-memory
with no filter for a machine with no memory defined.

New behaviour is:

(qemu) dump-guest-memory /dev/null
dump: no guest memory to dump
(qemu) dump-guest-memory /dev/null 0 4096
dump: no guest memory to dump

Signed-off-by: Cornelia Huck <address@hidden>
Tested-by: Laurent Vivier <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 4e5c3a3742adcf7514b73f4da1c005ee7b35e41b
      
https://github.com/qemu/qemu/commit/4e5c3a3742adcf7514b73f4da1c005ee7b35e41b
  Author: Laurent Vivier <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M tests/test-hmp.c

  Log Message:
  -----------
  tests/hmp: test "none" machine with memory

and add a test case of dump-guest-memory without
"[begin length]" parameters.

Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 31959e82fb0537e09f6c53b78323c510d794a73c
      
https://github.com/qemu/qemu/commit/31959e82fb0537e09f6c53b78323c510d794a73c
  Author: Vadim Galitsyn <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M include/qemu/typedefs.h
    M include/sysemu/numa.h
    M monitor.c
    M numa.c

  Log Message:
  -----------
  hmp: extend "info numa" with hotplugged memory information

Report amount of hotplugged memory in addition to total
amount per NUMA node.

Signed-off-by: Vadim Galitsyn <address@hidden>
Cc: Eduardo Habkost <address@hidden>
Cc: David Hildenbrand <address@hidden>
Cc: address@hidden
Message-Id: <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>


  Commit: 9aa3397f1999e569eae266cab844391e5ab65d81
      
https://github.com/qemu/qemu/commit/9aa3397f1999e569eae266cab844391e5ab65d81
  Author: Vadim Galitsyn <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M hw/mem/pc-dimm.c
    M include/hw/mem/pc-dimm.h
    M qapi-schema.json
    M qmp.c
    M stubs/Makefile.objs
    A stubs/qmp_pc_dimm.c
    R stubs/qmp_pc_dimm_device_list.c

  Log Message:
  -----------
  qmp: introduce query-memory-size-summary command

Add a new query-memory-size-summary command which provides the
following memory information in bytes:

  * base-memory - size of "base" memory specified with command line option -m.

  * plugged-memory - amount of memory that was hot-plugged.
    If target does not have CONFIG_MEM_HOTPLUG enabled, no
    value is reported.

Signed-off-by: Vasilis Liaskovitis <address@hidden>
Signed-off-by: Mohammed Gamal <address@hidden>
Signed-off-by: Eduardo Otubo <address@hidden>
Signed-off-by: Vadim Galitsyn <address@hidden>
Reviewed-by: Eugene Crosser <address@hidden>
Cc: Dr. David Alan Gilbert <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Igor Mammedov <address@hidden>
Cc: Eric Blake <address@hidden>
Cc: address@hidden
Message-Id: <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
  Fixup comments as per Igor's review
  Added 'of' from Vadim's reply


  Commit: d0f63c1e291a0c27cafc0e6faec5a84130b012e0
      
https://github.com/qemu/qemu/commit/d0f63c1e291a0c27cafc0e6faec5a84130b012e0
  Author: Vadim Galitsyn <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M hmp-commands-info.hx
    M hmp.c
    M hmp.h

  Log Message:
  -----------
  hmp: introduce 'info memory_size_summary' command

Add 'info memory_size_summary' command which is a sibling
of QMP command query-memory-size-summary. It provides the
following memory information in bytes:

  * base-memory - size of "base" memory specified with command line option -m.

  * plugged-memory - amount of memory that was hot-plugged.
    If target does not have CONFIG_MEM_HOTPLUG enabled, no
    value is reported.

Signed-off-by: Vasilis Liaskovitis <address@hidden>
Signed-off-by: Mohammed Gamal <address@hidden>
Signed-off-by: Eduardo Otubo <address@hidden>
Signed-off-by: Vadim Galitsyn <address@hidden>
Reviewed-by: Eugene Crosser <address@hidden>
Cc: Dr. David Alan Gilbert <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Igor Mammedov <address@hidden>
Cc: Eric Blake <address@hidden>
Cc: address@hidden
Message-Id: <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
  Fixed up comments from Igor's review


  Commit: 3dabde1128b671f36ac6cb36b97b273139964420
      
https://github.com/qemu/qemu/commit/3dabde1128b671f36ac6cb36b97b273139964420
  Author: Peter Maydell <address@hidden>
  Date:   2017-09-14 (Thu, 14 Sep 2017)

  Changed paths:
    M dump.c
    M hmp-commands-info.hx
    M hmp.c
    M hmp.h
    M hw/mem/pc-dimm.c
    M include/hw/mem/pc-dimm.h
    M include/qemu/typedefs.h
    M include/sysemu/numa.h
    M monitor.c
    M numa.c
    M qapi-schema.json
    M qmp.c
    M stubs/Makefile.objs
    A stubs/qmp_pc_dimm.c
    R stubs/qmp_pc_dimm_device_list.c
    M target/arm/arch_dump.c
    M target/ppc/arch_dump.c
    M tests/test-hmp.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into 
staging

HMP pull 2017-09-14

# gpg: Signature made Thu 14 Sep 2017 15:57:30 BST
# gpg:                using RSA key 0x0516331EBC5BFDE7
# gpg: Good signature from "Dr. David Alan Gilbert (RH2) <address@hidden>"
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 45F5 C71B 4A0C B7FB 977A  9FA9 0516 331E BC5B FDE7

* remotes/dgilbert/tags/pull-hmp-20170914:
  hmp: introduce 'info memory_size_summary' command
  qmp: introduce query-memory-size-summary command
  hmp: extend "info numa" with hotplugged memory information
  tests/hmp: test "none" machine with memory
  dump: do not dump non-existent guest memory
  hmp: fix "dump-quest-memory" segfault (arm)
  hmp: fix "dump-quest-memory" segfault (ppc)

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/dae288d7d820...3dabde1128b6
reply via email to
[Prev in Thread] Current Thread [Next in Thread]