[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7c3d19: build: disarm the TCG unit test trap

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 7c3d19: build: disarm the TCG unit test trap
Date: Tue, 21 Nov 2017 07:49:56 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7c3d1917fd7a3de906170fa3d6d3d4c5918b1e49
  Author: Daniel P. Berrange <address@hidden>
  Date:   2017-11-21 (Tue, 21 Nov 2017)

  Changed paths:
    M Makefile

  Log Message:
  build: disarm the TCG unit test trap

Developers sometimes mistakenly run 'make test' instead of 'make check'.
'make test' triggers the ancient, unmaintained tcg unit tests in
tests/tcg/Makefile which have long since ceased compiling.

Even if someone fixes the TCG tests, it makes little sense to put
them in a 'make test' target, rather they should be 'make check-tcg',
possibly wired up as a dependency of 'make check'.

In the meantime, this patch disarms the 'make test' trap by simply
deleting it so users get an immediate error. This should be enough
for them to remember to type 'make check' instead (or 'make help'
to learn). It also deletes 'make speed' which is another route
into the tcg tests.

Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Kashyap Chamarthy <address@hidden>
Reviewed-by: Daniel Henrique Barboza <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]