[Qemu-commits] [qemu/qemu] 723250: g364fb: fix DirtyBitmapSnapshot leak

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 723250: g364fb: fix DirtyBitmapSnapshot leak

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 723250: g364fb: fix DirtyBitmapSnapshot leak
Date:	Tue, 06 Mar 2018 06:23:31 -0800
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 723250d674a1e9ff601e98b8700f8d631e7b9855
      
https://github.com/qemu/qemu/commit/723250d674a1e9ff601e98b8700f8d631e7b9855
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M hw/display/g364fb.c

  Log Message:
  -----------
  g364fb: fix DirtyBitmapSnapshot leak

Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: d07aa197c5a1556449361a0cbb5108e2e7b1adb7
      
https://github.com/qemu/qemu/commit/d07aa197c5a1556449361a0cbb5108e2e7b1adb7
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M qemu-doc.texi
    M vl.c

  Log Message:
  -----------
  Remove the deprecated -tdf option

It's been marked as deprecated since a very long time already, and
the parameter is not doing anything useful anymore except for printing
a warning, so it's now time to finally get rid of this option.

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 1454509726719e0933c800fad00d6999752688ea
      
https://github.com/qemu/qemu/commit/1454509726719e0933c800fad00d6999752688ea
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c
    M hw/scsi/lsi53c895a.c
    M hw/scsi/scsi-bus.c
    M hw/scsi/spapr_vscsi.c
    M include/hw/scsi/scsi.h
    M qemu-doc.texi
    M tests/qemu-iotests/051
    M vl.c

  Log Message:
  -----------
  scsi: Remove automatic creation of SCSI controllers with -drive if=scsi

Automatic creation of SCSI controllers for "-drive if=scsi" for x86
machines was quite a bad idea (see description of commit f778a82f0c179
for details). This is marked as deprecated since QEMU v2.9.0, and as
far as I know, nobody complained that this is still urgently required
anymore. Time to remove this now.

Suggested-by: Markus Armbruster <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: a342173ab78fd8b126f27a7a5dbfb097a32f0ed7
      
https://github.com/qemu/qemu/commit/a342173ab78fd8b126f27a7a5dbfb097a32f0ed7
  Author: David Hildenbrand <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M cpus.c

  Log Message:
  -----------
  cpus: properly inititalize CPU > 1 under single-threaded TCG

All but the first CPU are currently not fully inititalized (e.g.
cpu->created is never set).

Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 81e963116882eed4ebf7cf3df5c2e1abaab3a288
      
https://github.com/qemu/qemu/commit/81e963116882eed4ebf7cf3df5c2e1abaab3a288
  Author: David Hildenbrand <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M cpus.c

  Log Message:
  -----------
  cpus: wait for CPU creation at central place

We can now also wait for the CPU creation for single-threaded TCG, so we
can move the waiting bits further out.

Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 5a9c973b6cda88acb08d62a696a72d9e2be5807b
      
https://github.com/qemu/qemu/commit/5a9c973b6cda88acb08d62a696a72d9e2be5807b
  Author: David Hildenbrand <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M cpus.c

  Log Message:
  -----------
  cpus: CPU threads are always created initially for one CPU only

It can never happen for single-threaded TCG that we have more than one
CPU in the list, while the first one has not been marked as "created".

Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: f29d4450428fe07e9d6b0655cef2e59bfa0b2ea5
      
https://github.com/qemu/qemu/commit/f29d4450428fe07e9d6b0655cef2e59bfa0b2ea5
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M qemu-doc.texi
    M vl.c

  Log Message:
  -----------
  Document --rtc-td-hack, --localtime and --startdate as deprecated

These options have been marked in a comment in qemu-options.hx as
deprecated in 2009 already (see commit 1ed2fc1fa35fadc0d6), but we
never informed the users about these deprecations. Let's catch up
on that omission now.

Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
[Fix messages. - Paolo]
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 35f63767dc77d85bebff6c6565aceaf74023776a
      
https://github.com/qemu/qemu/commit/35f63767dc77d85bebff6c6565aceaf74023776a
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M qapi/misc.json
    M qdev-monitor.c
    M qmp.c

  Log Message:
  -----------
  qmp: Merge ObjectPropertyInfo and DevicePropertyInfo

ObjectPropertyInfo is more generic and only missing @description.
This adds a description to ObjectPropertyInfo and removes
DevicePropertyInfo so the resulting ObjectPropertyInfo can be used
elsewhere.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 961c47bb8bacc9ae21c0760fa6e2594156299dd7
      
https://github.com/qemu/qemu/commit/961c47bb8bacc9ae21c0760fa6e2594156299dd7
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M include/qom/object.h
    M qapi/misc.json
    M qmp.c
    M qom/object.c

  Log Message:
  -----------
  qmp: Add qom-list-properties to list QOM object properties

There is already 'device-list-properties' which does most of the job,
however it does not handle everything returned by qom-list-types such
as machines as they inherit directly from TYPE_OBJECT and not TYPE_DEVICE.
It does not handle abstract classes either.

This adds a new qom-list-properties command which prints properties
of a specific class and its instance. It is pretty much a simplified copy
of the device-list-properties handler.

Since it creates an object instance, device properties should appear
in the output as they are copied to QOM properties at the instance_init
hook.

This adds a object_class_property_iter_init() helper to allow class
properties enumeration uses it in the new QMP command to allow properties
listing for abstract classes.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b9f44da2f2cdc1a1a1be5aed0c46bd7fcc69cf4a
      
https://github.com/qemu/qemu/commit/b9f44da2f2cdc1a1a1be5aed0c46bd7fcc69cf4a
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M configure

  Log Message:
  -----------
  build-sys: fix -fsanitize=address check

Since 218bb57dd79d6843e0592c30a82ea8c1fddc74a5, the -fsanitize=address
check fails with:
config-temp/qemu-conf.c:3:20: error: integer overflow in expression 
[-Werror=overflow]
   return INT32_MIN / -1;

Interestingly, UBSAN check doesn't produce a compile time warning.
Use a test that doesn't have compile time warnings, and make it
specific to UBSAN check.

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 80818e9ecbc6f7463ea47d0aae8d4a43ea030304
      
https://github.com/qemu/qemu/commit/80818e9ecbc6f7463ea47d0aae8d4a43ea030304
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M include/qemu/lockable.h

  Log Message:
  -----------
  lockable: workaround GCC link issue with ASAN

Current GCC has an optimization bug when compiling with ASAN.

See also GCC bug:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84307

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 0fd76bc51b55d262147f976445c921b3ef9b75e2
      
https://github.com/qemu/qemu/commit/0fd76bc51b55d262147f976445c921b3ef9b75e2
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M tests/ahci-test.c

  Log Message:
  -----------
  ahci-test: fix opts leak of skip tests

Fixes the following ASAN report:

Direct leak of 128 byte(s) in 8 object(s) allocated from:
    #0 0x7fefce311850 in malloc (/lib64/libasan.so.4+0xde850)
    #1 0x7fefcdd5ef0c in g_malloc ../glib/gmem.c:94
    #2 0x559b976faff0 in create_ahci_io_test 
/home/elmarco/src/qemu/tests/ahci-test.c:1810

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 26b97f2664a06f637b0a52b259723195683f2525
      
https://github.com/qemu/qemu/commit/26b97f2664a06f637b0a52b259723195683f2525
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M tests/sdhci-test.c

  Log Message:
  -----------
  sdhci-test: fix leaks

Fix the following ASAN reports:

==20125==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7f0faea03a38 in __interceptor_calloc (/lib64/libasan.so.4+0xdea38)
    #1 0x7f0fae450f75 in g_malloc0 ../glib/gmem.c:124
    #2 0x562fffd526fc in machine_start 
/home/elmarco/src/qemu/tests/sdhci-test.c:180

Indirect leak of 152 byte(s) in 1 object(s) allocated from:
    #0 0x7f0faea03850 in malloc (/lib64/libasan.so.4+0xde850)
    #1 0x7f0fae450f0c in g_malloc ../glib/gmem.c:94
    #2 0x562fffd5d21d in qpci_init_pc 
/home/elmarco/src/qemu/tests/libqos/pci-pc.c:122

Signed-off-by: Marc-André Lureau <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 8b2ec54ff39c319dcb12e430d9e69d081395b964
      
https://github.com/qemu/qemu/commit/8b2ec54ff39c319dcb12e430d9e69d081395b964
  Author: Peter Xu <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M chardev/char-socket.c

  Log Message:
  -----------
  chardev: fix leak in tcp_chr_telnet_init_io()

Need to free TCPChardevTelnetInit when session established.

Since at it, switch to use G_SOURCE_* macros.

Reviewed-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 80d2b933f9fe3e53d4f76a45a1bc1a0175669468
      
https://github.com/qemu/qemu/commit/80d2b933f9fe3e53d4f76a45a1bc1a0175669468
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M hw/intc/openpic_kvm.c

  Log Message:
  -----------
  openpic_kvm: drop address_space_to_flatview call

The MemoryListener is registered on address_space_memory, there is
not much to assert.  This currently works because the callback
is invoked only once when the listener is registered, but section->fv
is the _new_ FlatView, not the old one on later calls and that
would break.

This confines address_space_to_flatview to exec.c and memory.c.

Acked-by: David Gibson <address@hidden>
Reviewed-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 785a507ec78bbda1c346f3d3593e5a58b62e73ef
      
https://github.com/qemu/qemu/commit/785a507ec78bbda1c346f3d3593e5a58b62e73ef
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M include/exec/memory-internal.h
    M include/exec/memory.h
    M memory.c

  Log Message:
  -----------
  memory: inline some performance-sensitive accessors

These accessors are called from inlined functions, and the call sequence
is much more expensive than just inlining the access.  Move the
struct declaration to memory-internal.h so that exec.c and memory.c
can both use an inline function.

Reviewed-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 4c6ebbb364aa6f42c5d8e83e932e967eb83f0e44
      
https://github.com/qemu/qemu/commit/4c6ebbb364aa6f42c5d8e83e932e967eb83f0e44
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  address_space_write: address_space_to_flatview needs RCU lock

address_space_write is calling address_space_to_flatview but it can
be called outside the RCU lock.  To fix it, push the rcu_read_lock/unlock
pair up from flatview_write to address_space_write.

Reviewed-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b2a44fcad74f1cc7a6786d38eba7db12ab2352ba
      
https://github.com/qemu/qemu/commit/b2a44fcad74f1cc7a6786d38eba7db12ab2352ba
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M exec.c
    M include/exec/memory.h

  Log Message:
  -----------
  address_space_read: address_space_to_flatview needs RCU lock

address_space_read is calling address_space_to_flatview but it can
be called outside the RCU lock.  To fix it, push the rcu_read_lock/unlock
pair up from flatview_read_full to address_space_read's constant size
fast path and address_space_read_full.

Reviewed-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 11e732a5ed46903f997985bed4c3767ca28a7eb6
      
https://github.com/qemu/qemu/commit/11e732a5ed46903f997985bed4c3767ca28a7eb6
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  address_space_access_valid: address_space_to_flatview needs RCU lock

address_space_access_valid is calling address_space_to_flatview but it can
be called outside the RCU lock.  To fix it, push the rcu_read_lock/unlock
pair up from flatview_access_valid to address_space_access_valid.

Reviewed-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: ad0c60fa572d4050255b698ecdb67294dd4c0125
      
https://github.com/qemu/qemu/commit/ad0c60fa572d4050255b698ecdb67294dd4c0125
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  address_space_map: address_space_to_flatview needs RCU lock

address_space_map is calling address_space_to_flatview but it can
be called outside the RCU lock.  The function itself is calling
rcu_read_lock/rcu_read_unlock, just in the wrong place, so the
fix is easy.

Reviewed-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: db84fd973eba3f1e121416dcab73a4e8a60f2526
      
https://github.com/qemu/qemu/commit/db84fd973eba3f1e121416dcab73a4e8a60f2526
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M exec.c

  Log Message:
  -----------
  address_space_rw: address_space_to_flatview needs RCU lock

address_space_rw is calling address_space_to_flatview but it can
be called outside the RCU lock.  To fix it, transform flatview_rw
into address_space_rw, since flatview_rw is otherwise unused.

Reviewed-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: fb8446d94ec7a3dc0c3a7e7da672406476f075ac
      
https://github.com/qemu/qemu/commit/fb8446d94ec7a3dc0c3a7e7da672406476f075ac
  Author: Julia Suvorova <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M scripts/checkpatch.pl

  Log Message:
  -----------
  checkpatch: add a warning for basename/dirname

g_path_get_* do the same as g_strdup(basename/dirname(...)) but
without modifying the argument.

Signed-off-by: Julia Suvorova <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 2b9aef6fcd96ba7ed8c1ee723e391901852d344c
      
https://github.com/qemu/qemu/commit/2b9aef6fcd96ba7ed8c1ee723e391901852d344c
  Author: Su Hang <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M scripts/checkpatch.pl

  Log Message:
  -----------
  checkpatch: add check for `while` and `for`

Adding check for `while` and `for` statements, which condition has more than
one line.

The former checkpatch.pl can check `if` statement, which condition has more
than one line, whether block misses brace round, like this:
'''
if (cond1 ||
    cond2)
    statement;
'''
But it doesn't do the same check for `for` and `while` statements.

Using `(?:...)` instead of `(...)` in regex pattern catch.
Because `(?:...)` is faster and avoids unwanted side-effect.

Suggested-by: Stefan Hajnoczi <address@hidden>
Suggested-by: Eric Blake <address@hidden>
Suggested-by: Thomas Huth <address@hidden>
Signed-off-by: Su Hang <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 48e56d503e18bd1e8a75463fd7cc1580bf7e7650
      
https://github.com/qemu/qemu/commit/48e56d503e18bd1e8a75463fd7cc1580bf7e7650
  Author: Paolo Bonzini <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M configure

  Log Message:
  -----------
  Revert "build-sys: compile with -Og or -O1 when --enable-debug"

This reverts commit 906548689e37ab6cca1e93b3f8d9327a4e17e8af.
Even with -Og, the debug experience is noticeably worse
because gdb shows a lot more "<optimised out>" variables and
function arguments.

Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 53537bb18ca68471a1c738eed93cce646fd97194
      
https://github.com/qemu/qemu/commit/53537bb18ca68471a1c738eed93cce646fd97194
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M configure
    M target/i386/whpx-all.c

  Log Message:
  -----------
  Fixing WHPX casing to match SDK

Fixes an issue where the SDK that was releases had a different casing for the
*.h and *.lib files causing a build break if linked directly from Windows Kits.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: 914e2ab364c9b2b593a1a83ad08a81d494f7629d
      
https://github.com/qemu/qemu/commit/914e2ab364c9b2b593a1a83ad08a81d494f7629d
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  Resolves WHPX breaking changes in SDK 17095

1. Fixes the changes required to the WHvTryMmioEmulation, WHvTryIoEmulation, and
WHvEmulatorCreateEmulator based on the new VpContext forwarding.
2. Removes the WHvRunVpExitReasonAlerted case.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: 0ab2e74d792ece3e957b414cbe27e32f14f23a14
      
https://github.com/qemu/qemu/commit/0ab2e74d792ece3e957b414cbe27e32f14f23a14
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  Remove unnecessary WHPX __debugbreak();

Minor code cleanup. The calls to __debugbreak() are not required and should
no longer be used to prevent unnecessary breaks.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: b27350e1b992eca3fa4b3fea4065b1b3897ec57f
      
https://github.com/qemu/qemu/commit/b27350e1b992eca3fa4b3fea4065b1b3897ec57f
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  Fix WHPX additional lock acquisition

The code already is holding the qemu_mutex for the IO thread. We do not need
to additionally take the lock again in this case.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: f875f04c2c322357e2e3fbd90ce5613b5be403a9
      
https://github.com/qemu/qemu/commit/f875f04c2c322357e2e3fbd90ce5613b5be403a9
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  Fix WHPX typo in 'mmio'

Renames the usage of 'memio' to 'mmio' in the emulator callbacks.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: 2bf3e74de4e5e33eb477e9ebe1839f9594173773
      
https://github.com/qemu/qemu/commit/2bf3e74de4e5e33eb477e9ebe1839f9594173773
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  Fix WHPX issue leaking tpr values

Fixes an issue where if the tpr is assigned to the array but not a different
value from what is already expected on the vp the code will skip incrementing
the reg_count. In this case its possible that we set an invalid memory section
of the next call for DeliverabilityNotifications that was not expected.

The fix is to use a local variable to store the temporary tpr and only update
the array if the local tpr value is different than the vp context.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: e2940978fc86b2bf2016e115c56c01f850092bfb
      
https://github.com/qemu/qemu/commit/e2940978fc86b2bf2016e115c56c01f850092bfb
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  WHXP Removes the use of WHvGetExitContextSize

The use of WHvGetExitContextSize will break ABI compatibility if the platform
changes the context size while a qemu compiled executable does not recompile.
To avoid this we now use sizeof and let the platform determine which version
of the struction was passed for ABI compatibility.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: eb1fe944a89457981407f5335f11bae104a32e57
      
https://github.com/qemu/qemu/commit/eb1fe944a89457981407f5335f11bae104a32e57
  Author: Justin Terry (VM) via Qemu-devel <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M target/i386/whpx-all.c

  Log Message:
  -----------
  WHPX improve interrupt notification registration

Improves the usage of the InterruptNotification registration by skipping the
additional call to WHvSetVirtualProcessorRegisters if we have already
registered for the window exit.

Signed-off-by: Justin Terry (VM) <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Justin Terry (VM) via Qemu-devel <address@hidden>


  Commit: 4060e671c33679198d777558bf7c3750610e0f3d
      
https://github.com/qemu/qemu/commit/4060e671c33679198d777558bf7c3750610e0f3d
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M qemu-doc.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  balloon: Fix documentation of the --balloon parameter and deprecate it

There are two issues with the documentation of the --balloon parameter:
First, "--balloon none" is simply doing nothing. Even if a machine had a
balloon device by default, this option is not disabling anything, it is
simply ignored. Thus let's simply drop this option from the documentation
to avoid to confuse the users (but keep the code in vl.c for backward
compatibility).
Second, the documentation claims that "--balloon virtio" is the default
mode, but this is not true anymore since commit 382f074371f7dc32a34.
Since that commit, the option also has no real use case anymore, since
you can simply use "--device virtio-balloon" nowadays instead. Thus to
simplify our complex parameter zoo a little bit, let's deprecate the
the parameter now and tell the user to use "--device virtio-balloon"
instead.

Fixes: 382f074371f7dc32a34c944c845b1698e83d8c36
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 3e015d815b3f28bfd874bf8a1697308ef9af2b4c
      
https://github.com/qemu/qemu/commit/3e015d815b3f28bfd874bf8a1697308ef9af2b4c
  Author: Julia Suvorova <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M fsdev/virtfs-proxy-helper.c
    M hw/s390x/s390-ccw.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c
    M qemu-io.c
    M qga/commands-posix.c

  Log Message:
  -----------
  use g_path_get_basename instead of basename

basename(3) and dirname(3) modify their argument and may return
pointers to statically allocated memory which may be overwritten by
subsequent calls.
g_path_get_basename and g_path_get_dirname have no such issues, and
therefore more preferable.

Signed-off-by: Julia Suvorova <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b5fe11a49ad3df109bfb32dea2f2ef74d1d3ca13
      
https://github.com/qemu/qemu/commit/b5fe11a49ad3df109bfb32dea2f2ef74d1d3ca13
  Author: Peter Maydell <address@hidden>
  Date:   2018-03-06 (Tue, 06 Mar 2018)

  Changed paths:
    M chardev/char-socket.c
    M configure
    M cpus.c
    M exec.c
    M fsdev/virtfs-proxy-helper.c
    M hw/display/g364fb.c
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M hw/i386/pc_q35.c
    M hw/intc/openpic_kvm.c
    M hw/s390x/s390-ccw.c
    M hw/scsi/lsi53c895a.c
    M hw/scsi/scsi-bus.c
    M hw/scsi/spapr_vscsi.c
    M hw/vfio/pci.c
    M hw/vfio/platform.c
    M include/exec/memory-internal.h
    M include/exec/memory.h
    M include/hw/scsi/scsi.h
    M include/qemu/lockable.h
    M include/qom/object.h
    M memory.c
    M qapi/misc.json
    M qdev-monitor.c
    M qemu-doc.texi
    M qemu-io.c
    M qemu-options.hx
    M qga/commands-posix.c
    M qmp.c
    M qom/object.c
    M scripts/checkpatch.pl
    M target/i386/whpx-all.c
    M tests/ahci-test.c
    M tests/qemu-iotests/051
    M tests/sdhci-test.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging

* new QMP command qom-list-properties (Alexey)
* TCG cleanups (David)
* use g_path_get_basename/g_path_get_dirname when useful (Julia)
* WHPX fixes (Justin)
* ASAN fixes (Marc-André)
* g364fb memory leak fix, address_space_to_flatview RCU fixes (me)
* chardev memory leak fix (Peter)
* checkpatch improvements (Julia, Su Hang)
* next round of deprecation patches (Thomas)

# gpg: Signature made Tue 06 Mar 2018 13:11:58 GMT
# gpg:                using RSA key BFFBD25F78C7AE83
# gpg: Good signature from "Paolo Bonzini <address@hidden>"
# gpg:                 aka "Paolo Bonzini <address@hidden>"
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* remotes/bonzini/tags/for-upstream: (34 commits)
  use g_path_get_basename instead of basename
  balloon: Fix documentation of the --balloon parameter and deprecate it
  WHPX improve interrupt notification registration
  WHXP Removes the use of WHvGetExitContextSize
  Fix WHPX issue leaking tpr values
  Fix WHPX typo in 'mmio'
  Fix WHPX additional lock acquisition
  Remove unnecessary WHPX __debugbreak();
  Resolves WHPX breaking changes in SDK 17095
  Fixing WHPX casing to match SDK
  Revert "build-sys: compile with -Og or -O1 when --enable-debug"
  checkpatch: add check for `while` and `for`
  checkpatch: add a warning for basename/dirname
  address_space_rw: address_space_to_flatview needs RCU lock
  address_space_map: address_space_to_flatview needs RCU lock
  address_space_access_valid: address_space_to_flatview needs RCU lock
  address_space_read: address_space_to_flatview needs RCU lock
  address_space_write: address_space_to_flatview needs RCU lock
  memory: inline some performance-sensitive accessors
  openpic_kvm: drop address_space_to_flatview call
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/58e2e17dba49...b5fe11a49ad3
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 723250: g364fb: fix DirtyBitmapSnapshot leak, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 86a3d5: block: Add .bdrv_co_block_status() callback
Next by Date: [Qemu-commits] [qemu/qemu] f32408: misc: don't use hwaddr as a type in trace events
Previous by thread: [Qemu-commits] [qemu/qemu] 86a3d5: block: Add .bdrv_co_block_status() callback
Next by thread: [Qemu-commits] [qemu/qemu] f32408: misc: don't use hwaddr as a type in trace events
Index(es):
- Date
- Thread