qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 0e39c4: build: try improve handling of clang

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 0e39c4: build: try improve handling of clang warnings
Date: Mon, 12 Mar 2018 09:14:07 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0e39c4aa7ecc5699bc391fcb1dceed88d077e99d
      
https://github.com/qemu/qemu/commit/0e39c4aa7ecc5699bc391fcb1dceed88d077e99d
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M configure
    M util/coroutine-ucontext.c

  Log Message:
  -----------
  build: try improve handling of clang warnings

This patch disables the pragma diagnostic -Wunused-but-set-variable for
clang in util/coroutine-ucontext.c.

This in turn allows us to remove it from the configure check, so the
CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE will succeed for clang.

With that in place clang builds (linux) will use -Werror by default,
which breaks the build due to warning about unaligned struct members.

Just turning off this warning isn't a good idea as it indicates
portability problems.  So make it a warning again, using
-Wno-error=address-of-packed-member.  That way it doesn't break the
build but still shows up in the logs.

Now clang builds qemu without errors.  Well, almost.  There are some
left in the rdma code.  Leaving that to the rdma people.  All others can
use --disable-rdma to workarounds this.

Cc: Peter Maydell <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 722cd7496474cebb2218f21e038592fad8603365
      
https://github.com/qemu/qemu/commit/722cd7496474cebb2218f21e038592fad8603365
  Author: Bruce Rogers <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  make: switch language file build to be gtk module aware

Now that gtk support builds as a module, CONFIG_GTK changed from
y to m. Adjust Makefile correspondingly.

Signed-off-by: Bruce Rogers <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2ca5c43091324a68772dc348cdf157c63888c168
      
https://github.com/qemu/qemu/commit/2ca5c43091324a68772dc348cdf157c63888c168
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M configure

  Log Message:
  -----------
  sdl: workaround bug in sdl 2.0.8 headers

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892087

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden


  Commit: 11c82b584a4578f7c7e408448c9f61c729acabae
      
https://github.com/qemu/qemu/commit/11c82b584a4578f7c7e408448c9f61c729acabae
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M include/ui/gtk.h
    M ui/Makefile.objs
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: make GtkGlArea usage a runtime option

Compile in both gtk-egl and gtk-gl-area, then allow to choose at runtime
instead of compile time which opengl variant we want use.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: c923cbedb20d5d4153a02d474ea710d634720622
      
https://github.com/qemu/qemu/commit/c923cbedb20d5d4153a02d474ea710d634720622
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M ui/Makefile.objs

  Log Message:
  -----------
  ui/gtk: group gtk.mo declarations in Makefile

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 2f92f37c9ecaa2a51f75455046b4d1b665db5c12
      
https://github.com/qemu/qemu/commit/2f92f37c9ecaa2a51f75455046b4d1b665db5c12
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M ui/Makefile.objs

  Log Message:
  -----------
  ui/opengl: Makefile cleanup

With gtk.mo bits moved away we don't need the ifeq any more.
Also add missing opengl libs for some objects.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 4c70280592f5357c66f95173ec907920f48c99fa
      
https://github.com/qemu/qemu/commit/4c70280592f5357c66f95173ec907920f48c99fa
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk: use GtkGlArea on wayland only

For dma-buf support we need a egl context.  The gtk x11 backend uses glx
contexts though.  We can't use the GtkGlArea widget on x11 because of
that, so use our own gtk-egl code instead.  wayland continues to use
the GtkGlArea widget.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 70763fea4fbbe2984fd2a8f6ce9c77114af80792
      
https://github.com/qemu/qemu/commit/70763fea4fbbe2984fd2a8f6ce9c77114af80792
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M include/ui/gtk.h
    M ui/gtk-egl.c
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk-egl: add scanout_dmabuf support

Add support for dmabuf scanouts to gtk-egl.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: f1bd313264925dfb229a2152eb3f60fe55746b83
      
https://github.com/qemu/qemu/commit/f1bd313264925dfb229a2152eb3f60fe55746b83
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M include/ui/gtk.h
    M ui/gtk-egl.c
    M ui/gtk.c

  Log Message:
  -----------
  ui/gtk-egl: add cursor_dmabuf support

Add support for cursor dmabufs to gtk-egl.  Just blend in the cursor
(if we have one) when rendering the dmabuf.

Signed-off-by: Gerd Hoffmann <address@hidden>
Message-id: address@hidden


  Commit: 2e5567c903ad05d312de0c3188cb2d3b856fa4c4
      
https://github.com/qemu/qemu/commit/2e5567c903ad05d312de0c3188cb2d3b856fa4c4
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M include/ui/console.h
    M ui/console.c
    M ui/vnc.c

  Log Message:
  -----------
  vnc: deal with surface NULL pointers

Secondary displays in multihead setups are allowed to have a NULL
DisplaySurface.  Typically user interfaces handle this by hiding the
window which shows the display in question.

This isn't an option for vnc though because it simply hasn't a concept
of windows or outputs.  So handle the situation by showing a placeholder
DisplaySurface instead.  Also check in console_select whenever a surface
is preset in the first place before requesting an update.

This fixes a segfault which can be triggered by switching to an unused
display (via vtrl-alt-<nr>) in a multihead setup, for example using
-device virtio-vga,max_outputs=2.

Cc: Christian Borntraeger <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Christian Borntraeger <address@hidden>
Message-id: address@hidden


  Commit: e181f8bbd011dbe9f30a58145215f47c4bb6ac6b
      
https://github.com/qemu/qemu/commit/e181f8bbd011dbe9f30a58145215f47c4bb6ac6b
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M ui/spice-display.c
    M ui/trace-events

  Log Message:
  -----------
  spice: drop dprint() debug logging

Some calls are deleted, some are converted into tracepoints.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden


  Commit: cd2452b279b217d7e6ee48478d6bb3109f388fcb
      
https://github.com/qemu/qemu/commit/cd2452b279b217d7e6ee48478d6bb3109f388fcb
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M ui/spice-display.c

  Log Message:
  -----------
  spice: add scanout_dmabuf support

Add support for scanout dmabufs.  Just
pass them through to spice-server.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden


  Commit: b153f9019b5fcf7c085de688b123eb34f924f870
      
https://github.com/qemu/qemu/commit/b153f9019b5fcf7c085de688b123eb34f924f870
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M include/ui/spice-display.h
    M ui/spice-display.c
    M ui/trace-events

  Log Message:
  -----------
  spice: add cursor_dmabuf support

Add support for cursor dmabufs.  qemu has to render the cursor for
that, so in case a cursor is present qemu allocates a new dmabuf, blits
the scanout, blends in the pointer and passes on the new dmabuf to
spice-server.  Without cursor qemu continues to simply pass on the
scanout dmabuf as-is.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Message-id: address@hidden


  Commit: f771c5440e04626f1cf9a6a7d1b1c6cd8168cacd
      
https://github.com/qemu/qemu/commit/f771c5440e04626f1cf9a6a7d1b1c6cd8168cacd
  Author: Thomas Huth <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M hmp-commands.hx
    M hmp.c
    M qapi/ui.json
    M ui/console.c

  Log Message:
  -----------
  qapi: Add device ID and head parameters to screendump

QEMU's screendump command can only take dumps from the primary display.
When using multiple VGA cards, there is no way to get a dump from a
secondary card or other display heads yet. So let's add a 'device' and
a 'head' parameter to the HMP and QMP commands to be able to specify
alternative devices and heads with the screendump command, too.

Reviewed-by: Daniel P. Berrangé <address@hidden>
Acked-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: b16a54da0696efc5d91b6c3597a37a317abb5de7
      
https://github.com/qemu/qemu/commit/b16a54da0696efc5d91b6c3597a37a317abb5de7
  Author: Peter Maydell <address@hidden>
  Date:   2018-03-12 (Mon, 12 Mar 2018)

  Changed paths:
    M Makefile
    M configure
    M hmp-commands.hx
    M hmp.c
    M include/ui/console.h
    M include/ui/gtk.h
    M include/ui/spice-display.h
    M qapi/ui.json
    M ui/Makefile.objs
    M ui/console.c
    M ui/gtk-egl.c
    M ui/gtk.c
    M ui/spice-display.c
    M ui/trace-events
    M ui/vnc.c
    M util/coroutine-ucontext.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/ui-20180312-pull-request' 
into staging

gtk,spice: add dmabuf support.
sdl,vnc,gtk: bugfixes.
ui/qapi: add device ID and head parameters to screendump.
build: try improve handling of clang warnings.

# gpg: Signature made Mon 12 Mar 2018 09:13:28 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/ui-20180312-pull-request:
  qapi: Add device ID and head parameters to screendump
  spice: add cursor_dmabuf support
  spice: add scanout_dmabuf support
  spice: drop dprint() debug logging
  vnc: deal with surface NULL pointers
  ui/gtk-egl: add cursor_dmabuf support
  ui/gtk-egl: add scanout_dmabuf support
  ui/gtk: use GtkGlArea on wayland only
  ui/opengl: Makefile cleanup
  ui/gtk: group gtk.mo declarations in Makefile
  ui/gtk: make GtkGlArea usage a runtime option
  sdl: workaround bug in sdl 2.0.8 headers
  make: switch language file build to be gtk module aware
  build: try improve handling of clang warnings

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/819fd4699c7b...b16a54da0696
reply via email to
[Prev in Thread] Current Thread [Next in Thread]