[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 44acd4: block: include original filename when
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 44acd4: block: include original filename when reporting in... |
Date: |
Thu, 15 Mar 2018 02:52:39 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 44acd46f60ce6f16d369cd443e77949deca56a2c
https://github.com/qemu/qemu/commit/44acd46f60ce6f16d369cd443e77949deca56a2c
Author: Daniel P. Berrangé <address@hidden>
Date: 2018-03-13 (Tue, 13 Mar 2018)
Changed paths:
M block/gluster.c
M block/sheepdog.c
Log Message:
-----------
block: include original filename when reporting invalid URIs
Consider passing a JSON based block driver to "qemu-img commit"
$ qemu-img commit 'json:{"driver":"qcow2","file":{"driver":"gluster",\
"volume":"gv0","path":"sn1.qcow2",
"server":[{"type":\
"tcp","host":"10.73.199.197","port":"24007"}]},}'
Currently it will commit the content and then report an incredibly
useless error message when trying to re-open the committed image:
qemu-img: invalid URI
Usage:
file=gluster[+transport]://[host[:port]]volume/path[?socket=...][,file.debug=N][,file.logfile=/path/filename.log]
With this fix we get:
qemu-img: invalid URI json:{"server.0.host": "10.73.199.197",
"driver": "gluster", "path": "luks.qcow2", "server.0.type":
"tcp", "server.0.port": "24007", "volume": "gv0"}
Of course the root cause problem still exists, but now we know
what actually needs fixing.
Signed-off-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>
Commit: 3a2e46ae1de4f45b88211306a2b6c0c5efd368ab
https://github.com/qemu/qemu/commit/3a2e46ae1de4f45b88211306a2b6c0c5efd368ab
Author: Peter Maydell <address@hidden>
Date: 2018-03-13 (Tue, 13 Mar 2018)
Changed paths:
M block/gluster.c
M block/sheepdog.c
Log Message:
-----------
Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
staging
# gpg: Signature made Tue 13 Mar 2018 12:28:21 GMT
# gpg: using RSA key BDBE7B27C0DE3057
# gpg: Good signature from "Jeffrey Cody <address@hidden>"
# gpg: aka "Jeffrey Cody <address@hidden>"
# gpg: aka "Jeffrey Cody <address@hidden>"
# Primary key fingerprint: 9957 4B4D 3474 90E7 9D98 D624 BDBE 7B27 C0DE 3057
* remotes/cody/tags/block-pull-request:
block: include original filename when reporting invalid URIs
Signed-off-by: Peter Maydell <address@hidden>
Compare: https://github.com/qemu/qemu/compare/026aaf47c02b...3a2e46ae1de4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 44acd4: block: include original filename when reporting in...,
GitHub <=