[Qemu-commits] [qemu/qemu] 143c04: ps2: Clear the PS/2 queue and obey disable

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 143c04c7e0639e53086519592ead15d2556bfbf2
      
https://github.com/qemu/qemu/commit/143c04c7e0639e53086519592ead15d2556bfbf2
  Author: Geoffrey McRae <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M hw/input/ps2.c

  Log Message:
  -----------
  ps2: Clear the PS/2 queue and obey disable

This allows guest's to correctly reinitialize and identify the mouse
should the guest decide to re-scan or reset during mouse input events.

When the guest sends the "Identify" command, due to the PC's hardware
architecutre it is impossible to reliably determine the response from
the command amongst other streaming data, such as mouse or keyboard
events. Standard practice is for the guest to disable the device and
then issue the identify command, so this must be obeyed.

Signed-off-by: Geoffrey McRae <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 7abe7eb29494b4e4a11ec99ae5623083409a2f1e
      
https://github.com/qemu/qemu/commit/7abe7eb29494b4e4a11ec99ae5623083409a2f1e
  Author: Geoffrey McRae <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M hw/input/ps2.c
    M include/hw/input/ps2.h

  Log Message:
  -----------
  ps2: Fix mouse stream corruption due to lost data

This fixes an issue by adding bounds checking to multi-byte packets
where the PS/2 mouse data stream may become corrupted due to data being
discarded when the PS/2 ringbuffer is full.

Interrupts for Multi-byte responses are postponed until the final byte
has been queued.

These changes fix a bug where windows guests drop the mouse device
entirely requring the guest to be restarted.

Signed-off-by: Geoffrey McRae <address@hidden>
Message-Id: <address@hidden>

[ kraxel: codestyle fixes ]

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: ad1b4ec39caa5b3f17cbd8160283a03a3dcfe2ae
      
https://github.com/qemu/qemu/commit/ad1b4ec39caa5b3f17cbd8160283a03a3dcfe2ae
  Author: Peter Maydell <address@hidden>
  Date:   2018-05-15 (Tue, 15 May 2018)

  Changed paths:
    M hw/input/ps2.c
    M include/hw/input/ps2.h

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/input-20180515-pull-request' into staging

input: ps2 fixes.

# gpg: Signature made Tue 15 May 2018 10:43:20 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/input-20180515-pull-request:
  ps2: Fix mouse stream corruption due to lost data
  ps2: Clear the PS/2 queue and obey disable

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/c13547feeec9...ad1b4ec39caa
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.