[Qemu-commits] [qemu/qemu] 19020d: coverity-model: Fix replay_get_byte()

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 19020d41759c7d34eae78d6afbec27c523d55bcd
      
https://github.com/qemu/qemu/commit/19020d41759c7d34eae78d6afbec27c523d55bcd
  Author: Markus Armbruster <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M scripts/coverity-model.c

  Log Message:
  -----------
  coverity-model: Fix replay_get_byte()

Coverity 2018.06 chokes on replay_get_byte():

    $ cov-make-library -of scripts/coverity-model.xmldb scripts/coverity-model.c
    output file: scripts/coverity-model.xmldb
    Compiling scripts/coverity-model.c with command 
/opt/cov-sa-2018.06/bin/cov-emit --dir 
/tmp/cov-armbru/930a6fb31e5f464fc1a53354b2deb66b/cov-make-library-emit -w 
--no_error_recovery --emit_header_functions --no_implicit_decl --preinclude 
/opt/cov-sa-2018.06/library/decls.h --c scripts/coverity-model.c
    "scripts/coverity-model.c", line 110: error #20: identifier "replay_file" is
        undefined
     if (replay_file) {
         ^

    Emit for file '/work/armbru/qemu/scripts/coverity-model.c' complete.
    [ERROR] 1 error detected in the compilation of "scripts/coverity-model.c".
    ERROR: cov-emit returned with code 1

Broken in commit 04a0afe5285.  Fix by dumbing down.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>


  Commit: efe2606862e7c13e84f0d27eccf5d037a5822896
      
https://github.com/qemu/qemu/commit/efe2606862e7c13e84f0d27eccf5d037a5822896
  Author: Peter Maydell <address@hidden>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M scripts/coverity-model.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-cov-model-2018-07-05' 
into staging

Coverity model patches for 2018-07-05

# gpg: Signature made Thu 05 Jul 2018 14:11:03 BST
# gpg:                using RSA key 3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-cov-model-2018-07-05:
  coverity-model: Fix replay_get_byte()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/1daf14ec9e66...efe2606862e7
      **NOTE:** This service been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.