[Qemu-commits] [qemu/qemu] 1d9cb4: Remove the deprecated -balloon option

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 1d9cb42c5654772efec1977957584a21763013a1
      
https://github.com/qemu/qemu/commit/1d9cb42c5654772efec1977957584a21763013a1
  Author: Thomas Huth <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M docs/virtio-balloon-stats.txt
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  Remove the deprecated -balloon option

The "-balloon" option has been replaced by "-device virtio-balloon".
It's been marked as deprecated since two releases, and nobody
complained, so let's remove it now.

Acked-by: Paolo Bonzini <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
Acked-by: Peter Krempa <address@hidden>
Acked-by: Ján Tomko <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 2feac451d2b4492aa8a67f40bd20dd351941d1a2
      
https://github.com/qemu/qemu/commit/2feac451d2b4492aa8a67f40bd20dd351941d1a2
  Author: Thomas Huth <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M docs/interop/live-block-operations.rst
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  Remove the deprecated -nodefconfig option

It's the same as -no-user-config and marked as deprecated since three
releases already. Time to remove it now.

Acked-by: Peter Krempa <address@hidden>
Acked-by: Ján Tomko <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: fdaf2d5885209634bf9d9f643cec5323efb4525c
      
https://github.com/qemu/qemu/commit/fdaf2d5885209634bf9d9f643cec5323efb4525c
  Author: Thomas Huth <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  Remove the deprecated options -startdate, -localtime and -rtc-td-hack

Deprecated since two releases, nobody complained, thus it's time to
remove them now.

Acked-by: Peter Krempa <address@hidden>
Acked-by: Ján Tomko <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: d18572dd9a4ee3f66d205912edae4d87a58ec11f
      
https://github.com/qemu/qemu/commit/d18572dd9a4ee3f66d205912edae4d87a58ec11f
  Author: Thomas Huth <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M include/net/net.h
    M include/net/slirp.h
    M net/slirp.c
    M os-posix.c
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  net: Remove the deprecated -tftp, -bootp, -redir and -smb options

These options likely do not work as expected as soon as the user
tries to use more than one network interface at once. The parameters
have been marked as deprecated since QEMU v2.6, so users had plenty
of time to move their scripts to the new syntax. Time to remove the
old parameters now.

Reviewed-by: Samuel Thibault <address@hidden>
Acked-by: Peter Krempa <address@hidden>
Acked-by: Ján Tomko <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: b8e1f74b0a258db394a35272a44d14ec0b6e0be9
      
https://github.com/qemu/qemu/commit/b8e1f74b0a258db394a35272a44d14ec0b6e0be9
  Author: Eric Blake <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M tests/libqos/libqos.c

  Log Message:
  -----------
  tests/libqos: Utilize newer glib spawn check

During development, I got a 'make check' failure that claimed:

qemu-img returned status code 32512
**
ERROR:tests/libqos/libqos.c:202:mkimg: assertion failed: (!rc)

But 32512 is too big for a normal exit status value, which means we
failed to use WEXITSTATUS() to shift the bits to the desired value
for printing.  However, instead of worrying about how to portably
parse g_spawn()'s rc in the proper platform-dependent manner, it's
better to just rely on the fact that we now require glib 2.40 (since
commit e7b3af815) and can therefore use glib's portable checker
instead, where the message under my same condition improves to:

Child process exited with code 127
**
ERROR:tests/libqos/libqos.c:192:mkimg: assertion failed: (ret && !err)

Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: ebb4d82d88810c31cb5eee408e1ac6d319f7f9bb
      
https://github.com/qemu/qemu/commit/ebb4d82d88810c31cb5eee408e1ac6d319f7f9bb
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M tests/drive_del-test.c
    M tests/libqtest.c
    M tests/libqtest.h
    M tests/qmp-test.c
    M tests/test-qga.c

  Log Message:
  -----------
  tests: add qmp_assert_error_class()

This helper will simplify a bunch of code checking for QMP errors and
can be shared by various tests.  Note that test-qga does check for
error description as well, so don't replace the code there for now.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 442b09b83d256d1ba4daa62cb939c84c829cc0f3
      
https://github.com/qemu/qemu/commit/442b09b83d256d1ba4daa62cb939c84c829cc0f3
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M tests/qmp-cmd-test.c

  Log Message:
  -----------
  tests: add qmp/object-add-without-props test

test_object_add_without_props() tests a bug in qmp_object_add() we
fixed in commit e64c75a975.  Sadly, we don't have systematic
object-add tests.  This lone test can go into qmp-cmd-test for want of
a better home.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 2b70ea92766f5a1a735a44e28c92cdfba3c4054f
      
https://github.com/qemu/qemu/commit/2b70ea92766f5a1a735a44e28c92cdfba3c4054f
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M tests/qmp-test.c

  Log Message:
  -----------
  tests: add qmp/qom-set-without-value test

test_qom_set_without_value() is about a bug in infrastructure used by
the QMP core, fixed in commit c489780203.  We covered the bug in
infrastructure unit tests (commit bce3035a44).  I wrote that test
earlier, to cover QMP level as well, the test could go into qmp-test.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: ae6bf766048ecaeef90b85c4fb2b4db2aa0c094c
      
https://github.com/qemu/qemu/commit/ae6bf766048ecaeef90b85c4fb2b4db2aa0c094c
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-08-31 (Fri, 31 Aug 2018)

  Changed paths:
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/test-qmp-cmds.c

  Log Message:
  -----------
  tests: add a qmp success-response test

Verify the usage of this schema feature and the API behaviour.  This
should be the only case where qmp_dispatch() returns NULL.

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>


  Commit: 09d8277eb0cc40e7b29c5d4795bb9aaa7d8bbdcc
      
https://github.com/qemu/qemu/commit/09d8277eb0cc40e7b29c5d4795bb9aaa7d8bbdcc
  Author: Peter Maydell <address@hidden>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M docs/interop/live-block-operations.rst
    M docs/virtio-balloon-stats.txt
    M include/net/net.h
    M include/net/slirp.h
    M net/slirp.c
    M os-posix.c
    M qemu-deprecated.texi
    M qemu-options.hx
    M tests/drive_del-test.c
    M tests/libqos/libqos.c
    M tests/libqtest.c
    M tests/libqtest.h
    M tests/qapi-schema/qapi-schema-test.json
    M tests/qapi-schema/qapi-schema-test.out
    M tests/qmp-cmd-test.c
    M tests/qmp-test.c
    M tests/test-qga.c
    M tests/test-qmp-cmds.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/huth-gitlab/tags/pull-request-2018-08-31' into staging

Removal of deprecated options and improvements for the qtests

# gpg: Signature made Fri 31 Aug 2018 09:10:23 BST
# gpg:                using RSA key 2ED9D774FE702DB5
# gpg: Good signature from "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# gpg:                 aka "Thomas Huth <address@hidden>"
# Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5

* remotes/huth-gitlab/tags/pull-request-2018-08-31:
  tests: add a qmp success-response test
  tests: add qmp/qom-set-without-value test
  tests: add qmp/object-add-without-props test
  tests: add qmp_assert_error_class()
  tests/libqos: Utilize newer glib spawn check
  net: Remove the deprecated -tftp, -bootp, -redir and -smb options
  Remove the deprecated options -startdate, -localtime and -rtc-td-hack
  Remove the deprecated -nodefconfig option
  Remove the deprecated -balloon option

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2fde22f8ae1a...09d8277eb0cc
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.