[Qemu-commits] [qemu/qemu] c55510: qemu-error: add {error, warn}_report_once_cond

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c55510b72218a2d0b263eda006fd7aac1496b694
      
https://github.com/qemu/qemu/commit/c55510b72218a2d0b263eda006fd7aac1496b694
  Author: Cornelia Huck <address@hidden>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M hw/vfio/ccw.c
    M include/qemu/error-report.h
    M util/qemu-error.c

  Log Message:
  -----------
  qemu-error: add {error, warn}_report_once_cond

Add two functions to print an error/warning report once depending
on a passed-in condition variable and flip it if printed. This is
useful if you want to print a message not once-globally, but e.g.
once-per-device.

Inspired by warn_once() in hw/vfio/ccw.c, which has been replaced
with warn_report_once_cond().

Signed-off-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Function comments reworded]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c6c594596eabc80f6e54d96c56f01f8531d389b5
      
https://github.com/qemu/qemu/commit/c6c594596eabc80f6e54d96c56f01f8531d389b5
  Author: Cornelia Huck <address@hidden>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M include/qemu/error-report.h

  Log Message:
  -----------
  qemu-error: make use of {error, warn}_report_once_cond

{error,warn}_report_once() are a special case of the new functions
and can simply switch to them.

Signed-off-by: Cornelia Huck <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
[Dispense with unlikely() to keep the macros as simple as possible]
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: 371b74e2215fde31cc22d23dfa710e11bb906038
      
https://github.com/qemu/qemu/commit/371b74e2215fde31cc22d23dfa710e11bb906038
  Author: Mao Zhongyi <address@hidden>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M hw/i386/multiboot.c
    M hw/ppc/e500.c
    M hw/ppc/sam460ex.c
    M hw/riscv/sifive_e.c
    M hw/riscv/sifive_u.c
    M hw/riscv/spike.c
    M hw/riscv/virt.c

  Log Message:
  -----------
  Drop "qemu:" prefix from error_report() arguments

error_report and friends already add a "qemu-system-xxx" prefix
to the string, so a "qemu:" prefix is redundant in the string.
Just drop it.

Reported-by: Thomas Huth <address@hidden>
Signed-off-by: Mao Zhongyi <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
Message-Id: <address@hidden>
Acked-by: David Gibson <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>


  Commit: c468e368e102e8bb93cbbf1c3daa0c04d361d3c4
      
https://github.com/qemu/qemu/commit/c468e368e102e8bb93cbbf1c3daa0c04d361d3c4
  Author: Markus Armbruster <address@hidden>
  Date:   2018-09-24 (Mon, 24 Sep 2018)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Fix F: patterns that don't match anything

Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
hw/sparc/sun4m_iommu.c without updating MAINTAINERS.

Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
MAINTAINERS.

Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.

Commit 33e9e9bd62d fat-fingered include/qemu/job.h.

Commit eb815e248f5 moved qapi-schema.json to qapi/ without updating
MAINTAINERS.

Commit 2e3c8f8dbdd converted docs/devel/migration.txt to
docs/devel/migration.rst without updating MAINTAINERS.

Offenders tracked down with the following shell loop:

    shopt -s nullglob
    for i in `sed -n 's/^F: //p' <MAINTAINERS `
    do
  glob="`echo $i`"
  if [ "$glob" = "$i" ]
  then [ ! -e $i ]
  else [ -z "$glob" ]
  fi && echo "$i"
    done

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>


  Commit: 2f831d04985f064e9306fa58db516e0a3e1df918
      
https://github.com/qemu/qemu/commit/2f831d04985f064e9306fa58db516e0a3e1df918
  Author: Peter Maydell <address@hidden>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M MAINTAINERS
    M hw/i386/multiboot.c
    M hw/ppc/e500.c
    M hw/ppc/sam460ex.c
    M hw/riscv/sifive_e.c
    M hw/riscv/sifive_u.c
    M hw/riscv/spike.c
    M hw/riscv/virt.c
    M hw/vfio/ccw.c
    M include/qemu/error-report.h
    M util/qemu-error.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-09-24' into 
staging

Error reporting & miscellaneous patches for 2018-09-24

# gpg: Signature made Mon 24 Sep 2018 16:16:50 BST
# gpg:                using RSA key 3870B400EB918653
# gpg: Good signature from "Markus Armbruster <address@hidden>"
# gpg:                 aka "Markus Armbruster <address@hidden>"
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867  4E5F 3870 B400 EB91 8653

* remotes/armbru/tags/pull-error-2018-09-24:
  MAINTAINERS: Fix F: patterns that don't match anything
  Drop "qemu:" prefix from error_report() arguments
  qemu-error: make use of {error, warn}_report_once_cond
  qemu-error: add {error, warn}_report_once_cond

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/8ca19bd88299...2f831d04985f
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.