[Qemu-commits] [qemu/qemu] c0188e: bt: Mark the bluetooth subsystem as deprecated

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c0188e69d336b5c921e026b3307e70b6ea7e9a47
      
https://github.com/qemu/qemu/commit/c0188e69d336b5c921e026b3307e70b6ea7e9a47
  Author: Thomas Huth <address@hidden>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M qemu-deprecated.texi
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  bt: Mark the bluetooth subsystem as deprecated

It has been unmaintained since years, and there were only trivial or
tree-wide changes to the related files since many years, so the
code is likely very bitrotten and broken. For example the following
segfaults as soon as as you press a key:

 qemu-system-x86_64 -usb -device usb-bt-dongle -bt hci -bt device:keyboard

Since we are not aware of anybody using bluetooth with the current
version of QEMU, let's mark the subsystem as deprecated, with a special
request for the users to write to the qemu-devel mailing list in case
they still use it (so we could revert the deprecation status in that
case).

Signed-off-by: Thomas Huth <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 627c865d22d63aadcf2909fe0476768bcdeef65c
      
https://github.com/qemu/qemu/commit/627c865d22d63aadcf2909fe0476768bcdeef65c
  Author: Marc-André Lureau <address@hidden>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M hw/display/edid-generate.c

  Log Message:
  -----------
  edid: silence a stringop-overflow warning

Simplify the code that doesn't need strncpy() since length of string
is already computed.

/home/elmarco/src/qemu/hw/display/edid-generate.c: In function 'edid_desc_text':
/home/elmarco/src/qemu/hw/display/edid-generate.c:168:5: error: 'strncpy' 
specified bound depends on the length of the source argument 
[-Werror=stringop-overflow=]
     strncpy((char *)(desc + 5), text, len);
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/elmarco/src/qemu/hw/display/edid-generate.c:164:11: note: length computed 
here
     len = strlen(text);
     ^~~~~~~~~~~~
cc1: all warnings being treated as errors

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 6cdc2d189cb60a9d13e2d975b3fdb12eb00885cc
      
https://github.com/qemu/qemu/commit/6cdc2d189cb60a9d13e2d975b3fdb12eb00885cc
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M audio/paaudio.c

  Log Message:
  -----------
  pulseaudio: process audio data in smaller chunks

The rate of pulseaudio absorbing the audio stream is used to control the
the rate of the guests audio stream.  When the emulated hardware uses
small chunks (like intel-hda does) we need small chunks on the audio
backend side too, otherwise that feedback loop doesn't work very well.

Cc: Max Ehrlich <address@hidden>
Cc: Martin Schrodt <address@hidden>
Buglink: https://bugs.launchpad.net/bugs/1795527
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden


  Commit: f1aba960cc40ab65fa88c8678883bd2201708c55
      
https://github.com/qemu/qemu/commit/f1aba960cc40ab65fa88c8678883bd2201708c55
  Author: Gerd Hoffmann <address@hidden>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M ui/gtk-egl.c

  Log Message:
  -----------
  ui/gtk: fix cursor in egl mode

In egl mode the scale_x and scale_y variables are not set, so the
scaling logic in the mouse motion event handler does not work.

Fix that.  Also scale the cursor position in gd_egl_cursor_position().

Reported-by: Chen Zhang <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
Tested-by: Chen Zhang <address@hidden>
Message-id: address@hidden


  Commit: 5704c36d25ee84e7129722cb0db53df9faefe943
      
https://github.com/qemu/qemu/commit/5704c36d25ee84e7129722cb0db53df9faefe943
  Author: Peter Maydell <address@hidden>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M audio/paaudio.c
    M hw/display/edid-generate.c
    M qemu-deprecated.texi
    M qemu-options.hx
    M ui/gtk-egl.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/fixes-31-20181112-pull-request' into staging

fixes for 3.1: mark bt as deprecated, bugfixes for pulse, gtk and edid.

# gpg: Signature made Mon 12 Nov 2018 15:14:58 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/fixes-31-20181112-pull-request:
  ui/gtk: fix cursor in egl mode
  pulseaudio: process audio data in smaller chunks
  edid: silence a stringop-overflow warning
  bt: Mark the bluetooth subsystem as deprecated

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/435cc3e4d515...5704c36d25ee
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.