[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 3fccd3: make-release: add skiboot .version fi

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 3fccd3: make-release: add skiboot .version file
Date: Thu, 15 Nov 2018 05:36:23 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 3fccd3f26ef3c0c76a06c138b17af6d55a5d9904
  Author: Michael Roth <address@hidden>
  Date:   2018-11-15 (Thu, 15 Nov 2018)

  Changed paths:
    M scripts/make-release

  Log Message:
  make-release: add skiboot .version file

This is needed to build skiboot from tarball-distributed sources
since the git data the make_release.sh script relies on to generate
it is not available.

Cc: address@hidden
Reported-by: Michael Tokarev <address@hidden>
Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>

  Commit: bba390cb9ee31195f4b5d5b061831f5ca37614e2
  Author: Peter Maydell <address@hidden>
  Date:   2018-11-15 (Thu, 15 Nov 2018)

  Changed paths:
    M linux-user/sparc/signal.c

  Log Message:
  linux-user/sparc/signal.c: Remove dead code

Coverity complains (CID 1390847) about some dead code in
do_sigreturn(). This is an if (err) clause that can never be
true, copied from the kernel (where __get_user returns an error).
The one code path that could report an error is in the
currently commented-out pseudocode for handling FPU register
restoring, so move the if into that comment (and fix the
broken indent in the comment in the process).

(The new position for the error check is also the semantically
correct one -- we should not restore the signal mask from
the signal frame if we get an error here, so the check must
be done before set_sigmask(), not after.)

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Message-id: address@hidden

Compare: https://github.com/qemu/qemu/compare/5eb48906d49e...bba390cb9ee3
      **NOTE:** This service has been marked for deprecation: 

      Functionality will be removed from GitHub.com on January 31st, 2019.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]