[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 773c4a: test-filter-mirror: pass UNIX domain

From: jasowang
Subject: [Qemu-commits] [qemu/qemu] 773c4a: test-filter-mirror: pass UNIX domain socket throug...
Date: Mon, 04 Feb 2019 08:49:58 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 773c4a6228fd910556cee2d477ee56c591a30000
  Author: Jason Wang <address@hidden>
  Date:   2019-02-04 (Mon, 04 Feb 2019)

  Changed paths:
    M tests/test-filter-mirror.c

  Log Message:
  test-filter-mirror: pass UNIX domain socket through fd

The tests tries to let qemu server mode to process the connection
which turns out to be racy after commit 8258292e18c3 ("monitor: Remove
"x-oob", offer capability "oob" unconditionally"). This is because the
filter may try to mirror the packets before UNIX socket object is
ready (connected was set to true) from the view of qemu. In this case
the packet will be dropped silently.

Fixing this by passing pre-connected socket created by socketpair() to
qemu through fd.

Cc: Peter Maydell <address@hidden>
Cc: Li Zhijian <address@hidden>
Cc: Peter Xu <address@hidden>
Cc: Dr. David Alan Gilbert <address@hidden>
Cc: Zhang Chen <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Daniel P. Berrange <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Zhang Chen <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]