[Qemu-commits] [qemu/qemu] ad24c7: multifd: Only send pages when packet are not empty

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ad24c7cb595e7ff3df17f7db790e2a7dfaf8040c
      
https://github.com/qemu/qemu/commit/ad24c7cb595e7ff3df17f7db790e2a7dfaf8040c
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  multifd: Only send pages when packet are not empty

We send packages without pages sometimes for sysnchronizanion.  The
iov functions do the right thing, but we will be changing this code in
future patches.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 6f862692951ad6f31c1c8ea686bd1b85365d36d8
      
https://github.com/qemu/qemu/commit/6f862692951ad6f31c1c8ea686bd1b85365d36d8
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  multifd: Rename "size" member to pages_alloc

It really indicates what is the number of allocated pages for one
packet.  Once there rename "used" to "pages_used".

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 2a34ee593bb08570fe29420d2309ece9f319014b
      
https://github.com/qemu/qemu/commit/2a34ee593bb08570fe29420d2309ece9f319014b
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/ram.c
    M migration/trace-events

  Log Message:
  -----------
  multifd: Create new next_packet_size field

We need to send this field when we add compression support.  As we are
still on x- stage, we can do this kind of changes.

Signed-off-by: Juan Quintela <address@hidden>


  Commit: efd1a1d6407f73565cf3b4089a2baa4bad0650f8
      
https://github.com/qemu/qemu/commit/efd1a1d6407f73565cf3b4089a2baa4bad0650f8
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M hmp.c
    M migration/migration.c
    M migration/migration.h
    M migration/ram.c
    M qapi/migration.json

  Log Message:
  -----------
  multifd: Drop x-multifd-page-count parameter

Libvirt don't want to expose (and explain it).  From now on we measure
the number of packages in bytes instead of pages, so it is the same
independently of architecture.  We choose the page size of x86.
Notice that in the following patch we make this variable.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 7ed379b286dc6d3942ae851bdfa87b45b99ae9ff
      
https://github.com/qemu/qemu/commit/7ed379b286dc6d3942ae851bdfa87b45b99ae9ff
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  multifd: Be flexible about packet size

This way we can change the packet size in the future and everything
will work.  We choose an arbitrary big number (100 times configured
size) as a limit about how big we will reallocate.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 4b0c72645c468827dbdf04594fcb274741fecbb1
      
https://github.com/qemu/qemu/commit/4b0c72645c468827dbdf04594fcb274741fecbb1
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  multifd: Change default packet size

We moved from 64KB to 512KB, as it makes less locking contention
without any downside in testing.

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 5fbd8b4bbb959cc5534bf488505ce85455fa4271
      
https://github.com/qemu/qemu/commit/5fbd8b4bbb959cc5534bf488505ce85455fa4271
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/ram.c

  Log Message:
  -----------
  multifd: Add some padding

Add some padding.
MultifdInit_t is padded to 64 bytes.
MultiFDPacket_t is padded to 320bytes (64 * 5).

Signed-off-by: Juan Quintela <address@hidden>


  Commit: cbfd6c957a4437d4759ca660e621daa381bf2898
      
https://github.com/qemu/qemu/commit/cbfd6c957a4437d4759ca660e621daa381bf2898
  Author: Juan Quintela <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M hmp.c
    M migration/migration.c
    M qapi/migration.json

  Log Message:
  -----------
  multifd: Drop x-

We make it supported from now on.

Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: d2f1d29b95aa45d13262b39153ff501ed6b1ac95
      
https://github.com/qemu/qemu/commit/d2f1d29b95aa45d13262b39153ff501ed6b1ac95
  Author: Daniel P. Berrange <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M hmp.c
    M migration/migration.c
    M migration/tls.c
    M qapi/migration.json

  Log Message:
  -----------
  migration: add support for a "tls-authz" migration parameter

The QEMU instance that runs as the server for the migration data
transport (ie the target QEMU) needs to be able to configure access
control so it can prevent unauthorized clients initiating an incoming
migration. This adds a new 'tls-authz' migration parameter that is used
to provide the QOM ID of a QAuthZ subclass instance that provides the
access control check. This is checked against the x509 certificate
obtained during the TLS handshake.

For example, when starting a QEMU for incoming migration, it is
possible to give an example identity of the source QEMU that is
intended to be connecting later:

  $QEMU \
     -monitor stdio \
     -incoming defer \
     ...other args...

  (qemu) object_add tls-creds-x509,id=tls0,dir=/home/berrange/qemutls,\
             endpoint=server,verify-peer=yes \
  (qemu) object_add authz-simple,id=auth0,identity=CN=laptop.example.com,,\
             O=Example Org,,L=London,,ST=London,,C=GB \
  (qemu) migrate_incoming tcp:localhost:9000

Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 281496bb8aaa36093625d459ac6f5cdcf5fa7c00
      
https://github.com/qemu/qemu/commit/281496bb8aaa36093625d459ac6f5cdcf5fa7c00
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/rdma.c

  Log Message:
  -----------
  migration/rdma: Check qemu_rdma_init_one_block

Actually it can't fail at the moment, but Coverity moans that
it's the only place it's not checked, and it's an easy check.

Reported-by: Coverity (CID 1399413)
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 1fe6ab267fa6c7f75466063763370ef877465a87
      
https://github.com/qemu/qemu/commit/1fe6ab267fa6c7f75466063763370ef877465a87
  Author: Zhang Chen <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/colo.c

  Log Message:
  -----------
  Migration/colo.c: Fix COLO failover status error

When finished COLO failover, the status is FAILOVER_STATUS_COMPLETED.
The origin codes misunderstand the FAILOVER_STATUS_REQUIRE.

Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 3a43ac4757b70dfc2964c12ca1ac82f61128cc04
      
https://github.com/qemu/qemu/commit/3a43ac4757b70dfc2964c12ca1ac82f61128cc04
  Author: Zhang Chen <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/colo.c
    M qapi/migration.json

  Log Message:
  -----------
  Migration/colo.c: Add new COLOExitReason to handle all failover state

In this patch we add the processing state for COLOExitReason,
because we have to identify COLO in the failover processing state or
failover error state. In the way, we can handle all the failover state.
We have improved the description of the COLOExitReason by the way.

Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 82cd368ccd0a962f1f141e0e529abc54d5ab504e
      
https://github.com/qemu/qemu/commit/82cd368ccd0a962f1f141e0e529abc54d5ab504e
  Author: Zhang Chen <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/colo.c

  Log Message:
  -----------
  Migration/colo.c: Add the necessary checks for colo_do_failover

Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 5ed0deca41b201a66d858d7296fe6b780d757404
      
https://github.com/qemu/qemu/commit/5ed0deca41b201a66d858d7296fe6b780d757404
  Author: Zhang Chen <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/colo.c
    M qapi/migration.json

  Log Message:
  -----------
  Migration/colo.c: Make user obtain the last COLO mode info after failover

Add the last_colo_mode to save the status after failover.
This patch can solve the issue that user want to get last colo mode
use query_colo_status after failover.

Signed-off-by: Zhang Chen <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: c38c1c142e64901b09f5ac000695071ed8c0e3a5
      
https://github.com/qemu/qemu/commit/c38c1c142e64901b09f5ac000695071ed8c0e3a5
  Author: Dr. David Alan Gilbert <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M migration/migration.c

  Log Message:
  -----------
  migration/postcopy: Update the bandwidth during postcopy

The recently added max-postcopy-bandwidth parameter is only read
at the transition from precopy->postcopy where as the older
max-bandwidth parameter updates the migration bandwidth when changed
even if the migration is already running.

Fix this discrepency so that:
  a) You can change the bandwidth during postcopy by setting
     max-postcopy-bandwidth

  b) Changing max-bandwidth during postcopy has no effect
     (it currently changes the postcopy bandwidth which isn't
     expected).

Fixes: 7e555c6c
bz: https://bugzilla.redhat.com/show_bug.cgi?id=1686321
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>


  Commit: 7e9a2137ce3bdae00cb864b5f14d7880aa699ad0
      
https://github.com/qemu/qemu/commit/7e9a2137ce3bdae00cb864b5f14d7880aa699ad0
  Author: Peter Maydell <address@hidden>
  Date:   2019-03-25 (Mon, 25 Mar 2019)

  Changed paths:
    M hmp.c
    M migration/colo.c
    M migration/migration.c
    M migration/migration.h
    M migration/ram.c
    M migration/rdma.c
    M migration/tls.c
    M migration/trace-events
    M qapi/migration.json

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/juanquintela/tags/migration-pull-request' into staging

Pull request

- Rebase last pull request
- Drop multifd
- several other minor fixesLaLaLa

# gpg: Signature made Mon 25 Mar 2019 17:46:29 GMT
# gpg:                using RSA key F487EF185872D723
# gpg: Good signature from "Juan Quintela <address@hidden>" [full]
# gpg:                 aka "Juan Quintela <address@hidden>" [full]
# Primary key fingerprint: 1899 FF8E DEBF 58CC EE03  4B82 F487 EF18 5872 D723

* remotes/juanquintela/tags/migration-pull-request:
  migration/postcopy: Update the bandwidth during postcopy
  Migration/colo.c: Make user obtain the last COLO mode info after failover
  Migration/colo.c: Add the necessary checks for colo_do_failover
  Migration/colo.c: Add new COLOExitReason to handle all failover state
  Migration/colo.c: Fix COLO failover status error
  migration/rdma: Check qemu_rdma_init_one_block
  migration: add support for a "tls-authz" migration parameter
  multifd: Drop x-
  multifd: Add some padding
  multifd: Change default packet size
  multifd: Be flexible about packet size
  multifd: Drop x-multifd-page-count parameter
  multifd: Create new next_packet_size field
  multifd: Rename "size" member to pages_alloc
  multifd: Only send pages when packet are not empty

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d132baa05ed7...7e9a2137ce3b