qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] b9cce6: linux-user: Add missing IPV6 sockopts


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] b9cce6: linux-user: Add missing IPV6 sockopts
Date: Fri, 10 May 2019 05:31:56 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b9cce6d756043c92de1c29f73fc744cd3f81ede9
      
https://github.com/qemu/qemu/commit/b9cce6d756043c92de1c29f73fc744cd3f81ede9
  Author: Helge Deller <address@hidden>
  Date:   2019-05-09 (Thu, 09 May 2019)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Add missing IPV6 sockopts

When running ssh over IPv6 with linux-user I faced this warning:
 Unsupported setsockopt level=41 optname=67
 setsockopt IPV6_TCLASS 32: Protocol not available:

This patch adds code to the linux-user emulatation for setting and
retrieving of a few missing IPV6 options, including IPV6_TCLASS.

Signed-off-by: Helge Deller <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: d7eb2b928a855a2e8038e8e75f7edf1a12226bd3
      
https://github.com/qemu/qemu/commit/d7eb2b928a855a2e8038e8e75f7edf1a12226bd3
  Author: Alistair Francis <address@hidden>
  Date:   2019-05-09 (Thu, 09 May 2019)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user/elfload: Fix GCC 9 build warnings

Fix this warning when building with GCC9 on Fedora 30:
In function ‘strncpy’,
    inlined from ‘fill_psinfo’ at 
/home/alistair/qemu/linux-user/elfload.c:3208:12,
    inlined from ‘fill_note_info’ at 
/home/alistair/qemu/linux-user/elfload.c:3390:5,
    inlined from ‘elf_core_dump’ at 
/home/alistair/qemu/linux-user/elfload.c:3539:9:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ 
specified bound 16 equals destination size [-Werror=stringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Alistair Francis <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: b2acfb55962bc8caeaa50a5158da2f701f2c1f7c
      
https://github.com/qemu/qemu/commit/b2acfb55962bc8caeaa50a5158da2f701f2c1f7c
  Author: Daniel P. Berrangé <address@hidden>
  Date:   2019-05-09 (Thu, 09 May 2019)

  Changed paths:
    M linux-user/uname.c

  Log Message:
  -----------
  linux-user: avoid string truncation warnings in uname field copying

In file included from /usr/include/string.h:494,
                 from include/qemu/osdep.h:101,
                 from linux-user/uname.c:20:
In function ‘strncpy’,
    inlined from ‘sys_uname’ at linux-user/uname.c:94:3:
/usr/include/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ 
output may be truncated copying 64 bytes from a string of length 64 
[-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

We don't care where the NUL terminator in the original uname
field was. It suffices to copy the entire original field and
simply force a NUL terminator at the end of the new field.

Signed-off-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 43330b7169ae76222472a4b20c7f4db9d8880527
      
https://github.com/qemu/qemu/commit/43330b7169ae76222472a4b20c7f4db9d8880527
  Author: Erik Kline <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M linux-user/ioctls.h

  Log Message:
  -----------
  The ioctl(SIOCGIFNAME) call requires a struct ifreq.

Signed-off-by: Erik Kline <address@hidden>
Buglink: https://bugs.launchpad.net/qemu/+bug/1814352
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: d87146bce08d3d2ea6c00025d7ee0bfa77991692
      
https://github.com/qemu/qemu/commit/d87146bce08d3d2ea6c00025d7ee0bfa77991692
  Author: Giuseppe Musacchio <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M linux-user/elfload.c

  Log Message:
  -----------
  linux-user: elf: Map empty PT_LOAD segments

Some PT_LOAD segments may be completely zeroed out and their p_filesize
is zero, in that case the loader should just allocate a page that's at
least p_memsz bytes large (plus eventual alignment padding).

Calling zero_bss does this job for us, all we have to do is make sure we
don't try to mmap a zero-length page.

Signed-off-by: Giuseppe Musacchio <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 716cdbe0e846f1b75a1ee629619bfc9337ddb914
      
https://github.com/qemu/qemu/commit/716cdbe0e846f1b75a1ee629619bfc9337ddb914
  Author: Alex Bennée <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M linux-user/signal.c

  Log Message:
  -----------
  linux-user: avoid treading on gprof's SIGPROF signals

The guest tends to get confused when it receives signals it doesn't
know about. Given the gprof magic has also set up it's own handler we
would do well to avoid stomping on it as well.

Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 9b21a36cd333f3f9a1acb379f5f4f4928ad84a06
      
https://github.com/qemu/qemu/commit/9b21a36cd333f3f9a1acb379f5f4f4928ad84a06
  Author: Alex Bennée <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M linux-user/exit.c
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: fix GPROF build failure

When linux-user/exit was introduced we failed to move the gprof
include at the same time. The CI didn't notice because it only builds
system emulation. Fix it for those that still find gprof useful.

Signed-off-by: Alex Bennée <address@hidden>
Tested-by: Laurent Desnogues <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>


  Commit: 5f022626c8807e5848af223908d533973a4b2922
      
https://github.com/qemu/qemu/commit/5f022626c8807e5848af223908d533973a4b2922
  Author: Peter Maydell <address@hidden>
  Date:   2019-05-10 (Fri, 10 May 2019)

  Changed paths:
    M linux-user/elfload.c
    M linux-user/exit.c
    M linux-user/ioctls.h
    M linux-user/signal.c
    M linux-user/syscall.c
    M linux-user/uname.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/linux-user-for-4.1-pull-request' into staging

GPROF fixes, GCC9 fixes, SIOCGIFNAME fix, new IPV6 sockopts, elf fix

# gpg: Signature made Fri 10 May 2019 11:45:23 BST
# gpg:                using RSA key F30C38BD3F2FBE3C
# gpg: Good signature from "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier <address@hidden>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <address@hidden>" [full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/linux-user-for-4.1-pull-request:
  linux-user: fix GPROF build failure
  linux-user: avoid treading on gprof's SIGPROF signals
  linux-user: elf: Map empty PT_LOAD segments
  The ioctl(SIOCGIFNAME) call requires a struct ifreq.
  linux-user: avoid string truncation warnings in uname field copying
  linux-user/elfload: Fix GCC 9 build warnings
  linux-user: Add missing IPV6 sockopts

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/812b835fb4d2...5f022626c880



reply via email to

[Prev in Thread] Current Thread [Next in Thread]