[Qemu-commits] [qemu/qemu] 2bdec3: gdbstub: Fix handling of '!' packet with new infra

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 2bdec3984850a093a6bd97cf0a7183dbb877eb38
      
https://github.com/qemu/qemu/commit/2bdec3984850a093a6bd97cf0a7183dbb877eb38
  Author: Ramiro Polla <address@hidden>
  Date:   2019-08-28 (Wed, 28 Aug 2019)

  Changed paths:
    M gdbstub.c

  Log Message:
  -----------
  gdbstub: Fix handling of '!' packet with new infra

Since the '!' packet is not handled by the new infrastructure,
gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser
value, which would lead to an unsupported packet ("$#00") being sent,
which could confuse the gdb client.

This also has a side-effect of speeding up the initial connection with
gdb.

Fixes: 3e2c12615b52 ("gdbstub: Implement deatch (D pkt) with new infra")
Signed-off-by: Ramiro Polla <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: c6ee95216b1a98c909e24659741622aaf563df86
      
https://github.com/qemu/qemu/commit/c6ee95216b1a98c909e24659741622aaf563df86
  Author: Sandra Loosemore <address@hidden>
  Date:   2019-08-28 (Wed, 28 Aug 2019)

  Changed paths:
    M gdbstub.c

  Log Message:
  -----------
  gdbstub: Fix handler for 'F' packet

Handling of the 'F' packet has been broken since commit
4b20fab101b9e2d0fb47454209637a17fc7a13d5, which converted it to use
the new packet parsing infrastructure.  Per the GDB RSP specification

https://sourceware.org/gdb/current/onlinedocs/gdb/The-F-Reply-Packet.html

the second parameter may be omitted, but the rewritten implementation
was failing to recognize this case.  The result was that QEMU was
repeatedly resending the fileio request and ignoring GDB's replies of
successful completion.  This patch restores the behavior of the
previous code in allowing the errno parameter to be omitted and
passing 0 to the callback in that case.

Signed-off-by: Sandra Loosemore <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 2f1b409a6f6010545866e288299a3336a418ef97
      
https://github.com/qemu/qemu/commit/2f1b409a6f6010545866e288299a3336a418ef97
  Author: Markus Armbruster <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M contrib/gitdm/filetypes.txt

  Log Message:
  -----------
  contrib/gitdm: filetype interface is not in order, fix

gitm prints the rather cryptic message "interface not found, appended
to the last order".  This is because filetypes.txt has filetype
interface, but neglects to mention it in order.  Fix that.

Fixes: 2f28271d807edfcdc47a280c06999dd866dcae10
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 565571820b5d6da0914607e9a839e274e6e84cb1
      
https://github.com/qemu/qemu/commit/565571820b5d6da0914607e9a839e274e6e84cb1
  Author: Markus Armbruster <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M contrib/gitdm/group-map-redhat

  Log Message:
  -----------
  contrib/gitdm: Add address@hidden to group-map-redhat

Just to get the (few) accidental uses of my private e-mail address
attributed correctly.

Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 6b97a1d84aa70eaa9d3a0a5ebd40a926cca512b2
      
https://github.com/qemu/qemu/commit/6b97a1d84aa70eaa9d3a0a5ebd40a926cca512b2
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M .mailmap

  Log Message:
  -----------
  mailmap: Reorder by sections

Our mailmap currently has 4 sections somehow documented.
Reorder few entries not related to "addresses from the original
git import" into the 3rd section, and add a comment to describe
it.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 289371239153b24cb7bd96b6948c6b40b4627a9b
      
https://github.com/qemu/qemu/commit/289371239153b24cb7bd96b6948c6b40b4627a9b
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M .mailmap

  Log Message:
  -----------
  mailmap: Update philmd email address

Use the email address where I spend most of my time.

Suggested-by: Daniel P. Berrangé <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 1fed8f004465ce1cb6994b5d3de6fd7df91c4c33
      
https://github.com/qemu/qemu/commit/1fed8f004465ce1cb6994b5d3de6fd7df91c4c33
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M .mailmap

  Log Message:
  -----------
  mailmap: Add many entries to improve 'git shortlog' statistics

All of these emails have a least 1 commit with utf8/latin1 encoding
issue, or one with no author name.
When there are multiple commits, keep the author name the most used.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: f4cf1edc3b897c5fbc82b388285de53b7f614ca8
      
https://github.com/qemu/qemu/commit/f4cf1edc3b897c5fbc82b388285de53b7f614ca8
  Author: Alex Bennée <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M .mailmap
    M contrib/gitdm/aliases
    M contrib/gitdm/group-map-individuals

  Log Message:
  -----------
  .mailmap/aliases: add some further commentary

The two files are not interchangeable but a change to one *might*
require a change to the other so lets flag that up with an explanation
of what both files are trying to achieve. While we are at it document
the many forms .mailmap can take in the header.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>


  Commit: 0b8b65ed70e2ed711945d523a557cf999eb18f74
      
https://github.com/qemu/qemu/commit/0b8b65ed70e2ed711945d523a557cf999eb18f74
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M contrib/gitdm/domain-map

  Log Message:
  -----------
  contrib/gitdm: Add RT-RK to the domain-map

This company has at least 7 contributors, add a domain-map entry.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Aleksandar Markovic <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 5d3cbddb58823ba0a44fc2b5a90abfec6b56abff
      
https://github.com/qemu/qemu/commit/5d3cbddb58823ba0a44fc2b5a90abfec6b56abff
  Author: Marc-André Lureau <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M tests/modules-test.c
    M ui/Makefile.objs

  Log Message:
  -----------
  build-sys: build ui-spice-app as a module

This reverts commit 45db1ac157 ("modules-test: ui-spice-app is not
built as module") and fixes commit d8aec9d9f1 ("display: add -display
spice-app launching a Spice client").

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 6954a04d5dc587496b9a3f19c6637bf6391696de
      
https://github.com/qemu/qemu/commit/6954a04d5dc587496b9a3f19c6637bf6391696de
  Author: Marc-André Lureau <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M tests/modules-test.c

  Log Message:
  -----------
  tests: fix modules-test with no default machine

Fixes: eb062cfa733 ("tests: add module loading test")
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>


  Commit: 4112aff7cdd932f273e920911a45a5d5a2d5d299
      
https://github.com/qemu/qemu/commit/4112aff7cdd932f273e920911a45a5d5a2d5d299
  Author: Alex Bennée <address@hidden>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M tests/docker/docker.py

  Log Message:
  -----------
  tests/docker: upgrade docker.py to python3

The recent podman changes (9459f754134bb) imported enum which is part
of the python3 standard library but only available as an external
library for python2. This causes problems on the fairly restricted
environment such as shippable. Lets bite the bullet and make the
script a fully python3 one. To that end:

  - drop the from __future__ import (we are there now ;-)
  - avoid the StringIO import hack
  - be consistent with the mode we read/write dockerfiles
  - s/iteritems/items/
  - ensure check_output returns strings for processing

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Cc: Marc-André Lureau <address@hidden>


  Commit: d3714799718b78137f8a14bb1fc2ae28a163dca4
      
https://github.com/qemu/qemu/commit/d3714799718b78137f8a14bb1fc2ae28a163dca4
  Author: Peter Maydell <address@hidden>
  Date:   2019-09-04 (Wed, 04 Sep 2019)

  Changed paths:
    M .mailmap
    M contrib/gitdm/aliases
    M contrib/gitdm/domain-map
    M contrib/gitdm/filetypes.txt
    M contrib/gitdm/group-map-individuals
    M contrib/gitdm/group-map-redhat
    M gdbstub.c
    M tests/docker/docker.py

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/stsquad/tags/pull-gdbstub-gitdm-testing-020919-1' into staging

Various maintainer updates

   - fixes for gdbstub regressions
   - bunch of gitdm/mailmap updates
   - module fixes for Travis
   - docker fixes for shippable

# gpg: Signature made Mon 02 Sep 2019 11:19:04 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>" 
[full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-gdbstub-gitdm-testing-020919-1:
  tests/docker: upgrade docker.py to python3
  tests: fix modules-test with no default machine
  build-sys: build ui-spice-app as a module
  contrib/gitdm: Add RT-RK to the domain-map
  .mailmap/aliases: add some further commentary
  mailmap: Add many entries to improve 'git shortlog' statistics
  mailmap: Update philmd email address
  mailmap: Reorder by sections
  contrib/gitdm: Add address@hidden to group-map-redhat
  contrib/gitdm: filetype interface is not in order, fix
  gdbstub: Fix handler for 'F' packet
  gdbstub: Fix handling of '!' packet with new infra

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/379d83f2c928...d3714799718b