[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5843b6: usb-serial: wakeup device on input

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 5843b6: usb-serial: wakeup device on input
Date: Tue, 10 Mar 2020 10:00:16 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5843b6b35250139d91220ac3b75d467703e345b3
  Author: Jason Andryuk <address@hidden>
  Date:   2020-03-09 (Mon, 09 Mar 2020)

  Changed paths:
    M hw/usb/dev-serial.c

  Log Message:
  usb-serial: wakeup device on input

Currently usb-serial devices are unable to send data into guests with
the xhci controller.  Data is copied into the usb-serial's buffer, but
it is not sent into the guest.  Data coming out of the guest works
properly.  usb-serial devices work properly with ehci.

Have usb-serial call usb_wakeup() when receiving data from the chardev.
This seems to notify the xhci controller and fix inbound data flow.

Also add USB_CFG_ATT_WAKEUP to the device's bmAttributes.  This matches
a real FTDI serial adapter's bmAttributes.

Signed-off-by: Jason Andryuk <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>

  Commit: e13a22db0d47012e19ad02c9dafacbe25f94e1b4
  Author: Chen Qun <address@hidden>
  Date:   2020-03-09 (Mon, 09 Mar 2020)

  Changed paths:
    M hw/usb/hcd-ehci.c

  Log Message:
  usb/hcd-ehci: Remove redundant statements

The "again" assignment is meaningless before g_assert_not_reached.
In addition, the break statements no longer needs to be after

Clang static code analyzer show warning:
hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read
            again = -1;
            ^       ~~

Reported-by: Euler Robot <address@hidden>
Signed-off-by: Chen Qun <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>

  Commit: 7bc4d1980f95387c4cc921d7a066217ff4e42b70
  Author: Peter Maydell <address@hidden>
  Date:   2020-03-10 (Tue, 10 Mar 2020)

  Changed paths:
    M hw/usb/dev-serial.c
    M hw/usb/hcd-ehci.c

  Log Message:
  Merge remote-tracking branch 'remotes/kraxel/tags/usb-20200310-pull-request' 
into staging

usb: bugfixes for ehci & serial.

# gpg: Signature made Tue 10 Mar 2020 08:23:37 GMT
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann <address@hidden>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/usb-20200310-pull-request:
  usb/hcd-ehci: Remove redundant statements
  usb-serial: wakeup device on input

Signed-off-by: Peter Maydell <address@hidden>

Compare: https://github.com/qemu/qemu/compare/7f368aed6721...7bc4d1980f95

reply via email to

[Prev in Thread] Current Thread [Next in Thread]