[Qemu-commits] [qemu/qemu] 923195: target/arm: don't expose "ieee_half" via gdbstub

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9231951aa5ac0ae813818b8ff33d4ccaaabb16e8
      
https://github.com/qemu/qemu/commit/9231951aa5ac0ae813818b8ff33d4ccaaabb16e8
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M target/arm/gdbstub.c

  Log Message:
  -----------
  target/arm: don't expose "ieee_half" via gdbstub

While support for parsing ieee_half in the XML description was added
to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know
if the gdb end will understand it. Disable it for now and allow older
gdbs to successfully connect to the default -cpu max SVE enabled
QEMUs.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 8a2b76ffc9ff610c3439617e19f1eb9be02be50f
      
https://github.com/qemu/qemu/commit/8a2b76ffc9ff610c3439617e19f1eb9be02be50f
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M hw/arm/collie.c

  Log Message:
  -----------
  hw/arm/collie: Put StrongARMState* into a CollieMachineState struct

Coverity complains that the collie_init() function leaks the memory
allocated in sa1110_init().  This is true but not significant since
the function is called only once on machine init and the memory must
remain in existence until QEMU exits anyway.

Still, we can avoid the technical memory leak by keeping the pointer
to the StrongARMState inside the machine state struct.  Switch from
the simple DEFINE_MACHINE() style to defining a subclass of
TYPE_MACHINE which extends the MachineState struct, and keep the
pointer there.

Fixes: CID 1421921
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden


  Commit: f4e1dbc578a051db08a40c05276ebf525b98f949
      
https://github.com/qemu/qemu/commit/f4e1dbc578a051db08a40c05276ebf525b98f949
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M target/arm/helper.c

  Log Message:
  -----------
  target/arm: PSTATE.PAN should not clear exec bits

Our implementation of the PSTATE.PAN bit incorrectly cleared all
access permission bits for privileged access to memory which is
user-accessible.  It should only affect the privileged read and write
permissions; execute permission is dealt with via XN/PXN instead.

Fixes: 81636b70c226dc27d7ebc8d
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-id: address@hidden


  Commit: 07d1be3b3aac20c21ac4a95c7f3f01a3622a31a3
      
https://github.com/qemu/qemu/commit/07d1be3b3aac20c21ac4a95c7f3f01a3622a31a3
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M target/arm/helper.c

  Log Message:
  -----------
  target/arm: Remove obsolete TODO note from get_phys_addr_lpae()

An old comment in get_phys_addr_lpae() claims that the code does not
support the different format TCR for VTCR_EL2.  This used to be true
but it is not true now (in particular the aa64_va_parameters() and
aa32_va_parameters() functions correctly handle the different
register format by checking whether the mmu_idx is Stage2).
Remove the out of date parts of the comment.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-id: address@hidden


  Commit: c88311f272f5599abd7ee12a7a724a4f2bd5820c
      
https://github.com/qemu/qemu/commit/c88311f272f5599abd7ee12a7a724a4f2bd5820c
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M hw/gpio/aspeed_gpio.c

  Log Message:
  -----------
  hw/gpio/aspeed_gpio.c: Don't directly include assert.h

Remove a direct include of assert.h -- this is already
provided by qemu/osdep.h, and it breaks our rule that the
first include must always be osdep.h.

In particular we must get the assert() macro via osdep.h
to avoid compile failures on mingw (see the comment in
osdep.h where we redefine assert() for that platform).

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Message-id: address@hidden


  Commit: 174d2d6856bf435f4f58e9303ba30dd0e1279d3f
      
https://github.com/qemu/qemu/commit/174d2d6856bf435f4f58e9303ba30dd0e1279d3f
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M dump/dump.c

  Log Message:
  -----------
  dump: Fix writing of ELF section

In write_elf_section() we set the 'shdr' pointer to point to local
structures shdr32 or shdr64, which we fill in to be written out to
the ELF dump.  Unfortunately the address we pass to fd_write_vmcore()
has a spurious '&' operator, so instead of writing out the section
header we write out the literal pointer value followed by whatever is
on the stack after the 'shdr' local variable.

Pass the correct address into fd_write_vmcore().

Spotted by Coverity: CID 1421970.

Cc: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden


  Commit: 12ba36d9109a5523fc1947f4e52ab6df940a2dcb
      
https://github.com/qemu/qemu/commit/12ba36d9109a5523fc1947f4e52ab6df940a2dcb
  Author: Edgar E. Iglesias <address@hidden>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M hw/dma/xlnx-zdma.c

  Log Message:
  -----------
  dma/xlnx-zdma: Remove comment

Remove comment.

Signed-off-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Francisco Iglesias <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 28009852aa6b2d1574ba1bfd2461f274cb43fb49
      
https://github.com/qemu/qemu/commit/28009852aa6b2d1574ba1bfd2461f274cb43fb49
  Author: Edgar E. Iglesias <address@hidden>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M hw/dma/xlnx-zdma.c

  Log Message:
  -----------
  dma/xlnx-zdma: Populate DBG0.CMN_BUF_FREE

Populate DBG0.CMN_BUF_FREE so that SW can see some free space.

Signed-off-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Francisco Iglesias <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 4fc4678c6051431b75d3be9304b9c23536f3bb9c
      
https://github.com/qemu/qemu/commit/4fc4678c6051431b75d3be9304b9c23536f3bb9c
  Author: Edgar E. Iglesias <address@hidden>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M hw/dma/xlnx-zdma.c

  Log Message:
  -----------
  dma/xlnx-zdma: Clear DMA_DONE when halting

Clear DMA_DONE when halting the DMA channel.

Signed-off-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Francisco Iglesias <address@hidden>
Acked-by: Alistair Francis <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 4ec037f1dddfd5771f73af2a1c94f7df55d3fc04
      
https://github.com/qemu/qemu/commit/4ec037f1dddfd5771f73af2a1c94f7df55d3fc04
  Author: Edgar E. Iglesias <address@hidden>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M hw/dma/xlnx-zdma.c

  Log Message:
  -----------
  dma/xlnx-zdma: Advance the descriptor address when stopping

Advance the descriptor address when stopping the channel.

Signed-off-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Francisco Iglesias <address@hidden>
Acked-by: Alistair Francis <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 8893790966d9c964557ad01be4a68ef50696ace8
      
https://github.com/qemu/qemu/commit/8893790966d9c964557ad01be4a68ef50696ace8
  Author: Edgar E. Iglesias <address@hidden>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M hw/dma/xlnx-zdma.c

  Log Message:
  -----------
  dma/xlnx-zdma: Reorg to fix CUR_DSCR

Reorganize the descriptor handling so that CUR_DSCR always
points to the next descriptor to be processed.

Signed-off-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Alistair Francis <address@hidden>
Reviewed-by: Francisco Iglesias <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


  Commit: 53ef8a92eb04ee19640f5aad3bff36cd4a36c250
      
https://github.com/qemu/qemu/commit/53ef8a92eb04ee19640f5aad3bff36cd4a36c250
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-06 (Mon, 06 Apr 2020)

  Changed paths:
    M dump/dump.c
    M hw/arm/collie.c
    M hw/dma/xlnx-zdma.c
    M hw/gpio/aspeed_gpio.c
    M target/arm/gdbstub.c
    M target/arm/helper.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20200406' 
into staging

target-arm queue:
 * don't expose "ieee_half" via gdbstub (prevents gdb crashes or errors
   with older GDB versions)
 * hw/arm/collie: Put StrongARMState* into a CollieMachineState struct
 * PSTATE.PAN should not clear exec bits
 * hw/gpio/aspeed_gpio.c: Don't directly include assert.h
   (fixes compilation on some Windows build scenarios)
 * dump: Fix writing of ELF section
 * dma/xlnx-zdma: various bug fixes
 * target/arm/helperc. delete obsolete TODO comment

# gpg: Signature made Mon 06 Apr 2020 11:04:01 BST
# gpg:                using RSA key E1A5C593CD419DE28E8315CF3C2525ED14360CDE
# gpg:                issuer "address@hidden"
# gpg: Good signature from "Peter Maydell <address@hidden>" [ultimate]
# gpg:                 aka "Peter Maydell <address@hidden>" [ultimate]
# gpg:                 aka "Peter Maydell <address@hidden>" [ultimate]
# Primary key fingerprint: E1A5 C593 CD41 9DE2 8E83  15CF 3C25 25ED 1436 0CDE

* remotes/pmaydell/tags/pull-target-arm-20200406:
  dma/xlnx-zdma: Reorg to fix CUR_DSCR
  dma/xlnx-zdma: Advance the descriptor address when stopping
  dma/xlnx-zdma: Clear DMA_DONE when halting
  dma/xlnx-zdma: Populate DBG0.CMN_BUF_FREE
  dma/xlnx-zdma: Remove comment
  dump: Fix writing of ELF section
  hw/gpio/aspeed_gpio.c: Don't directly include assert.h
  target/arm: Remove obsolete TODO note from get_phys_addr_lpae()
  target/arm: PSTATE.PAN should not clear exec bits
  hw/arm/collie: Put StrongARMState* into a CollieMachineState struct
  target/arm: don't expose "ieee_half" via gdbstub

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/547522cd3d2b...53ef8a92eb04