qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 551aff: tests/docker: add docs FEATURE flag a

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 551aff: tests/docker: add docs FEATURE flag and use for te...
Date: Wed, 15 Apr 2020 05:30:32 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 551affb61ecdaf54a24f6d8fa931cfc6e8157500
      
https://github.com/qemu/qemu/commit/551affb61ecdaf54a24f6d8fa931cfc6e8157500
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M tests/docker/dockerfiles/debian10.docker
    M tests/docker/dockerfiles/debian9.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/travis.docker
    M tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/docker/test-misc

  Log Message:
  -----------
  tests/docker: add docs FEATURE flag and use for test-misc

The test-misc docker test fails on a number of images which don't have
the prerequisites to build the docs. Use the FEATURES flag so we can
skip those tests.

As the sphinx test fails to detect whatever feature we need to get
hxtool to work we drop them from debian9 so the windows build doesn't
attempt to build the docs.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 988ae6c3a76789ce0dbc2db0e94b2a333bb73507
      
https://github.com/qemu/qemu/commit/988ae6c3a76789ce0dbc2db0e94b2a333bb73507
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: redirect sphinx-build check to config.log

Otherwise it's hard to debug whats going on.

Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 469a788cdd3c618ef1b8a23a339510082b3eeea7
      
https://github.com/qemu/qemu/commit/469a788cdd3c618ef1b8a23a339510082b3eeea7
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: disable PIE for Windows builds

It seems on some compilers the test can pass but still give you
broken binaries.

Fixes: d2cd29e30736
Fixes: https://bugs.launchpad.net/qemu/+bug/1871798
Cc: Bug 1871798 <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Tested-by: Howard Spoelstra <address@hidden>
Tested-by: James Le Cuirot <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 7ad4d5a43e7e6098acfc28df7666efeb117d22dd
      
https://github.com/qemu/qemu/commit/7ad4d5a43e7e6098acfc28df7666efeb117d22dd
  Author: Alex Bennée <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: fix /proc/self/stat handling

In the original bug report long files names in Guix caused
/proc/self/stat be truncated without the trailing ") " as specified in
proc manpage which says:
    (2) comm  %s
           The  filename of the executable, in parentheses.  This
           is visible whether or not the  executable  is  swapped
           out.

In the kernel this is currently done by do_task_stat calling
proc_task_name() which uses a structure limited by TASK_COMM_LEN (16).

Additionally it should only be reporting the executable name rather
than the full path. Fix both these failings while cleaning up the code
to use GString to build up the reported values. As the whole function
is cleaned up also adjust the white space to the current coding style.

Message-ID: <address@hidden>
Reported-by: Brice Goglin <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>


  Commit: 4b27f9b08352c502ff982df30866063f3025d0ac
      
https://github.com/qemu/qemu/commit/4b27f9b08352c502ff982df30866063f3025d0ac
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M target/m68k/helper.c

  Log Message:
  -----------
  target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray

Since a010bdbe719 the gdbstub API takes a GByteArray*. Unfortunately
we forgot to update the gdb_get_reg*() calls. Do it now.

Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Reported-by: Peter Xu <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: bbc40fefcee0d69d61ceaf8c0695d2ce43cdc87b
      
https://github.com/qemu/qemu/commit/bbc40fefcee0d69d61ceaf8c0695d2ce43cdc87b
  Author: Peter Xu <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M target/i386/gdbstub.c

  Log Message:
  -----------
  gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb

We should only pass in gdb_get_reg16() with the GByteArray* object
itself, no need to shift.  Without this patch, gdb remote attach will
crash QEMU:

  (gdb) target remote :1234
  Remote debugging using :1234
  Remote communication error.  Target disconnected.: Connection reset by peer.
  $ qemu-system-x86_64 -m 1G -smp 4 ... -s
  ERROR:qemu/gdbstub.c:1843:handle_read_all_regs: assertion failed: (len == 
gdbserver_state.mem_buf->len)
  Bail out! ERROR:qemu/gdbstub.c:1843:handle_read_all_regs: assertion failed: 
(len == gdbserver_state.mem_buf->len)

Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Tested-by: Stefano Garzarella <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: 7b8c1527ae0a9ec96a9100a05c680b55eb3aa54f
      
https://github.com/qemu/qemu/commit/7b8c1527ae0a9ec96a9100a05c680b55eb3aa54f
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M include/exec/gdbstub.h
    M target/arm/gdbstub.c
    M target/xtensa/gdbstub.c

  Log Message:
  -----------
  gdbstub: Do not use memset() on GByteArray

Introduce gdb_get_zeroes() to fill a GByteArray with zeroes.

Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Message-Id: <address@hidden>
[AJB: used slightly more gliby set_size approach]
Signed-off-by: Alex Bennée <address@hidden>
Message-Id: <address@hidden>


  Commit: 377f8f08bebea7cd44617b0ac0a2baf307f5f055
      
https://github.com/qemu/qemu/commit/377f8f08bebea7cd44617b0ac0a2baf307f5f055
  Author: Philippe Mathieu-Daudé <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M include/exec/gdbstub.h
    M target/sh4/gdbstub.c

  Log Message:
  -----------
  gdbstub: Introduce gdb_get_float32() to get 32-bit float registers

Since we now use a GByteArray, we can not use stfl_p() directly.
Introduce the gdb_get_float32() helper to load a float32 register.

Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Message-Id: <address@hidden>


  Commit: 73995d15557a3cf2328cc6b7982264897c65cf65
      
https://github.com/qemu/qemu/commit/73995d15557a3cf2328cc6b7982264897c65cf65
  Author: Peter Maydell <address@hidden>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M configure
    M include/exec/gdbstub.h
    M linux-user/syscall.c
    M target/arm/gdbstub.c
    M target/i386/gdbstub.c
    M target/m68k/helper.c
    M target/sh4/gdbstub.c
    M target/xtensa/gdbstub.c
    M tests/docker/dockerfiles/debian10.docker
    M tests/docker/dockerfiles/debian9.docker
    M tests/docker/dockerfiles/fedora.docker
    M tests/docker/dockerfiles/travis.docker
    M tests/docker/dockerfiles/ubuntu.docker
    M tests/docker/dockerfiles/ubuntu1804.docker
    M tests/docker/test-misc

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stsquad/tags/pull-more-fixes-150420-1' 
into staging

More small fixes for rc3

  - tweak docker FEATURE flags for document building
  - include sphinx configure check in config.log
  - disable PIE for Windows builds
  - fix /proc/self/stat handling
  - a number of gdbstub fixups following GByteArray conversion

# gpg: Signature made Wed 15 Apr 2020 11:38:56 BST
# gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
# gpg: Good signature from "Alex Bennée (Master Work Key) <address@hidden>" 
[full]
# Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44

* remotes/stsquad/tags/pull-more-fixes-150420-1:
  gdbstub: Introduce gdb_get_float32() to get 32-bit float registers
  gdbstub: Do not use memset() on GByteArray
  gdbstub: i386: Fix gdb_get_reg16() parameter to unbreak gdb
  target/m68k/helper: Fix m68k_fpu_gdb_get_reg() use of GByteArray
  linux-user: fix /proc/self/stat handling
  configure: disable PIE for Windows builds
  configure: redirect sphinx-build check to config.log
  tests/docker: add docs FEATURE flag and use for test-misc

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2f7cc1fbd6f6...73995d15557a
reply via email to
[Prev in Thread] Current Thread [Next in Thread]