qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] facc68: virtio-mem: Correct format specifier


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] facc68: virtio-mem: Correct format specifier mismatch for ...
Date: Tue, 04 Aug 2020 10:30:33 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: facc68516a7ee6d4992dc47b42b47c600b20b21d
      
https://github.com/qemu/qemu/commit/facc68516a7ee6d4992dc47b42b47c600b20b21d
  Author: Bruce Rogers <brogers@suse.com>
  Date:   2020-08-04 (Tue, 04 Aug 2020)

  Changed paths:
    M hw/virtio/virtio-mem.c

  Log Message:
  -----------
  virtio-mem: Correct format specifier mismatch for RISC-V

This likely affects other, less popular host architectures as well.
Less common host architectures under linux get QEMU_VMALLOC_ALIGN (from
which VIRTIO_MEM_MIN_BLOCK_SIZE is derived) define to a variable of
type uintptr, which isn't compatible with the format specifier used to
print a user message. Since this particular usage of the underlying data
seems unique to this file, the simple fix is to just cast
QEMU_VMALLOC_ALIGN to uint32_t, which corresponds to the format specifier
used.

Signed-off-by: Bruce Rogers <brogers@suse.com>
Message-Id: <20200730130519.168475-1-brogers@suse.com>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta.linux@gmail.com>


  Commit: 881419b7117d5350c2a0288bfb79f2a83715df32
      
https://github.com/qemu/qemu/commit/881419b7117d5350c2a0288bfb79f2a83715df32
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-08-04 (Tue, 04 Aug 2020)

  Changed paths:
    M hw/virtio/virtio-mem.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

virtio: bugfix

A last minute bugfix.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

# gpg: Signature made Tue 04 Aug 2020 16:48:37 BST
# gpg:                using RSA key 5D09FD0871C8F85B94CA8A0D281F0DB8D28D5469
# gpg:                issuer "mst@redhat.com"
# gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>" [full]
# gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>" [full]
# Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
#      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469

* remotes/mst/tags/for_upstream:
  virtio-mem: Correct format specifier mismatch for RISC-V

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/d15532d91be1...881419b7117d



reply via email to

[Prev in Thread] Current Thread [Next in Thread]