[Qemu-commits] [qemu/qemu] 501093: module: silence errors for module_load_qom_all().

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 501093207eb1ed4845e0a65ee1ce7db7b9676e0b
      
https://github.com/qemu/qemu/commit/501093207eb1ed4845e0a65ee1ce7db7b9676e0b
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M include/qemu/module.h
    M softmmu/qtest.c
    M util/module.c

  Log Message:
  -----------
  module: silence errors for module_load_qom_all().

Add mayfail bool parameter to module loading functions.  Set it to true
for module_load_qom_all() because device modules might not load into all
system emulation variants.  qemu-system-s390x for example will not load
qxl because it lacks vga support.  Makes "make check" less chatty.

Drop module_loaded_qom_all check in module_load_qom_one to make sure we
see errors for explicit load requests, i.e. module_load_qom_one("qxl")
failing will log an error no matter whenever module_load_qom_all() was
called before or not.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 20200923091217.22662-1-kraxel@redhat.com


  Commit: f88908cf3014bb028fc5ad33e32aa3065f0c2715
      
https://github.com/qemu/qemu/commit/f88908cf3014bb028fc5ad33e32aa3065f0c2715
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M util/module.c

  Log Message:
  -----------
  modules: update qom object module comment

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200923103728.12026-1-kraxel@redhat.com


  Commit: e220cf866267fbca3dae16f68ec01b67a4beb805
      
https://github.com/qemu/qemu/commit/e220cf866267fbca3dae16f68ec01b67a4beb805
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M ui/spice-app.c

  Log Message:
  -----------
  ui/spice-app: don't use qemu_chr_open_spice_port directly

Save the parent object's open function pointer in the (new)
VCChardevClass struct instead before overwriting it, so we
can look it up when needed.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20201014121120.13482-3-kraxel@redhat.com


  Commit: 70122d62302c97bcd205956a544b8e79f2a4a50f
      
https://github.com/qemu/qemu/commit/70122d62302c97bcd205956a544b8e79f2a4a50f
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M chardev/spice.c
    M include/chardev/spice.h

  Log Message:
  -----------
  chardev/spice: make qemu_chr_open_spice_port static

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20201014121120.13482-4-kraxel@redhat.com


  Commit: 93ab5844b2cd5367966d7b5bae154e0d3303b504
      
https://github.com/qemu/qemu/commit/93ab5844b2cd5367966d7b5bae154e0d3303b504
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M chardev/spice.c
    M include/chardev/spice.h
    M include/ui/qemu-spice.h
    M softmmu/vl.c
    M ui/spice-app.c
    M ui/spice-core.c

  Log Message:
  -----------
  chardev/spice: simplify chardev setup

Initialize spice before chardevs.  That allows to register the spice
chardevs directly in the init function and removes the need to maintain
a linked list of chardevs just for registration.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20201014121120.13482-5-kraxel@redhat.com


  Commit: d72c34cccc5955eeeb393b174fd6a0794b6d823f
      
https://github.com/qemu/qemu/commit/d72c34cccc5955eeeb393b174fd6a0794b6d823f
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M audio/meson.build
    M meson.build
    M monitor/meson.build

  Log Message:
  -----------
  meson: add spice_headers dependency.

Used for files which (with CONFIG_SPICE=y) depend on spice header files
to pick up some enum, but which do not depend on on the actual spice
shared library.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20201014121120.13482-6-kraxel@redhat.com


  Commit: fa264418acff6507b666b7dc987c4a731f84d710
      
https://github.com/qemu/qemu/commit/fa264418acff6507b666b7dc987c4a731f84d710
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M ui/meson.build

  Log Message:
  -----------
  meson: add spice dependency to core spice source files.

Right now it happens to work by pure luck because the spice chardevs
add the spice dependency to the softmmu source set.  That'll change
though once we start building spice chardevs as module, so lets fix
it properly.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20201014121120.13482-7-kraxel@redhat.com


  Commit: 23ebeaae4eb09a0d92dc7f22b41e5dd08485c390
      
https://github.com/qemu/qemu/commit/23ebeaae4eb09a0d92dc7f22b41e5dd08485c390
  Author: Gerd Hoffmann <kraxel@redhat.com>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M chardev/meson.build
    M util/module.c

  Log Message:
  -----------
  chardev/spice: build spice chardevs as module

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 20201014121120.13482-8-kraxel@redhat.com


  Commit: 6214addcc6b6bf6b444934833144bab10cbe6a1a
      
https://github.com/qemu/qemu/commit/6214addcc6b6bf6b444934833144bab10cbe6a1a
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-15 (Thu, 15 Oct 2020)

  Changed paths:
    M audio/meson.build
    M chardev/meson.build
    M chardev/spice.c
    M include/chardev/spice.h
    M include/qemu/module.h
    M include/ui/qemu-spice.h
    M meson.build
    M monitor/meson.build
    M softmmu/qtest.c
    M softmmu/vl.c
    M ui/meson.build
    M ui/spice-app.c
    M ui/spice-core.c
    M util/module.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/kraxel/tags/modules-20201015-pull-request' into staging

modules: misc fixes & tweaks.
modules: build spice chardevs as module.

# gpg: Signature made Thu 15 Oct 2020 13:53:03 BST
# gpg:                using RSA key 4CB6D8EED3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>" [full]
# gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>" [full]
# gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>" [full]
# Primary key fingerprint: A032 8CFF B93A 17A7 9901  FE7D 4CB6 D8EE D3E8 7138

* remotes/kraxel/tags/modules-20201015-pull-request:
  chardev/spice: build spice chardevs as module
  meson: add spice dependency to core spice source files.
  meson: add spice_headers dependency.
  chardev/spice: simplify chardev setup
  chardev/spice: make qemu_chr_open_spice_port static
  ui/spice-app: don't use qemu_chr_open_spice_port directly
  modules: update qom object module comment
  module: silence errors for module_load_qom_all().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3e4074883492...6214addcc6b6