[Qemu-commits] [qemu/qemu] 885538: elf2dmp: Fix memory leak on main() error paths

[Peter Maydell]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 885538fdc9e225a502f5da69e15909664308aa93
      
https://github.com/qemu/qemu/commit/885538fdc9e225a502f5da69e15909664308aa93
  Author: AlexChen <alex.chen@huawei.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  elf2dmp: Fix memory leak on main() error paths

The 'kdgb' is allocating memory in get_kdbg(), but it is not freed
in both fill_header() and fill_context() failed branches, fix it.

Signed-off-by: AlexChen <alex.chen@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <5F463659.8080101@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 018da27970780c0ee4f2df7c06fc7c6c89edb3ee
      
https://github.com/qemu/qemu/commit/018da27970780c0ee4f2df7c06fc7c6c89edb3ee
  Author: Greg Kurz <groug@kaod.org>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Makefile: Add *.[ch].inc files to cscope/ctags/TAGS

The code base has some C source and header files that don't get indexed
because their name ends with .inc:

$ git ls-files "*.[ch].inc" | wc -l
66

Add them to the list.

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <160258069310.900922.1495166540282536628.stgit@bahia.lan>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: c5af3c0d855cc7577b9dd4758f3fcdd7d38b6241
      
https://github.com/qemu/qemu/commit/c5af3c0d855cc7577b9dd4758f3fcdd7d38b6241
  Author: Greg Kurz <groug@kaod.org>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M include/hw/core/cpu.h

  Log Message:
  -----------
  cpus: Drop declaration of cpu_remove()

cpu_remove() got superseded by cpu_remove_sync() in commit dbadee4ff4a0,
but its prototype wasn't removed. We could possibly keep the shorter
cpu_remove() naming but it seems better to highligth that this blocks
until the CPU thread is joined.

Fixes: dbadee4ff4a0 ("cpus: join thread when removing a vCPU")
Cc: pbonzini@redhat.com
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <160268285707.1107461.15035929822602623985.stgit@bahia.lan>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: c8198bd5f991f5674960bf6a7754614f69f71620
      
https://github.com/qemu/qemu/commit/c8198bd5f991f5674960bf6a7754614f69f71620
  Author: Chetan Pant <chetan4windows@gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M include/io/channel-buffer.h
    M include/io/channel-command.h
    M include/io/channel-file.h
    M include/io/channel-socket.h
    M include/io/channel-tls.h
    M include/io/channel-util.h
    M include/io/channel-watch.h
    M include/io/channel-websock.h
    M include/io/channel.h
    M include/io/dns-resolver.h
    M include/io/task.h
    M io/channel-buffer.c
    M io/channel-command.c
    M io/channel-file.c
    M io/channel-socket.c
    M io/channel-tls.c
    M io/channel-util.c
    M io/channel-watch.c
    M io/channel-websock.c
    M io/channel.c
    M io/dns-resolver.c
    M io/task.c
    M tests/test-io-channel-buffer.c
    M tests/test-io-channel-command.c
    M tests/test-io-channel-file.c
    M tests/test-io-channel-socket.c
    M tests/test-io-task.c

  Log Message:
  -----------
  io: Fix Lesser GPL version number

There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.

Signed-off-by: Chetan Pant <chetan4windows@gmail.com>
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20201014134033.14095-1-chetan4windows@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 0dda001b3ac03b24ba90180f558a4d18d8ffed3e
      
https://github.com/qemu/qemu/commit/0dda001b3ac03b24ba90180f558a4d18d8ffed3e
  Author: Chetan Pant <chetan4windows@gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M backends/cryptodev-builtin.c
    M backends/cryptodev-vhost-user.c
    M backends/cryptodev-vhost.c
    M backends/cryptodev.c
    M include/sysemu/cryptodev-vhost-user.h
    M include/sysemu/cryptodev-vhost.h
    M include/sysemu/cryptodev.h

  Log Message:
  -----------
  cryptodev: Fix Lesser GPL version number

There is no "version 2" of the "Lesser" General Public License.
It is either "GPL version 2.0" or "Lesser GPL version 2.1".
This patch replaces all occurrences of "Lesser GPL version 2" with
"Lesser GPL version 2.1" in comment section.

Signed-off-by: Chetan Pant <chetan4windows@gmail.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201014133722.14041-1-chetan4windows@gmail.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 5057bf95814a80c8012d3505d1f26c4545c32f84
      
https://github.com/qemu/qemu/commit/5057bf95814a80c8012d3505d1f26c4545c32f84
  Author: John Snow <jsnow@redhat.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M scripts/qmp/qmp

  Log Message:
  -----------
  scripts/qmp: delete 'qmp' script

This script has not seen a patch that was specifically for this script
since it was moved to this location in 2013, and I doubt it is used. It
uses "man qmp" for its help message, which does not exist. It also
presumes there is a manual page for qmp-XXX, for each defined qmp
command XXX. I don't think that's true.

The format it expects arguments in is something like:

block-dirty-bitmap-add --node=foo --name=bar

and has no capacity to support nested JSON arguments, either.

Most developers use either qmp-shell or socat (or pasting JSON directly
into qmp stdio), so this duplication and additional alternate syntax is
not helpful.

Remove it. Leave a breadcrumb script just in case, to be removed next
release cycle.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201019210430.1063390-1-jsnow@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 5dae6fad949a0852182e7cf653f722d503440089
      
https://github.com/qemu/qemu/commit/5dae6fad949a0852182e7cf653f722d503440089
  Author: Maxim Levitsky <mlevitsk@redhat.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: Fix two typos

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20201019163702.471239-2-mlevitsk@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: e83029fa605d6aa475be60b191f2af3954591093
      
https://github.com/qemu/qemu/commit/e83029fa605d6aa475be60b191f2af3954591093
  Author: John Snow <jsnow@redhat.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    R Changelog
    M README.rst

  Log Message:
  -----------
  CHANGELOG: remove disused file

There's no reason to keep this here; the versions described are
ancient. Everything here is still mirrored on
https://wiki.qemu.org/ChangeLog/old if anyone is curious; otherwise, use
the git history.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20201026195131.13848-1-jsnow@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>


  Commit: 9a2ea4f4a7230fe224dee91d9adf2ef872c3d226
      
https://github.com/qemu/qemu/commit/9a2ea4f4a7230fe224dee91d9adf2ef872c3d226
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-10-30 (Fri, 30 Oct 2020)

  Changed paths:
    R Changelog
    M Makefile
    M README.rst
    M backends/cryptodev-builtin.c
    M backends/cryptodev-vhost-user.c
    M backends/cryptodev-vhost.c
    M backends/cryptodev.c
    M contrib/elf2dmp/main.c
    M include/hw/core/cpu.h
    M include/hw/qdev-core.h
    M include/io/channel-buffer.h
    M include/io/channel-command.h
    M include/io/channel-file.h
    M include/io/channel-socket.h
    M include/io/channel-tls.h
    M include/io/channel-util.h
    M include/io/channel-watch.h
    M include/io/channel-websock.h
    M include/io/channel.h
    M include/io/dns-resolver.h
    M include/io/task.h
    M include/sysemu/cryptodev-vhost-user.h
    M include/sysemu/cryptodev-vhost.h
    M include/sysemu/cryptodev.h
    M io/channel-buffer.c
    M io/channel-command.c
    M io/channel-file.c
    M io/channel-socket.c
    M io/channel-tls.c
    M io/channel-util.c
    M io/channel-watch.c
    M io/channel-websock.c
    M io/channel.c
    M io/dns-resolver.c
    M io/task.c
    M tests/test-io-channel-buffer.c
    M tests/test-io-channel-command.c
    M tests/test-io-channel-file.c
    M tests/test-io-channel-socket.c
    M tests/test-io-task.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/vivier2/tags/trivial-branch-for-5.2-pull-request' into staging

Pull request trivial branch 20201027

# gpg: Signature made Tue 27 Oct 2020 16:29:47 GMT
# gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
# gpg:                issuer "laurent@vivier.eu"
# gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
# gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
# gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" 
[full]
# Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C

* remotes/vivier2/tags/trivial-branch-for-5.2-pull-request:
  CHANGELOG: remove disused file
  qdev: Fix two typos
  scripts/qmp: delete 'qmp' script
  cryptodev: Fix Lesser GPL version number
  io: Fix Lesser GPL version number
  cpus: Drop declaration of cpu_remove()
  Makefile: Add *.[ch].inc files to cscope/ctags/TAGS
  elf2dmp: Fix memory leak on main() error paths

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/c99fa56b95a7...9a2ea4f4a723