[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 045b1d: xen: rework pci_piix3_xen_ide_unplug

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 045b1d: xen: rework pci_piix3_xen_ide_unplug
Date: Mon, 02 Nov 2020 09:17:24 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 045b1d4dbb44da67f1f86efa75b02843c0e951ef
  Author: Anthony PERARD <anthony.perard@citrix.com>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M hw/ide/piix.c

  Log Message:
  xen: rework pci_piix3_xen_ide_unplug

This is to allow IDE disks to be unplugged when adding to QEMU via:
    -drive file=/root/disk_file,if=none,id=ide-disk0,format=raw
    -device ide-hd,drive=ide-disk0,bus=ide.0,unit=0

as the current code only works for disk added with:
    -drive file=/root/disk_file,if=ide,index=0,media=disk,format=raw

Since the code already have the IDE controller as `dev`, we don't need
to use the legacy DriveInfo to find all the drive we want to unplug.
We can simply use `blk` from the controller, as it kind of was already
assume to be the same, by setting it to NULL.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: John Snow <jsnow@redhat.com>
Reviewed-by: Paul Durrant <paul@xen.org>
Message-Id: <20201027154058.495112-1-anthony.perard@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

  Commit: b139d11ae198aba0e009daddf7a3370ce84b2d09
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-11-02 (Mon, 02 Nov 2020)

  Changed paths:
    M hw/ide/piix.c

  Log Message:
  Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20201102' into 

xen patch

- Rework Xen disk unplug to work with newer command line

# gpg: Signature made Mon 02 Nov 2020 14:42:37 GMT
# gpg:                using RSA key F80C006308E22CFD8A92E7980CF5572FD7FB55AF
# gpg:                issuer "anthony.perard@citrix.com"
# gpg: Good signature from "Anthony PERARD <anthony.perard@gmail.com>" 
# gpg:                 aka "Anthony PERARD <anthony.perard@citrix.com>" 
# gpg: WARNING: This key is not certified with sufficiently trusted signatures!
# gpg:          It is not certain that the signature belongs to the owner.
# Primary key fingerprint: 5379 2F71 024C 600F 778A  7161 D8D5 7199 DF83 42C8
#      Subkey fingerprint: F80C 0063 08E2 2CFD 8A92  E798 0CF5 572F D7FB 55AF

* remotes/aperard/tags/pull-xen-20201102:
  xen: rework pci_piix3_xen_ide_unplug

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Compare: https://github.com/qemu/qemu/compare/b149dea55cce...b139d11ae198

reply via email to

[Prev in Thread] Current Thread [Next in Thread]