[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] c0b21f: nbd: Silence Coverity false positive

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] c0b21f: nbd: Silence Coverity false positive
Date: Tue, 17 Nov 2020 04:11:18 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c0b21f2e221e5edafb400e8acfa04db3ad5bf956
  Author: Eric Blake <eblake@redhat.com>
  Date:   2020-11-16 (Mon, 16 Nov 2020)

  Changed paths:
    M nbd/server.c

  Log Message:
  nbd: Silence Coverity false positive

Coverity noticed (CID 1436125) that we check the return value of
nbd_extent_array_add in most places, but not at the end of
bitmap_to_extents().  The return value exists to break loops before a
future iteration, so there is nothing to check if we are already done
iterating.  Adding a cast to void, plus a comment why, pacifies

Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20201111163510.713855-1-eblake@redhat.com>
[eblake: Prefer cast to void over odd && usage]
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

  Commit: 2f3c1fd39668b9e565a4e0ba1d62ff5db05d62a5
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2020-11-16 (Mon, 16 Nov 2020)

  Changed paths:
    M tests/qemu-iotests/nbd-fault-injector.py

  Log Message:
  iotests: Replace deprecated ConfigParser.readfp()

iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning
changes the output:

    nbd-fault-injector.py:230: DeprecationWarning: This method will be
    removed in future versions.  Use 'parser.read_file()' instead.

In fact, readfp() has already been deprecated in Python 3.2 and the
replacement has existed since the same version, so we can now
unconditionally switch to read_file().

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20201113100602.15936-1-kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>

  Commit: 48aa8f0ac536db3550a35c295ff7de94e4c33739
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2020-11-17 (Tue, 17 Nov 2020)

  Changed paths:
    M nbd/server.c
    M tests/qemu-iotests/nbd-fault-injector.py

  Log Message:
  Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2020-11-16' into 

nbd patches for 2020-11-16

- silence Coverity false positive
- modernize iotests python code related to nbd

# gpg: Signature made Mon 16 Nov 2020 20:58:13 GMT
# gpg:                using RSA key 71C2CC22B1C4602927D2F3AAA7A16B4A2527436A
# gpg: Good signature from "Eric Blake <eblake@redhat.com>" [full]
# gpg:                 aka "Eric Blake (Free Software Programmer) 
<ebb9@byu.net>" [full]
# gpg:                 aka "[jpeg image of size 6874]" [full]
# Primary key fingerprint: 71C2 CC22 B1C4 6029 27D2  F3AA A7A1 6B4A 2527 436A

* remotes/ericb/tags/pull-nbd-2020-11-16:
  iotests: Replace deprecated ConfigParser.readfp()
  nbd: Silence Coverity false positive

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Compare: https://github.com/qemu/qemu/compare/bce36c6c5436...48aa8f0ac536

reply via email to

[Prev in Thread] Current Thread [Next in Thread]