[Qemu-commits] [qemu/qemu] e08ff6: MAINTAINERS: Add Vladimir as co-maintainer for Blo...

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: e08ff6d9f73f8ff4912a20214bc1697b31ad7b21
      
https://github.com/qemu/qemu/commit/e08ff6d9f73f8ff4912a20214bc1697b31ad7b21
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add Vladimir as co-maintainer for Block Jobs

I'm developing Qemu backup for several years, and finally new backup
architecture, including block-copy generic engine and backup-top filter
landed upstream, great thanks to reviewers and especially to
Max Reitz!

I also have plans of moving other block-jobs onto block-copy, so that
we finally have one generic block copying path, fast and well-formed.

So, now I suggest to bring all parts of backup architecture into
"Block Jobs" subsystem (actually, aio_task is shared with qcow2 and
qemu-co-shared-resource can be reused somewhere else, but I'd keep an
eye on them in context of block-jobs) and add myself as co-maintainer.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210128144144.27617-1-vsementsov@virtuozzo.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 40f5f7b959d6f750fb6063fe102a2f95eb386a9d
      
https://github.com/qemu/qemu/commit/40f5f7b959d6f750fb6063fe102a2f95eb386a9d
  Author: Sergio Lopez <slp@redhat.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M block.c

  Log Message:
  -----------
  block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()

Some graphs may contain an indirect reference to the first BDS in the
chain that can be reached while walking it bottom->up from one its
children.

Doubling-processing of a BDS is especially problematic for the
aio_notifiers, as they might attempt to work on both the old and the
new AIO contexts.

To avoid this problem, add every child and parent to the ignore list
before actually processing them.

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Sergio Lopez <slp@redhat.com>
Message-Id: <20210201125032.44713-2-slp@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 98fb5f2e08b295544f295946b340b5cae0010c2c
      
https://github.com/qemu/qemu/commit/98fb5f2e08b295544f295946b340b5cae0010c2c
  Author: Sergio Lopez <slp@redhat.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M block.c
    M qemu-nbd.c
    M softmmu/runstate.c
    M storage-daemon/qemu-storage-daemon.c

  Log Message:
  -----------
  block: move blk_exp_close_all() to qemu_cleanup()

Move blk_exp_close_all() from bdrv_close() to qemu_cleanup(), before
bdrv_drain_all_begin().

Export drivers may have coroutines yielding at some point in the block
layer, so we need to shut them down before draining the block layer,
as otherwise they may get stuck blk_wait_while_drained().

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1900505
Signed-off-by: Sergio Lopez <slp@redhat.com>
Message-Id: <20210201125032.44713-3-slp@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 940a4bc05c100b4c498eaa46ebf3683293b4e215
      
https://github.com/qemu/qemu/commit/940a4bc05c100b4c498eaa46ebf3683293b4e215
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M tests/qemu-iotests/pylintrc

  Log Message:
  -----------
  iotests/297: pylint: ignore too many statements

Ignore two complains, which now lead to 297 failure on testenv.py and
testrunner.py.

Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210129161323.615027-1-vsementsov@virtuozzo.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 8026091435ab9186dec53973f0660dd4836de915
      
https://github.com/qemu/qemu/commit/8026091435ab9186dec53973f0660dd4836de915
  Author: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M tests/qemu-iotests/check
    M tests/qemu-iotests/testrunner.py

  Log Message:
  -----------
  iotests: check: return 1 on failure

We should indicate failure by exit code, not only output.

Reported-by: Peter Maydell
Fixes: f203080bbd9f9e5b31041b1f2afcd6040c5aaec5
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20210201085041.3079-1-vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: 47c9af7f4c78d03986aecc9afb0aab9b19d77cb5
      
https://github.com/qemu/qemu/commit/47c9af7f4c78d03986aecc9afb0aab9b19d77cb5
  Author: Kevin Wolf <kwolf@redhat.com>
  Date:   2021-02-01 (Mon, 01 Feb 2021)

  Changed paths:
    M tests/qemu-iotests/testrunner.py

  Log Message:
  -----------
  iotests: Fix -makecheck output

For -makecheck, the old 'check' implementation skipped the output when
starting a test. It only had the condensed output at the end of a test.

testrunner.py prints the normal output when starting a test even for
-makecheck. This output contains '\r' at the end so that it can be
overwritten with the result at the end of the test. However, for
-makecheck this is shorter output in a different format, so effectively
we end up with garbled output that mixes both output forms.

Revert to the old behaviour of only printing a message after the test
had completed in -makecheck mode.

Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20210201161024.127921-1-kwolf@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>


  Commit: a108ee9ad4e28c0c8b3d92f1ad50b0c630addf3a
      
https://github.com/qemu/qemu/commit/a108ee9ad4e28c0c8b3d92f1ad50b0c630addf3a
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2021-02-02 (Tue, 02 Feb 2021)

  Changed paths:
    M MAINTAINERS
    M block.c
    M qemu-nbd.c
    M softmmu/runstate.c
    M storage-daemon/qemu-storage-daemon.c
    M tests/qemu-iotests/check
    M tests/qemu-iotests/pylintrc
    M tests/qemu-iotests/testrunner.py

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging

Block layer patches:

- Fix double processing of nodes in bdrv_set_aio_context()
- Fix potential hang in block export shutdown
- iotests: Some more fixups for the 'check' rewrite
- MAINTAINERS: Add Vladimir as co-maintainer for Block Jobs

# gpg: Signature made Mon 01 Feb 2021 18:59:37 GMT
# gpg:                using RSA key DC3DEB159A9AF95D3D7456FE7F09B272C88F2FD6
# gpg:                issuer "kwolf@redhat.com"
# gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>" [full]
# Primary key fingerprint: DC3D EB15 9A9A F95D 3D74  56FE 7F09 B272 C88F 2FD6

* remotes/kevin/tags/for-upstream:
  iotests: Fix -makecheck output
  iotests: check: return 1 on failure
  iotests/297: pylint: ignore too many statements
  block: move blk_exp_close_all() to qemu_cleanup()
  block: Avoid processing BDS twice in bdrv_set_aio_context_ignore()
  MAINTAINERS: Add Vladimir as co-maintainer for Block Jobs

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/cf7ca7d5b9fa...a108ee9ad4e2