[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5351fb: hw/block/nvme: fix invalid msix exclu

From: Klaus Jensen
Subject: [Qemu-commits] [qemu/qemu] 5351fb: hw/block/nvme: fix invalid msix exclusive uninit
Date: Mon, 26 Apr 2021 08:25:23 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5351fb7cb2caf81bccbfd5ee4228106cadc56e3c
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2021-04-26 (Mon, 26 Apr 2021)

  Changed paths:
    M hw/block/nvme.c

  Log Message:
  hw/block/nvme: fix invalid msix exclusive uninit

Commit 1901b4967c3f changed the nvme device from using a bar exclusive
for MSI-x to sharing it on bar0.

Unfortunately, the msix_uninit_exclusive_bar() call remains in
nvme_exit() which causes havoc when the device is removed with, say,
device_del. Fix this.

Additionally, a subregion is added but it is not removed on exit which
causes a reference to linger and the drive to never be unlocked.

Fixes: 1901b4967c3f ("hw/block/nvme: move msix table and pba to BAR 0")
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]