qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 9bca15: 9p: linux: Fix a couple Linux assumpt


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 9bca15: 9p: linux: Fix a couple Linux assumptions
Date: Fri, 04 Mar 2022 08:53:17 -0800

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 9bca156323feb554c2eb54aa3888a4445666437b
      
https://github.com/qemu/qemu/commit/9bca156323feb554c2eb54aa3888a4445666437b
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M fsdev/file-op-9p.h
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p.c
    M include/qemu/xattr.h

  Log Message:
  -----------
  9p: linux: Fix a couple Linux assumptions

 - Guard Linux only headers.
 - Add qemu/statfs.h header to abstract over the which
   headers are needed for struct statfs
 - Define `ENOATTR` only if not only defined
   (it's defined in system headers on Darwin).

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>

While it might at first appear that fsdev/virtfs-proxy-header.c would
need similar adjustment for darwin as file-op-9p here, a later patch in
this series disables virtfs-proxy-helper for non-Linux. Allowing
virtfs-proxy-helper on darwin could potentially be an additional
optimization later.

[Will Cohen: - Fix headers for Alpine
             - Integrate statfs.h back into file-op-9p.h
             - Remove superfluous header guards from file-opt-9p
             - Add note about virtfs-proxy-helper being disabled
               on non-Linux for this patch series]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220227223522.91937-2-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 29241fc0ad2cf5c45ee005befc8d3bad04a79914
      
https://github.com/qemu/qemu/commit/29241fc0ad2cf5c45ee005befc8d3bad04a79914
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    A hw/9pfs/9p-util-linux.c
    R hw/9pfs/9p-util.c
    M hw/9pfs/meson.build

  Log Message:
  -----------
  9p: Rename 9p-util -> 9p-util-linux

The current file only has the Linux versions of these functions.
Rename the file accordingly and update the Makefile to only build
it on Linux. A Darwin version of these will follow later in the
series.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20220227223522.91937-3-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: f0cd1d0069f92bfced8b0d8002da6093850c4ebc
      
https://github.com/qemu/qemu/commit/f0cd1d0069f92bfced8b0d8002da6093850c4ebc
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    M hw/9pfs/9p.c

  Log Message:
  -----------
  9p: darwin: Handle struct stat(fs) differences

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Note lack of f_namelen and f_frsize on Darwin
             - Ensure that tv_sec and tv_nsec are both
               initialized for Darwin and non-Darwin]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-4-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: cff1ca391fd7c6af90edb8f237f15a756eaffafe
      
https://github.com/qemu/qemu/commit/cff1ca391fd7c6af90edb8f237f15a756eaffafe
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    M hw/9pfs/9p-util.h
    M hw/9pfs/9p.c
    M hw/9pfs/codir.c

  Log Message:
  -----------
  9p: darwin: Handle struct dirent differences

On darwin d_seekoff exists, but is optional and does not seem to
be commonly used by file systems. Use `telldir` instead to obtain
the seek offset and inject it into d_seekoff, and create a
qemu_dirent_off helper to call it appropriately when appropriate.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Adjust to pass testing
             - Ensure that d_seekoff is filled using telldir
               on darwin, and create qemu_dirent_off helper
               to decide which to access]
[Fabian Franz: - Add telldir error handling for darwin]
Signed-off-by: Fabian Franz <fabianfranz.oss@gmail.com>
[Will Cohen: - Ensure that telldir error handling uses
               signed int
             - Cleanup of telldir error handling
             - Remove superfluous error handling for
               qemu_dirent_off
             - Adjust formatting
             - Use qemu_dirent_off in codir.c
             - Declare qemu_dirent_off as static to prevent
               linker error
             - Move qemu_dirent_off above the end-of-file
               endif to fix compilation]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-5-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 8744e9fc25ac8cc29c97ba3ee48050add2ba6b57
      
https://github.com/qemu/qemu/commit/8744e9fc25ac8cc29c97ba3ee48050add2ba6b57
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h
    M hw/9pfs/9p.c

  Log Message:
  -----------
  9p: darwin: Ignore O_{NOATIME, DIRECT}

Darwin doesn't have either of these flags. Darwin does have
F_NOCACHE, which is similar to O_DIRECT, but has different
enough semantics that other projects don't generally map
them automatically. In any case, we don't support O_DIRECT
on Linux at the moment either.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-6-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 6053caf8bf8aa5544b14ec55d9b1518187b909df
      
https://github.com/qemu/qemu/commit/6053caf8bf8aa5544b14ec55d9b1518187b909df
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p.c
    M hw/9pfs/9p.h

  Log Message:
  -----------
  9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>

Because XATTR_SIZE_MAX is not defined on Darwin,
create a cross-platform P9_XATTR_SIZE_MAX instead.

[Will Cohen: - Adjust coding style
             - Lower XATTR_SIZE_MAX to 64k
             - Add explanatory context related to XATTR_SIZE_MAX]
[Fabian Franz: - Move XATTR_SIZE_MAX reference from 9p.c to
                 P9_XATTR_SIZE_MAX in 9p.h]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Signed-off-by: Fabian Franz <fabianfranz.oss@gmail.com>
[Will Cohen: - For P9_XATTR_MAX, ensure that Linux uses
               XATTR_SIZE_MAX, Darwin uses 64k, and error
               out for undefined hosts]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-7-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: dcc0a6e2f98cecaa420e89b376bb685a80466d06
      
https://github.com/qemu/qemu/commit/dcc0a6e2f98cecaa420e89b376bb685a80466d06
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    A hw/9pfs/9p-util-darwin.c
    M hw/9pfs/meson.build

  Log Message:
  -----------
  9p: darwin: *xattr_nofollow implementations

This implements the darwin equivalent of the functions that were
moved to 9p-util(-linux) earlier in this series in the new
9p-util-darwin file.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-8-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 41e44bc8e4e96608f89fdeca6e62f0b10261e731
      
https://github.com/qemu/qemu/commit/41e44bc8e4e96608f89fdeca6e62f0b10261e731
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  9p: darwin: Compatibility for f/l*xattr

On darwin `fgetxattr` takes two extra optional arguments,
and the l* variants are not defined (in favor of an extra
flag to the regular variants.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-9-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 24187e2b6419dbcb60f57ad204d3afdd0ac1b3a5
      
https://github.com/qemu/qemu/commit/24187e2b6419dbcb60f57ad204d3afdd0ac1b3a5
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-util-darwin.c
    M hw/9pfs/9p-util-linux.c
    M hw/9pfs/9p-util.h
    M meson.build

  Log Message:
  -----------
  9p: darwin: Implement compatibility for mknodat

Darwin does not support mknodat. However, to avoid race conditions
with later setting the permissions, we must avoid using mknod on
the full path instead. We could try to fchdir, but that would cause
problems if multiple threads try to call mknodat at the same time.
However, luckily there is a solution: Darwin includes a function
that sets the cwd for the current thread only.
This should suffice to use mknod safely.

This function (pthread_fchdir_np) is protected by a check in
meson in a patch later in this series.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Adjust coding style
             - Replace clang references with gcc
             - Note radar filed with Apple for missing syscall
             - Replace direct syscall with pthread_fchdir_np and
               adjust patch notes accordingly
             - Declare pthread_fchdir_np with
             - __attribute__((weak_import)) to allow checking for
               its presence before usage
             - Move declarations above cplusplus guard
             - Add CONFIG_PTHREAD_FCHDIR_NP to meson and check for
               presence in 9p-util
             - Rebase to apply cleanly on top of the 2022-02-10
               changes to 9pfs
             - Fix line over 90 characters formatting error]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-10-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 71f51f31342fa9b3eb53ff267345ee9d59d0cebf
      
https://github.com/qemu/qemu/commit/71f51f31342fa9b3eb53ff267345ee9d59d0cebf
  Author: Will Cohen <wwcohen@gmail.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M tests/qtest/virtio-9p-test.c

  Log Message:
  -----------
  9p: darwin: Adjust assumption on virtio-9p-test

The previous test depended on the assumption that P9_DOTL_AT_REMOVEDIR
and AT_REMOVEDIR have the same value.

While this is true on Linux, it is not true everywhere, and leads to an
incorrect test failure on unlink_at, noticed when adding 9p to darwin:

Received response 7 (RLERROR) instead of 77 (RUNLINKAT)
Rlerror has errno 22 (Invalid argument)
**

ERROR:../tests/qtest/virtio-9p-test.c:305:v9fs_req_recv: assertion
failed (hdr.id == id): (7 == 77) Bail out!

ERROR:../tests/qtest/virtio-9p-test.c:305:v9fs_req_recv: assertion
failed (hdr.id == id): (7 == 77)

Signed-off-by: Fabian Franz <fabianfranz.oss@gmail.com>
[Will Cohen: - Add explanation of patch and description
               of pre-patch test failure]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Acked-by: Thomas Huth <thuth@redhat.com>
[Will Cohen: - Move this patch before 9p: darwin: meson
               patch to avoid qtest breakage during
               bisecting]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20220227223522.91937-11-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: c798533fa748f8c8006ef3372905da6ba99da2fd
      
https://github.com/qemu/qemu/commit/c798533fa748f8c8006ef3372905da6ba99da2fd
  Author: Keno Fischer <keno@juliacomputing.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M fsdev/meson.build
    M meson.build

  Log Message:
  -----------
  9p: darwin: meson: Allow VirtFS on Darwin

To allow VirtFS on darwin, we need to check that pthread_fchdir_np is
available, which has only been available since macOS 10.12.

Additionally, virtfs_proxy_helper is disabled on Darwin. This patch
series does not currently provide an implementation of the proxy-helper,
but this functionality could be implemented later on.

Signed-off-by: Keno Fischer <keno@juliacomputing.com>
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
[Will Cohen: - Rebase to master]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
[Will Cohen: - Add check for pthread_fchdir_np to virtfs
             - Add comments to patch commit
             - Note that virtfs_proxy_helper does not work
               on macOS
             - Fully adjust meson virtfs error note to specify
               macOS
             - Rebase to master]
Signed-off-by: Will Cohen <wwcohen@gmail.com>
Message-Id: <20220227223522.91937-12-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>


  Commit: 4115c7e2bf14bb1a44914ed3fd35a49acb9d270d
      
https://github.com/qemu/qemu/commit/4115c7e2bf14bb1a44914ed3fd35a49acb9d270d
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h
    M include/qemu/osdep.h
    M util/osdep.c

  Log Message:
  -----------
  9pfs: move qemu_dirent_dup() from osdep -> 9p-util

Function qemu_dirent_dup() is currently only used by 9pfs server, so move
it from project global header osdep.h to 9pfs specific header 9p-util.h.

Link: 
https://lore.kernel.org/qemu-devel/CAFEAcA_=HAUNomKD2wurSVaAHa5mrk22A1oHKLWUDjk7v6Khmg@mail.gmail.com/
Based-on: <20220227223522.91937-12-wwcohen@gmail.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <E1nP9Oz-00043L-KJ@lizzy.crudebyte.com>


  Commit: 878a1c85e3d1345bff4df30a5158a94db0d29587
      
https://github.com/qemu/qemu/commit/878a1c85e3d1345bff4df30a5158a94db0d29587
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  9pfs: drop Doxygen format from qemu_dirent_dup() API comment

API doc comments in QEMU are supposed to be in kerneldoc format, so drop
occurrences of "@c" which is Doxygen format for fixed-width text.

Link: 
https://lore.kernel.org/qemu-devel/CAFEAcA89+ENOM6x19OEF53Kd2DWkhN5SN21Va0D7yepJSa3Jyg@mail.gmail.com/
Based-on: <E1nP9Oz-00043L-KJ@lizzy.crudebyte.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <E1nPTwO-0006pl-Np@lizzy.crudebyte.com>


  Commit: c2ae4952afd4f0bab98cd6e2803b5190804f52ad
      
https://github.com/qemu/qemu/commit/c2ae4952afd4f0bab98cd6e2803b5190804f52ad
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p.h

  Log Message:
  -----------
  9pfs/9p.h: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Based-on: <E1nPTwO-0006pl-Np@lizzy.crudebyte.com>
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<2b8f91de7bac3d3bc85d60eb08830a35a394be75.1646314856.git.qemu_oss@crudebyte.com>


  Commit: cee3e110958141446de1fbd5074fb03f0492c878
      
https://github.com/qemu/qemu/commit/cee3e110958141446de1fbd5074fb03f0492c878
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/codir.c

  Log Message:
  -----------
  9pfs/codir.c: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<c76be7d38ea448c6417b2ffb5ccd6b711519a878.1646314856.git.qemu_oss@crudebyte.com>


  Commit: a0df9b2f440c068979769762fdd5a853156fcccb
      
https://github.com/qemu/qemu/commit/a0df9b2f440c068979769762fdd5a853156fcccb
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p.c

  Log Message:
  -----------
  9pfs/9p.c: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<4ece6ffa4465c271c6a7c42a3040f42780fcce87.1646314856.git.qemu_oss@crudebyte.com>


  Commit: c626a3151a004689918ab65a5ecdeea06755580c
      
https://github.com/qemu/qemu/commit/c626a3151a004689918ab65a5ecdeea06755580c
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/9p-util.h

  Log Message:
  -----------
  9pfs/9p-util.h: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<dc1c4a85e233f5884ee5f6ec96b87db286083df7.1646314856.git.qemu_oss@crudebyte.com>


  Commit: cb7d8fe9910c24655ac043065031cc8e4fe84720
      
https://github.com/qemu/qemu/commit/cb7d8fe9910c24655ac043065031cc8e4fe84720
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M hw/9pfs/coth.h

  Log Message:
  -----------
  9pfs/coth.h: drop Doxygen format on v9fs_co_run_in_worker()

API doc comments in QEMU are supposed to be in kerneldoc format, so
drop Doxygen format used on v9fs_co_run_in_worker() macro.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<a8fdf0290d1e40a68f5577f29aeae12298b70733.1646314856.git.qemu_oss@crudebyte.com>


  Commit: 39edfe337c418995b2932a9a14a612fb0c329dc5
      
https://github.com/qemu/qemu/commit/39edfe337c418995b2932a9a14a612fb0c329dc5
  Author: Christian Schoenebeck <qemu_oss@crudebyte.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M fsdev/p9array.h

  Log Message:
  -----------
  fsdev/p9array.h: convert Doxygen -> kerneldoc format

API doc comments in QEMU are supposed to be in kerneldoc format, so
convert API doc comments from Doxygen format to kerneldoc format.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: 
<2e2d46a402560f155de322d95789ba107d728885.1646314856.git.qemu_oss@crudebyte.com>


  Commit: 8dba67dce3c2d8c6f72ed76941811f3a22589c25
      
https://github.com/qemu/qemu/commit/8dba67dce3c2d8c6f72ed76941811f3a22589c25
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M fsdev/file-op-9p.h
    M fsdev/meson.build
    M fsdev/p9array.h
    M hw/9pfs/9p-local.c
    M hw/9pfs/9p-proxy.c
    M hw/9pfs/9p-synth.c
    A hw/9pfs/9p-util-darwin.c
    A hw/9pfs/9p-util-linux.c
    R hw/9pfs/9p-util.c
    M hw/9pfs/9p-util.h
    M hw/9pfs/9p.c
    M hw/9pfs/9p.h
    M hw/9pfs/codir.c
    M hw/9pfs/coth.h
    M hw/9pfs/meson.build
    M include/qemu/osdep.h
    M include/qemu/xattr.h
    M meson.build
    M tests/qtest/virtio-9p-test.c
    M util/osdep.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20220304' 
into staging

9pfs: introduce macOS host support and cleanup

* Add support for Darwin (a.k.a. macOS) hosts.

* Code cleanup (move qemu_dirent_dup() from osdep -> 9p-util).

* API doc cleanup (convert Doxygen -> kerneldoc format).

# gpg: Signature made Fri 04 Mar 2022 12:27:32 GMT
# gpg:                using RSA key 96D8D110CF7AF8084F88590134C2B58765A47395
# gpg:                issuer "qemu_oss@crudebyte.com"
# gpg: Good signature from "Christian Schoenebeck <qemu_oss@crudebyte.com>" 
[unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: ECAB 1A45 4014 1413 BA38  4926 30DB 47C3 A012 D5F4
#      Subkey fingerprint: 96D8 D110 CF7A F808 4F88  5901 34C2 B587 65A4 7395

* remotes/cschoenebeck/tags/pull-9p-20220304:
  fsdev/p9array.h: convert Doxygen -> kerneldoc format
  9pfs/coth.h: drop Doxygen format on v9fs_co_run_in_worker()
  9pfs/9p-util.h: convert Doxygen -> kerneldoc format
  9pfs/9p.c: convert Doxygen -> kerneldoc format
  9pfs/codir.c: convert Doxygen -> kerneldoc format
  9pfs/9p.h: convert Doxygen -> kerneldoc format
  9pfs: drop Doxygen format from qemu_dirent_dup() API comment
  9pfs: move qemu_dirent_dup() from osdep -> 9p-util
  9p: darwin: meson: Allow VirtFS on Darwin
  9p: darwin: Adjust assumption on virtio-9p-test
  9p: darwin: Implement compatibility for mknodat
  9p: darwin: Compatibility for f/l*xattr
  9p: darwin: *xattr_nofollow implementations
  9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX
  9p: darwin: Ignore O_{NOATIME, DIRECT}
  9p: darwin: Handle struct dirent differences
  9p: darwin: Handle struct stat(fs) differences
  9p: Rename 9p-util -> 9p-util-linux
  9p: linux: Fix a couple Linux assumptions

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/3d1fbc59665f...8dba67dce3c2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]