[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] ed021d: hw/ppc: sam460ex.c: store all GPIO li

From: Richard Henderson
Subject: [Qemu-commits] [qemu/qemu] ed021d: hw/ppc: sam460ex.c: store all GPIO lines in mal_ir...
Date: Thu, 04 Aug 2022 11:48:34 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: ed021daf2d6c19499ae406055156dc19c073228f
  Author: Daniel Henrique Barboza <danielhb413@gmail.com>
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
    M hw/ppc/sam460ex.c

  Log Message:
  hw/ppc: sam460ex.c: store all GPIO lines in mal_irqs[]

We're not storing all GPIO lines we're retrieving with
qdev_get_gpio_in() in mal_irqs[]. We're storing just the last one in the
first index:

    for (i = 0; i < ARRAY_SIZE(mal_irqs); i++) {
        mal_irqs[0] = qdev_get_gpio_in(uic[2], 3 + i);
    ppc4xx_mal_init(env, 4, 16, mal_irqs);

mal_irqs is used in ppc4xx_mal_init() to assign the IRQs to MAL:

    for (i = 0; i < 4; i++) {
        mal->irqs[i] = irqs[i];

Since only irqs[0] has been initialized, mal->irqs[1,2,3] are being

This doesn´t seem to trigger any apparent issues at this moment, but
Cedric's QOMification of the MAL device [1] is executing a
sysbus_connect_irq() that will fail if we do not store all GPIO lines

[1] https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg00497.html

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: BALATON Zoltan <balaton@eik.bme.hu>
Fixes: 706e944206d7 ("hw/ppc/sam460ex: Drop use of ppcuic_init()")
Acked-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20220803233204.2724202-1-danielhb413@gmail.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>

  Commit: 0ee33dd0cee1f9a239d561f1a91e6ea493d1f5a9
  Author: Richard Henderson <richard.henderson@linaro.org>
  Date:   2022-08-04 (Thu, 04 Aug 2022)

  Changed paths:
    M hw/ppc/sam460ex.c

  Log Message:
  Merge tag 'pull-ppc-20220804' of https://gitlab.com/danielhb/qemu into staging

ppc patch queue for 2022-08-04:

In this short queue we have a fix in the sam460ex machine where we're
not storing all GPIO lines in sam460ex_init().

This is not causing problems (as far as we're aware of) at this moment,
but this is getting in the way of a ppc405 rework we want to do for 7.2,
so let's fix it now.

# ZN+NAQDDOk4b79khltmrslo4Sa16nu/ARgqMGOsyy0Y5Whs9MgEAyiAVhpQ6C7Ok
# W2sHeUkv/ZvzWvE7LWXMPZehBgU9DgM=
# =QrsF
# gpg: Signature made Thu 04 Aug 2022 11:21:21 AM PDT
# gpg:                using EDDSA key 17EBFF9923D01800AF2838193CD9CA96DE033164
# gpg: Good signature from "Daniel Henrique Barboza <danielhb413@gmail.com>" 
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 17EB FF99 23D0 1800 AF28  3819 3CD9 CA96 DE03 3164

* tag 'pull-ppc-20220804' of https://gitlab.com/danielhb/qemu:
  hw/ppc: sam460ex.c: store all GPIO lines in mal_irqs[]

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Compare: https://github.com/qemu/qemu/compare/2480f3bbd038...0ee33dd0cee1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]