[Qemu-commits] [qemu/qemu] 48b32c: hw/nvme: use QOM accessors

[Peter Maydell]

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 48b32c28d5883cce8485a95981e070f9bb203a3d
      
https://github.com/qemu/qemu/commit/48b32c28d5883cce8485a95981e070f9bb203a3d
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: use QOM accessors

Replace various ->parent_obj use with the equivalent QOM accessors.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 47cd3539e167d641ef8273a0c435cf0ca24c8384
      
https://github.com/qemu/qemu/commit/47cd3539e167d641ef8273a0c435cf0ca24c8384
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M hw/nvme/ctrl.c
    M hw/nvme/trace-events

  Log Message:
  -----------
  hw/nvme: rename shadow doorbell related trace events

Rename the trace events related to writing the event index and reading
the doorbell value to make it more clear that the event is associated
with an actual update (write or read respectively).

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 2fda0726e5149e032acfa5fe442db56cd6433c4c
      
https://github.com/qemu/qemu/commit/2fda0726e5149e032acfa5fe442db56cd6433c4c
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: fix missing endian conversions for doorbell buffers

The eventidx and doorbell value are not handling endianness correctly.
Fix this.

Fixes: 3f7fe8de3d49 ("hw/nvme: Implement shadow doorbell buffer support")
Cc: qemu-stable@nongnu.org
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: fa5db2aa168bdc0f15c269b6212ef47632fab8ba
      
https://github.com/qemu/qemu/commit/fa5db2aa168bdc0f15c269b6212ef47632fab8ba
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-01-09 (Mon, 09 Jan 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: fix missing cq eventidx update

Prior to reading the shadow doorbell cq head, we have to update the
eventidx. Otherwise, we risk that the driver will skip an mmio doorbell
write. This happens on riscv64, as reported by Guenter.

Adding the missing update to the cq eventidx fixes the issue.

Fixes: 3f7fe8de3d49 ("hw/nvme: Implement shadow doorbell buffer support")
Cc: qemu-stable@nongnu.org
Cc: qemu-riscv@nongnu.org
Reported-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 784fd35387e9e6b42e3f365ddf44263eb25de8f7
      
https://github.com/qemu/qemu/commit/784fd35387e9e6b42e3f365ddf44263eb25de8f7
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-01-11 (Wed, 11 Jan 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: clean up confusing use of errp/local_err

Remove an unnecessary local Error value in nvme_realize(). In the
process, change nvme_check_constraints() to return a bool.

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 973f76cf7743545a5d8a0a8bfdfe2cd02aa3e238
      
https://github.com/qemu/qemu/commit/973f76cf7743545a5d8a0a8bfdfe2cd02aa3e238
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2023-01-11 (Wed, 11 Jan 2023)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: cleanup error reporting in nvme_init_pci()

Replace the local Error variable with errp and ERRP_GUARD() and change
the return value to bool.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: a35fa426ee9d88a1d335e6681e4f936edb2f24ee
      
https://github.com/qemu/qemu/commit/a35fa426ee9d88a1d335e6681e4f936edb2f24ee
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-01-11 (Wed, 11 Jan 2023)

  Changed paths:
    M hw/nvme/ctrl.c
    M hw/nvme/trace-events

  Log Message:
  -----------
  Merge tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu into 
staging

hw/nvme updates

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmO+anUACgkQTeGvMW1P
# Del4HAf/eqW92bf04CpXPzLMG38+FoYQgwkH8Lp390JlSM6kjv3DgPM2ygJXIEYr
# dV0KQpTcPRGAVCuXCSOUd6FTkAYdcPVtOeJeYhldEYj9cc9Y/9tvcBMthFBkiCU/
# 66TL7JEgFmOfVMrLypYpfrPHCN0lQVX+i2+Qruospg6itubAKcYdJq+Hx2WWHzcC
# hl/qNgSSIGlhQi21ada1iCUC8Q3TZzo54M+0tW4zfybzsG+eNM+ouKDl/qOHtQgP
# ON/ef9dl+0Dum1l5z7O+sPiXBzZRJR7V+jZOsbf0A98fxqmuu3YacVrH6mY/Zmdx
# e1xexJt6PVXaIKtoZQKRVn2C0ITjXA==
# =AvaO
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 11 Jan 2023 07:51:17 GMT
# gpg:                using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9
# gpg: Good signature from "Klaus Jensen <its@irrelevant.dk>" [full]
# gpg:                 aka "Klaus Jensen <k.jensen@samsung.com>" [full]
# Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468  4272 63D5 6FC5 E55D A838
#      Subkey fingerprint: 5228 33AA 75E2 DCE6 A247  66C0 4DE1 AF31 6D4F 0DE9

* tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu:
  hw/nvme: cleanup error reporting in nvme_init_pci()
  hw/nvme: clean up confusing use of errp/local_err
  hw/nvme: fix missing cq eventidx update
  hw/nvme: fix missing endian conversions for doorbell buffers
  hw/nvme: rename shadow doorbell related trace events
  hw/nvme: use QOM accessors

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/cb8a043cd018...a35fa426ee9d