qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 038478: ui/dbus: initialize cursor_fb


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] 038478: ui/dbus: initialize cursor_fb
Date: Mon, 13 Mar 2023 05:34:16 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: 0384785d55a78b5fe037dbc3eb8338da2bd97e6a
      
https://github.com/qemu/qemu/commit/0384785d55a78b5fe037dbc3eb8338da2bd97e6a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M include/ui/egl-helpers.h
    M ui/dbus-listener.c

  Log Message:
  -----------
  ui/dbus: initialize cursor_fb

Or else, we may randomly destroy some textures..

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: 11c1eab5c721c683af506595386abe79dcbfbb64
      
https://github.com/qemu/qemu/commit/11c1eab5c721c683af506595386abe79dcbfbb64
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/dbus-clipboard.c

  Log Message:
  -----------
  ui/dbus: unregister clipboard on connection close

Fixes unregistration with p2p connections, since they don't have an
associated name owner.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 0d8a6857cef7351fa204d59fba8ee3038951d89a
      
https://github.com/qemu/qemu/commit/0d8a6857cef7351fa204d59fba8ee3038951d89a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M audio/audio_int.h
    M audio/dbusaudio.c
    M ui/dbus.c

  Log Message:
  -----------
  audio/dbus: there are no sender for p2p mode

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: ec499319b0125d1f7a3daaaecec10e454f93cf8a
      
https://github.com/qemu/qemu/commit/ec499319b0125d1f7a3daaaecec10e454f93cf8a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/dbus-console.c

  Log Message:
  -----------
  ui/dbus: set mouse is-absolute during console creation

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: f6c30b15cee6e1abeace215ab4be02e1e02d616d
      
https://github.com/qemu/qemu/commit/f6c30b15cee6e1abeace215ab4be02e1e02d616d
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/meson.build

  Log Message:
  -----------
  meson: ensure dbus-display generated code is built before other units

It's simply by luck that dbus-display header is built first before the
other units using it.

With sourceset, I can't find an easier way out than declaring an extra
dependency for dbus-display1 generate code.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 26de97ee3d5b997ce73e08c3233192968e7d0c00
      
https://github.com/qemu/qemu/commit/26de97ee3d5b997ce73e08c3233192968e7d0c00
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M hw/display/qxl-render.c
    M hw/display/qxl.c
    M hw/display/vmware_vga.c
    M include/ui/console.h
    M ui/cursor.c
    M ui/dbus-listener.c
    M ui/spice-display.c
    M ui/vnc.c

  Log Message:
  -----------
  ui: rename cursor_{put->unref}

The naming is more conventional in QEMU.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: bd4b2110b8ffac020725a55b9e6d79878a74f3f6
      
https://github.com/qemu/qemu/commit/bd4b2110b8ffac020725a55b9e6d79878a74f3f6
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M include/ui/console.h
    M ui/cursor.c
    M ui/dbus-listener.c
    M ui/spice-display.c
    M ui/vnc.c

  Log Message:
  -----------
  ui: rename cursor_{get->ref}, return it

The naming is more conventional in QEMU code, and allows to simplify
some code by changing the API design, so it returns the input parameter,
instead of void.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 6c40f45f3f20ec56c0e92fded9ffa2540ae3196b
      
https://github.com/qemu/qemu/commit/6c40f45f3f20ec56c0e92fded9ffa2540ae3196b
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M include/ui/console.h
    M ui/console.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  ui: keep current cursor with QemuConsole

Keeping the current cursor around is useful, not only for VNC, but for
other displays. Let's move it down, see the following patches for other
usages.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 8afbdde2ee7ebdf9616ab3f339169fef209640d8
      
https://github.com/qemu/qemu/commit/8afbdde2ee7ebdf9616ab3f339169fef209640d8
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  ui: set cursor upon listener registration

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 6b9a9cb017a3c1fcaa94d1cfcd12cebbd76b3df3
      
https://github.com/qemu/qemu/commit/6b9a9cb017a3c1fcaa94d1cfcd12cebbd76b3df3
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  ui: set cursor position upon listener registration

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 9844c0d008b8ab58c0515b896c7d7c6890e31cb5
      
https://github.com/qemu/qemu/commit/9844c0d008b8ab58c0515b896c7d7c6890e31cb5
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  ui/sdl: get the GL context from the window

There is no guarantee to have a current GL context here. The current
code seems to rely on the renderer using a GL backend, and to set a
current GL context. But this is not always the case, for example if the
renderer backend is DirectX.

This change is enough to fix using virgl with sdl2 on win32, on my setup.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 145cbac0fbc6e4d7389ff47f05bb014c423da114
      
https://github.com/qemu/qemu/commit/145cbac0fbc6e4d7389ff47f05bb014c423da114
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/shader/texture-blit-flip.vert
    M ui/shader/texture-blit.frag
    M ui/shader/texture-blit.vert

  Log Message:
  -----------
  ui/shader: fix #version directive must occur on first line

ANGLE fails to compile shaders otherwise.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 9764364eb553a3df083562bf926fd4795c037b0b
      
https://github.com/qemu/qemu/commit/9764364eb553a3df083562bf926fd4795c037b0b
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/egl-helpers.c

  Log Message:
  -----------
  ui/egl: print EGL error, helping debugging

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>


  Commit: c0a3db5b31498635102a9ccd79c5ea076beed626
      
https://github.com/qemu/qemu/commit/c0a3db5b31498635102a9ccd79c5ea076beed626
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment

Enable SDL logging when QEMU_ENABLE_SDL_LOGGING variable is set, as
suggested by Sam Lantinga, upstream SDL maintainer.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 9006dfcd510d16b76b6e4b31fcd2713ecb1cee0a
      
https://github.com/qemu/qemu/commit/9006dfcd510d16b76b6e4b31fcd2713ecb1cee0a
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/sdl2.c

  Log Message:
  -----------
  ui/sdl: try to instantiate the matching opengl renderer

-display sdl,gl=es didn't actually use OpenGL ES.

Using OpenGL ES allows to use ANGLE, which works generally better than
Windows/OEM OpenGL driver.

(note: users can still bypass the QEMU choice with SDL_RENDER_DRIVER
environment variable)

(note: for some reason, specifying a driver disables batching and
breaks rendering, so enable it explicitly)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 657730950d46ea8aba74996bc5d4b9fc162f2b12
      
https://github.com/qemu/qemu/commit/657730950d46ea8aba74996bc5d4b9fc162f2b12
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M include/ui/egl-helpers.h
    M ui/dbus.c
    M ui/egl-headless.c
    M ui/egl-helpers.c
    M ui/spice-core.c

  Log Message:
  -----------
  ui: introduce egl_init()

Future patches will introduce EGL support on win32 (too late for 8.0
though). Having a common place for EGL initialization and error handling
will make it simpler.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: f38fa6f377d04a089966e0e50a51dad7ede9b44c
      
https://github.com/qemu/qemu/commit/f38fa6f377d04a089966e0e50a51dad7ede9b44c
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M meson.build
    M tests/qtest/meson.build
    M ui/dbus-listener.c
    M ui/dbus.c
    M ui/meson.build

  Log Message:
  -----------
  ui/dbus: do not require opengl & gbm

Allow to build & use the DBus display without 3d/GPU acceleration support.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: 8af2d147cad9d150f977191ebef55f4ad6d01560
      
https://github.com/qemu/qemu/commit/8af2d147cad9d150f977191ebef55f4ad6d01560
  Author: Marc-André Lureau <marcandre.lureau@redhat.com>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M ui/dbus-listener.c
    M ui/dbus.c

  Log Message:
  -----------
  ui/dbus: restrict opengl to gbm-enabled config

We can enable EGL later for non-GBM hosts.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


  Commit: a515336a2cefac47259eaead2841276a30a5374f
      
https://github.com/qemu/qemu/commit/a515336a2cefac47259eaead2841276a30a5374f
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2023-03-13 (Mon, 13 Mar 2023)

  Changed paths:
    M audio/audio_int.h
    M audio/dbusaudio.c
    M hw/display/qxl-render.c
    M hw/display/qxl.c
    M hw/display/vmware_vga.c
    M include/ui/console.h
    M include/ui/egl-helpers.h
    M meson.build
    M tests/qtest/meson.build
    M ui/console.c
    M ui/cursor.c
    M ui/dbus-clipboard.c
    M ui/dbus-console.c
    M ui/dbus-listener.c
    M ui/dbus.c
    M ui/egl-headless.c
    M ui/egl-helpers.c
    M ui/meson.build
    M ui/sdl2.c
    M ui/shader/texture-blit-flip.vert
    M ui/shader/texture-blit.frag
    M ui/shader/texture-blit.vert
    M ui/spice-core.c
    M ui/spice-display.c
    M ui/vnc.c
    M ui/vnc.h

  Log Message:
  -----------
  Merge tag 'display-pull-request' of https://gitlab.com/marcandre.lureau/qemu 
into staging

ui: dbus & misc fixes

# -----BEGIN PGP SIGNATURE-----
#
# iQJQBAABCAA6FiEEh6m9kz+HxgbSdvYt2ujhCXWWnOUFAmQPAlIcHG1hcmNhbmRy
# ZS5sdXJlYXVAcmVkaGF0LmNvbQAKCRDa6OEJdZac5X0/D/48ZflIv/SgDsgEcWdK
# PsUpWjqHWombxU+0BfHD1f/LhNMZwAIs0R3kGV+TYXYJ2EAPCPAaq6SqbLqmT/Lt
# ud29tTPz0QqRBFkH+TI7SY3KSpbcXUZJi369dFGqzhch3lgyztOIYD+FbXt+neOV
# KatR7C22SMazgKJUdJ4+wpXmaG4nrh+aIw+JPgJSserWMu2Fa6Ag0BNq/34QxECi
# q9x8ZqfOy3hI2B783Pp6esq3kybHWiuqTZITycjCh778yE7jjYYUbaSrnPOEZWT8
# CMSnUt2kkwsFBqsyn1ddsDZXtZKbJQ4SyVnMJyygwDlWV13DQsUBZQz+yLaZA/Er
# LgFDomI7t904YrPpFo4EjTTdSSkWdMSaMfxKSJtrr3k5StX00D6WAATs/oQgkmKS
# uaHTGsM5ct2HatzAHn3tBikVvHK+WX9DnLf3vvTnTeLhAop2RbRRrZ+eififZw00
# AV7AuX3MLU6hZnbO2eoljckKnPmAjAr7QpOCQOJxMXM5S41UpUFNECsnDpnCI7UZ
# GheNAQi4UchyOwvxB9v2Eb7sGs9mQQf9GxvmRiqdMV2FAuZ771l9+M28WzlHFGHP
# 6UcHXI3ELej9j+gwyyJscafvv/6cdC6bPtniFaKUrMZvHgOMWlbE5972hDC+vX9m
# 6Zw/oww9ZROzyssfkxDf7JLbkw==
# =y7lF
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 13 Mar 2023 11:00:34 GMT
# gpg:                using RSA key 87A9BD933F87C606D276F62DDAE8E10975969CE5
# gpg:                issuer "marcandre.lureau@redhat.com"
# gpg: Good signature from "Marc-André Lureau <marcandre.lureau@redhat.com>" 
[full]
# gpg:                 aka "Marc-André Lureau <marcandre.lureau@gmail.com>" 
[full]
# Primary key fingerprint: 87A9 BD93 3F87 C606 D276  F62D DAE8 E109 7596 9CE5

* tag 'display-pull-request' of https://gitlab.com/marcandre.lureau/qemu:
  ui/dbus: restrict opengl to gbm-enabled config
  ui/dbus: do not require opengl & gbm
  ui: introduce egl_init()
  ui/sdl: try to instantiate the matching opengl renderer
  ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment
  ui/egl: print EGL error, helping debugging
  ui/shader: fix #version directive must occur on first line
  ui/sdl: get the GL context from the window
  ui: set cursor position upon listener registration
  ui: set cursor upon listener registration
  ui: keep current cursor with QemuConsole
  ui: rename cursor_{get->ref}, return it
  ui: rename cursor_{put->unref}
  meson: ensure dbus-display generated code is built before other units
  ui/dbus: set mouse is-absolute during console creation
  audio/dbus: there are no sender for p2p mode
  ui/dbus: unregister clipboard on connection close
  ui/dbus: initialize cursor_fb

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/29c8a9e31a98...a515336a2cef



reply via email to

[Prev in Thread] Current Thread [Next in Thread]