[Qemu-commits] [qemu/qemu] ea985d: pc_piix: remove pc-i440fx-1.4 up to p

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] ea985d: pc_piix: remove pc-i440fx-1.4 up to p

From:	Alex Bennée
Subject:	[Qemu-commits] [qemu/qemu] ea985d: pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7
Date:	Wed, 27 Sep 2023 10:55:59 -0700
  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: ea985d235b868047cb4d8cb5657bcd8ad98c6ba2
      
https://github.com/qemu/qemu/commit/ea985d235b868047cb4d8cb5657bcd8ad98c6ba2
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M docs/about/deprecated.rst
    M docs/about/removed-features.rst
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M tests/qtest/test-x86-cpuid-compat.c

  Log Message:
  -----------
  pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7

These are the last users of the 128K SeaBIOS blob in the i440FX family.
Removing them allows us to drop PCI support from the 128K blob,
thus making it easier to update SeaBIOS to newer versions.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: a1fadbcf482c38407a8ff488b0f9a3c4332802d9
      
https://github.com/qemu/qemu/commit/a1fadbcf482c38407a8ff488b0f9a3c4332802d9
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M pc-bios/bios.bin
    M roms/config.seabios-128k

  Log Message:
  -----------
  seabios: remove PCI drivers from bios.bin

bios.bin is now used only by ISA PC, so PCI drivers are not necessary.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 8a9fc82bac139f8814ed6ae338381a3992eb414c
      
https://github.com/qemu/qemu/commit/8a9fc82bac139f8814ed6ae338381a3992eb414c
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M accel/tcg/user-exec-stub.c

  Log Message:
  -----------
  user-exec-stub: remove unused variable

enable_cpu_pm is only used by softmmu-specific code, namely 
target/i386/host-cpu.c
and target/i386/kvm/*.  It does not need a stub definition anymore.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 7cfcc79b0ab800959716738aff9419f53fc68c9c
      
https://github.com/qemu/qemu/commit/7cfcc79b0ab800959716738aff9419f53fc68c9c
  Author: Thomas Huth <thuth@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M hw/scsi/scsi-disk.c

  Log Message:
  -----------
  hw/scsi/scsi-disk: Disallow block sizes smaller than 512 [CVE-2023-42467]

We are doing things like

    nb_sectors /= (s->qdev.blocksize / BDRV_SECTOR_SIZE);

in the code here (e.g. in scsi_disk_emulate_mode_sense()), so if
the blocksize is smaller than BDRV_SECTOR_SIZE (=512), this crashes
with a division by 0 exception. Thus disallow block sizes of 256
bytes to avoid this situation.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1813
CVE: 2023-42467
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-ID: <20230925091854.49198-1-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: c431ffd47157ad4bd3a230570a31faa088c71260
      
https://github.com/qemu/qemu/commit/c431ffd47157ad4bd3a230570a31faa088c71260
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M softmmu/vl.c

  Log Message:
  -----------
  vl: remove shadowed local variables

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 0cb9c5880e6b8dedc4e20026ce859dd1ea9aac84
      
https://github.com/qemu/qemu/commit/0cb9c5880e6b8dedc4e20026ce859dd1ea9aac84
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  ui/vnc: fix debug output for invalid audio message

The debug message was cut and pasted from the invalid audio format
case, but the audio message is at bytes 2-3.

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 477b301000d665313217f65e3a368d2cb7769c42
      
https://github.com/qemu/qemu/commit/477b301000d665313217f65e3a368d2cb7769c42
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  ui/vnc: fix handling of VNC_FEATURE_XVP

VNC_FEATURE_XVP was not shifted left before adding it to vs->features,
so it was never enabled; but it was also checked the wrong way with
a logical AND instead of vnc_has_feature.  Fix both places.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 4c186847ee0080a76dfef874322d634c429d43ad
      
https://github.com/qemu/qemu/commit/4c186847ee0080a76dfef874322d634c429d43ad
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-25 (Mon, 25 Sep 2023)

  Changed paths:
    M hw/scsi/mptsas.c

  Log Message:
  -----------
  mptsas: avoid shadowed local variables

Rename the argument so that "addr" is only used inside the for loop.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 973d3ea5a1c0573149b7004108276ca01cb05fd2
      
https://github.com/qemu/qemu/commit/973d3ea5a1c0573149b7004108276ca01cb05fd2
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M hw/i2c/pm_smbus.c

  Log Message:
  -----------
  pm_smbus: rename variable to avoid shadowing

Acked-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 168d46749d19f4808022b9a88c0846b3286aed59
      
https://github.com/qemu/qemu/commit/168d46749d19f4808022b9a88c0846b3286aed59
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M tests/qtest/m48t59-test.c

  Log Message:
  -----------
  m48t59-test: avoid possible overflow on ABS

Originally meant to avoid a shadowed variable "s", which was fixed by
renaming the outer declaration to "qts".  Avoid the chance of an overflow
in the computation of ABS(t - s).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: e0c3ef715baabbea6d59335bebfc7e40f1724d7e
      
https://github.com/qemu/qemu/commit/e0c3ef715baabbea6d59335bebfc7e40f1724d7e
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M target/i386/kvm/kvm.c

  Log Message:
  -----------
  target/i386/kvm: eliminate shadowed local variables

These are harmless are they die immediately after their use.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 637123a21381b2c5833d9d663af06e3105d8caa9
      
https://github.com/qemu/qemu/commit/637123a21381b2c5833d9d663af06e3105d8caa9
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M target/i386/cpu.c

  Log Message:
  -----------
  target/i386/cpu: avoid shadowed local variables

Reuse the pointer variable used for the unversioned model.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 19729affe1cd191f063db4b4d43058974cf43bc9
      
https://github.com/qemu/qemu/commit/19729affe1cd191f063db4b4d43058974cf43bc9
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M target/i386/tcg/translate.c

  Log Message:
  -----------
  target/i386/translate: avoid shadowed local variables

Just remove the declaration.  There is nothing in the function after the
switch statement, so it is safe to do.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: a908985971a38d335114e36f0b8b42fd85816cbe
      
https://github.com/qemu/qemu/commit/a908985971a38d335114e36f0b8b42fd85816cbe
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M target/i386/tcg/seg_helper.c

  Log Message:
  -----------
  target/i386/seg_helper: introduce tss_set_busy

Eliminate a shadowed local variable in the process.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 49958057a2ff7503357ce624da0cd3a94ab554bf
      
https://github.com/qemu/qemu/commit/49958057a2ff7503357ce624da0cd3a94ab554bf
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M target/i386/tcg/seg_helper.c

  Log Message:
  -----------
  target/i386/seg_helper: remove shadowed variable

Return the width of the new task directly from switch_tss_ra.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 1bce34aaa9d324b6d4aaf681e634e1840ca5d04e
      
https://github.com/qemu/qemu/commit/1bce34aaa9d324b6d4aaf681e634e1840ca5d04e
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M target/i386/tcg/sysemu/svm_helper.c

  Log Message:
  -----------
  target/i386/svm_helper: eliminate duplicate local variable

This shadows an outer "cs" variable that is initialized to the
same expression.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: e2dbca033710efea20b0b0a26ca05570dcdabd49
      
https://github.com/qemu/qemu/commit/e2dbca033710efea20b0b0a26ca05570dcdabd49
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M block/io.c
    M block/qcow2.c
    M block/qed.c
    M block/throttle-groups.c

  Log Message:
  -----------
  block: mark mixed functions that can suspend

The marking should be extended transitively to all functions that call
these ones, so that static analysis can be done much more efficiently.
However, this is a start and makes it possible to use vrc's path-based
searches to find potential bugs where coroutine_fns call blocking functions.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: d79b9202e45711e37e5ba5b3fbfccb4b9fff78a1
      
https://github.com/qemu/qemu/commit/d79b9202e45711e37e5ba5b3fbfccb4b9fff78a1
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M include/qemu/compiler.h
    M include/qemu/osdep.h

  Log Message:
  -----------
  compiler: introduce QEMU_ANNOTATE

Allow a more shorter syntax when defining wrapper macros for
__attribute__((annotate(...))).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 417f8c8ebfa32823b23fed957dcbc7108cb77dea
      
https://github.com/qemu/qemu/commit/417f8c8ebfa32823b23fed957dcbc7108cb77dea
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   2023-09-26 (Tue, 26 Sep 2023)

  Changed paths:
    M audio/audio.c

  Log Message:
  -----------
  audio: remove shadowed locals

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


  Commit: 5dfd80e38b63dc5bf2202bc87a9b1a3e1460efb9
      
https://github.com/qemu/qemu/commit/5dfd80e38b63dc5bf2202bc87a9b1a3e1460efb9
  Author: Stefan Hajnoczi <stefanha@redhat.com>
  Date:   2023-09-27 (Wed, 27 Sep 2023)

  Changed paths:
    M accel/tcg/user-exec-stub.c
    M audio/audio.c
    M block/io.c
    M block/qcow2.c
    M block/qed.c
    M block/throttle-groups.c
    M docs/about/deprecated.rst
    M docs/about/removed-features.rst
    M hw/i2c/pm_smbus.c
    M hw/i386/pc.c
    M hw/i386/pc_piix.c
    M hw/scsi/mptsas.c
    M hw/scsi/scsi-disk.c
    M include/qemu/compiler.h
    M include/qemu/osdep.h
    M pc-bios/bios.bin
    M roms/config.seabios-128k
    M softmmu/vl.c
    M target/i386/cpu.c
    M target/i386/kvm/kvm.c
    M target/i386/tcg/seg_helper.c
    M target/i386/tcg/sysemu/svm_helper.c
    M target/i386/tcg/translate.c
    M tests/qtest/m48t59-test.c
    M tests/qtest/test-x86-cpuid-compat.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging

* new round of audio cleanups
* various shadowed local variable fixes in vl, mptsas, pm_smbus, target/i386
* remove deprecated pc-i440fx-1.4 up to pc-i440fx-1.7
* remove PCI drivers from 128K bios.bin
* remove unused variable in user-exec-stub.c
* small fixes for ui/vnc
* scsi-disk: Disallow block sizes smaller than 512 [CVE-2023-42467]

# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmUTDaoUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroMvEgf+NrSaP4pmHrYcVtm43fnKXoLHFrCx
# KYfoK9Lke/DDkTff6rrcfW/Wyqid6Pp9Ch4Rrpr/X71X5gi+c6xb5klC8cpSfLg4
# gtuGctj7WL7KR/067EsLqHvzBob/iebFhZwhtsBrI+z65X+J9pOK78efBTdhezq4
# EEHTWohMAg1I/MWBK5VnOk2fI4+9z9K9zP5AtWmJzwwJkQUoEyl+YDkVmIhMYoGn
# CapRO7i2wIvtoF4wuQUCGsOLmrcWTvRIOcV13k3b6PYCPC40/N9AOpiiyg3XqNah
# UKKM9CcgVnCzCc4Jar2QD+MzkTDxhmQSyLFJgtzrW7CQSE5YB3sUHj3CXg==
# =8nvs
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 26 Sep 2023 12:58:18 EDT
# gpg:                using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg:                issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [full]
# gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>" [full]
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
#      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83

* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
  audio: remove shadowed locals
  compiler: introduce QEMU_ANNOTATE
  block: mark mixed functions that can suspend
  target/i386/svm_helper: eliminate duplicate local variable
  target/i386/seg_helper: remove shadowed variable
  target/i386/seg_helper: introduce tss_set_busy
  target/i386/translate: avoid shadowed local variables
  target/i386/cpu: avoid shadowed local variables
  target/i386/kvm: eliminate shadowed local variables
  m48t59-test: avoid possible overflow on ABS
  pm_smbus: rename variable to avoid shadowing
  mptsas: avoid shadowed local variables
  ui/vnc: fix handling of VNC_FEATURE_XVP
  ui/vnc: fix debug output for invalid audio message
  vl: remove shadowed local variables
  hw/scsi/scsi-disk: Disallow block sizes smaller than 512 [CVE-2023-42467]
  user-exec-stub: remove unused variable
  seabios: remove PCI drivers from bios.bin
  pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>


Compare: https://github.com/qemu/qemu/compare/11a629d246e4...5dfd80e38b63
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] ea985d: pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7, Alex Bennée <=
- [Qemu-commits] [qemu/qemu] ea985d: pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7, Alex Bennée, 2023/09/27
Prev by Date: [Qemu-commits] [qemu/qemu] 0189c2: iotests: use TEST_IMG_FILE instead of TEST_IMG in ...
Next by Date: [Qemu-commits] [qemu/qemu] cf02f2: migration: Fix race that dest preempt thread close...
Previous by thread: [Qemu-commits] [qemu/qemu] 0189c2: iotests: use TEST_IMG_FILE instead of TEST_IMG in ...
Next by thread: [Qemu-commits] [qemu/qemu] ea985d: pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7
Index(es):
- Date
- Thread