qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] a2531b: hw/arm: Deprecate various old Arm mac


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] a2531b: hw/arm: Deprecate various old Arm machine types
Date: Tue, 12 Mar 2024 04:12:18 -0700

  Branch: refs/heads/staging
  Home:   https://github.com/qemu/qemu
  Commit: a2531bb855079597444f2ef1dcd4118d6609baf1
      
https://github.com/qemu/qemu/commit/a2531bb855079597444f2ef1dcd4118d6609baf1
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M docs/about/deprecated.rst
    M hw/arm/gumstix.c
    M hw/arm/mainstone.c
    M hw/arm/nseries.c
    M hw/arm/palm.c
    M hw/arm/spitz.c
    M hw/arm/tosa.c
    M hw/arm/z2.c

  Log Message:
  -----------
  hw/arm: Deprecate various old Arm machine types

QEMU includes some models of old Arm machine types which are
a bit problematic for us because:
 * they're written in a very old way that uses numerous APIs that we
   would like to get away from (eg they don't use qdev, they use
   qemu_system_reset_request(), they use vmstate_register(), etc)
 * they've been that way for a decade plus and nobody particularly has
   stepped up to try to modernise the code (beyond some occasional
   work here and there)
 * we often don't have test cases for them, which means that if we
   do try to do the necessary refactoring work on them we have no
   idea if they even still work at all afterwards

All these machine types are also of hardware that has largely passed
away into history and where I would not be surprised to find that
e.g. the Linux kernel support was never tested on real hardware
any more.

After some consultation with the Linux kernel developers, we
are going to deprecate:

All PXA2xx machines:

akita                Sharp SL-C1000 (Akita) PDA (PXA270)
borzoi               Sharp SL-C3100 (Borzoi) PDA (PXA270)
connex               Gumstix Connex (PXA255)
mainstone            Mainstone II (PXA27x)
spitz                Sharp SL-C3000 (Spitz) PDA (PXA270)
terrier              Sharp SL-C3200 (Terrier) PDA (PXA270)
tosa                 Sharp SL-6000 (Tosa) PDA (PXA255)
verdex               Gumstix Verdex Pro XL6P COMs (PXA270)
z2                   Zipit Z2 (PXA27x)

All OMAP2 machines:

n800                 Nokia N800 tablet aka. RX-34 (OMAP2420)
n810                 Nokia N810 tablet aka. RX-44 (OMAP2420)

One of the OMAP1 machines:

cheetah              Palm Tungsten|E aka. Cheetah PDA (OMAP310)

Rationale:
 * for QEMU dropping individual machines is much less beneficial
   than if we can drop support for an entire SoC
 * the OMAP2 QEMU code in particular is large, old and unmaintained,
   and none of the OMAP2 kernel maintainers said they were using
   QEMU in any of their testing/development
 * although there is a setup that is booting test kernels on some
   of the PXA2xx machines, nobody seemed to be using them as part
   of their active kernel development and my impression from the
   email thread is that PXA is the closest of all these SoC families
   to being dropped from the kernel soon
 * nobody said they were using cheetah, so it's entirely
   untested and quite probably broken
 * on the other hand the OMAP1 sx1 model does seem to be being
   used as part of kernel development, and there was interest
   in keeping collie around

In particular, the mainstone, tosa and z2 machine types have
already been dropped from Linux.

Mark all these machine types as deprecated.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240308171621.3749894-1-peter.maydell@linaro.org


  Commit: b48139d0d90e9a551f630760fa57732cfeee759f
      
https://github.com/qemu/qemu/commit/b48139d0d90e9a551f630760fa57732cfeee759f
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/pdb.c

  Log Message:
  -----------
  contrib/elf2dmp: Remove unnecessary err flags

They are always evaluated to 1.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-1-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: a4e58de14678503fd773e7920359028de77711f9
      
https://github.com/qemu/qemu/commit/a4e58de14678503fd773e7920359028de77711f9
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/download.c
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Assume error by default

A common construct in contrib/elf2dmp is to set "err" flag and goto
in error paths. In such a construct, there is only one successful path
while there are several error paths, so it will be more simpler to
initialize "err" flag set, and clear it in the successful path.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-2-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 87157ef3508dbc84dd74ebf099f86828b652d854
      
https://github.com/qemu/qemu/commit/87157ef3508dbc84dd74ebf099f86828b652d854
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Continue even contexts are lacking

Let fill_context() continue even if it fails to fill contexts of some
CPUs. A dump may still contain valuable information even if it lacks
contexts of some CPUs due to dump corruption or a failure before
starting CPUs.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-3-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 262a0ff88029e86b29434d4b2e7f710ae73b646c
      
https://github.com/qemu/qemu/commit/262a0ff88029e86b29434d4b2e7f710ae73b646c
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/addrspace.c
    M contrib/elf2dmp/addrspace.h
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Change pa_space_create() signature

pa_space_create() used to return an integer to propagate error, but
it never fails so let it return void.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240307-elf2dmp-v4-4-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: a15f9749490e8d813b8929c69a7365e3edc6ab8c
      
https://github.com/qemu/qemu/commit/a15f9749490e8d813b8929c69a7365e3edc6ab8c
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/addrspace.c
    M contrib/elf2dmp/addrspace.h
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Fix error reporting style in addrspace.c

include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240307-elf2dmp-v4-5-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 1b806c36bc88a975cc10af219f1a397942f43e8d
      
https://github.com/qemu/qemu/commit/1b806c36bc88a975cc10af219f1a397942f43e8d
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/download.c
    M contrib/elf2dmp/download.h
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Fix error reporting style in download.c

include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240307-elf2dmp-v4-6-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: b1250455c71193ad92cb7c98ee54078ce33e0b04
      
https://github.com/qemu/qemu/commit/b1250455c71193ad92cb7c98ee54078ce33e0b04
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/main.c
    M contrib/elf2dmp/pdb.c
    M contrib/elf2dmp/pdb.h

  Log Message:
  -----------
  contrib/elf2dmp: Fix error reporting style in pdb.c

include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240307-elf2dmp-v4-7-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 49760ccf862ff6cd0b18dd5897a60f8d708a6e52
      
https://github.com/qemu/qemu/commit/49760ccf862ff6cd0b18dd5897a60f8d708a6e52
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/main.c
    M contrib/elf2dmp/qemu_elf.c
    M contrib/elf2dmp/qemu_elf.h

  Log Message:
  -----------
  contrib/elf2dmp: Fix error reporting style in qemu_elf.c

include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240307-elf2dmp-v4-8-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: fbc3d7d2f1d638f2c68a2af343be882717a9eed8
      
https://github.com/qemu/qemu/commit/fbc3d7d2f1d638f2c68a2af343be882717a9eed8
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Fix error reporting style in main.c

include/qapi/error.h says:
> We recommend
> * bool-valued functions return true on success / false on failure,
> ...

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240307-elf2dmp-v4-9-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: a6a62ef5751371a82a9fb3ce67190d38a7f465fb
      
https://github.com/qemu/qemu/commit/a6a62ef5751371a82a9fb3ce67190d38a7f465fb
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/addrspace.c

  Log Message:
  -----------
  contrib/elf2dmp: Always check for PA resolution failure

Not checking PA resolution failure can result in NULL deference.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-10-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 2aa205f7c6339cb46d26473a0434a292fc3d32cf
      
https://github.com/qemu/qemu/commit/2aa205f7c6339cb46d26473a0434a292fc3d32cf
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Always destroy PA space

Destroy PA space even if paging base couldn't be found, fixing memory
leak.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-11-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 667909478b09f9f16b03b7e7b11f3c42e7bdcdf3
      
https://github.com/qemu/qemu/commit/667909478b09f9f16b03b7e7b11f3c42e7bdcdf3
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/addrspace.c

  Log Message:
  -----------
  contrib/elf2dmp: Ensure segment fits in file

This makes elf2dmp more robust against corrupted inputs.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-12-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 2aa501af351c25f91c56f3c9fd023df4bbea3f3c
      
https://github.com/qemu/qemu/commit/2aa501af351c25f91c56f3c9fd023df4bbea3f3c
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/pdb.c

  Log Message:
  -----------
  contrib/elf2dmp: Use lduw_le_p() to read PDB

The relevant value may be unaligned and is little-endian.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240307-elf2dmp-v4-13-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: f024f5031ee570d952d3e93c4bb00ee111eb9dc6
      
https://github.com/qemu/qemu/commit/f024f5031ee570d952d3e93c4bb00ee111eb9dc6
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/main.c

  Log Message:
  -----------
  contrib/elf2dmp: Use rol64() to decode

rol64() is roubust against too large shift values and fixes UBSan
warnings.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240307-elf2dmp-v4-14-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: a2de23c6e3e840e3e96ad0bb9e4314988e5a2f42
      
https://github.com/qemu/qemu/commit/a2de23c6e3e840e3e96ad0bb9e4314988e5a2f42
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20240307-elf2dmp-v4-15-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 0c94e32dff020f868a8125c5314fe9f318a8215d
      
https://github.com/qemu/qemu/commit/0c94e32dff020f868a8125c5314fe9f318a8215d
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/qemu_elf.c

  Log Message:
  -----------
  contrib/elf2dmp: Use GPtrArray

This removes the need to enumarate QEMUCPUState twice and saves code.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-17-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 9de37c288367ad22dd8abe069eeae17faf6e3ed9
      
https://github.com/qemu/qemu/commit/9de37c288367ad22dd8abe069eeae17faf6e3ed9
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/qemu_elf.c

  Log Message:
  -----------
  contrib/elf2dmp: Clamp QEMU note to file size

This fixes crashes with truncated dumps.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Message-id: 20240307-elf2dmp-v4-18-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 98d16e5f724cf4f884cab28956321a4a093474d7
      
https://github.com/qemu/qemu/commit/98d16e5f724cf4f884cab28956321a4a093474d7
  Author: Akihiko Odaki <akihiko.odaki@daynix.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M contrib/elf2dmp/qemu_elf.c

  Log Message:
  -----------
  contrib/elf2dmp: Ensure phdrs fit in file

Callers of elf64_getphdr() and elf_getphdrnum() assume phdrs are
accessible.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2202
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Tested-by: Viktor Prutyanov <viktor.prutyanov@phystech.edu>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240307-elf2dmp-v4-19-4f324ad4d99d@daynix.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 5dd6bfd90d01e0cb27c349157208e5e4ce883846
      
https://github.com/qemu/qemu/commit/5dd6bfd90d01e0cb27c349157208e5e4ce883846
  Author: Ani Sinha <anisinha@redhat.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M docs/conf.py
    M include/qemu/help-texts.h

  Log Message:
  -----------
  docs: update copyright date to the year 2024

We are already in the third month of 2024 but the copyright notices still refer
to 2023. Update the date to 2024 in documentation and help texts.

Cc: peter.maydell@linaro.org
Cc: qemu-trivial@nongnu.org
Signed-off-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20240311120346.9596-1-anisinha@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 38b3f17a27782273055a9a011c52f9f2bd3bd311
      
https://github.com/qemu/qemu/commit/38b3f17a27782273055a9a011c52f9f2bd3bd311
  Author: Minwoo Im <minwoo.im@samsung.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: separate 'serial' property for VFs

Currently, when a VF is created, it uses the 'params' object of the PF
as it is. In other words, the 'params.serial' string memory area is also
shared. In this situation, if the VF is removed from the system, the
PF's 'params.serial' object is released with object_finalize() followed
by object_property_del_all() which release the memory for 'serial'
property. If that happens, the next VF created will inherit a serial
from a corrupted memory area.

If this happens, an error will occur when comparing subsys->serial and
n->params.serial in the nvme_subsys_register_ctrl() function.

Cc: qemu-stable@nongnu.org
Fixes: 44c2c09488db ("hw/nvme: Add support for SR-IOV")
Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: ef34766cf51b220af05abb4d25466be77383944a
      
https://github.com/qemu/qemu/commit/ef34766cf51b220af05abb4d25466be77383944a
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: fix invalid check on mcl

The number of logical blocks within a source range is converted into a
1s based number at the time of parsing. However, when verifying the copy
length we add one again, causing the check against MCL to fail in error.

Cc: qemu-stable@nongnu.org
Fixes: 381ab99d8587 ("hw/nvme: check maximum copy length (MCL) for COPY")
Reviewed-by: Minwoo Im <minwoo.im@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 72c33ce9dc9eb2cb1303ec91098672b0c2f65791
      
https://github.com/qemu/qemu/commit/72c33ce9dc9eb2cb1303ec91098672b0c2f65791
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: add Jesper as reviewer on hw/nvme

My colleague, Jesper, will be assiting with hw/nvme related reviews. Add
him with R: so he gets automatically bugged going forward.

Cc: Jesper Devantier <foss@defmacro.it>
Acked-by: Jesper Devantier <foss@defmacro.it>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 54bf92b75b173d0b319d24857fd9de7fb5d747f1
      
https://github.com/qemu/qemu/commit/54bf92b75b173d0b319d24857fd9de7fb5d747f1
  Author: Roque Arcudia Hernandez <roqueh@google.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M docs/system/devices/nvme.rst
    M hw/nvme/ctrl.c
    M hw/nvme/meson.build
    A hw/nvme/nguid.c
    M hw/nvme/ns.c
    M hw/nvme/nvme.h

  Log Message:
  -----------
  hw/nvme: Add NVMe NGUID property

This patch adds a way to specify an NGUID for a given NVMe Namespace using a
string of hexadecimal digits with an optional '-' separator to group bytes. For
instance:

-device nvme-ns,nguid="e9accd3b83904e13167cf0593437f57d"

If provided, the NGUID will be part of the Namespace Identification Descriptor
list and the Identify Namespace data.

Signed-off-by: Roque Arcudia Hernandez <roqueh@google.com>
Signed-off-by: Nabih Estefan <nabihestefan@google.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 52fe1f7a5bfbac78991e7aa4420e444fe7a28e9d
      
https://github.com/qemu/qemu/commit/52fe1f7a5bfbac78991e7aa4420e444fe7a28e9d
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/nvme/ctrl.c

  Log Message:
  -----------
  hw/nvme: generalize the mbar size helper

Generalize the mbar size helper such that it can handle cases where the
MSI-X table and PBA are expected to be in an exclusive bar.

Cc: qemu-stable@nongnu.org
Reviewed-by: Jesper Wendel Devantier <foss@defmacro.it>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: a1505d799232939bf90c1b3e1fc20e81cd398404
      
https://github.com/qemu/qemu/commit/a1505d799232939bf90c1b3e1fc20e81cd398404
  Author: Klaus Jensen <k.jensen@samsung.com>
  Date:   2024-03-11 (Mon, 11 Mar 2024)

  Changed paths:
    M hw/core/machine.c
    M hw/nvme/ctrl.c
    M hw/nvme/nvme.h

  Log Message:
  -----------
  hw/nvme: add machine compatibility parameter to enable msix exclusive bar

Commit 1901b4967c3f ("hw/block/nvme: move msix table and pba to BAR 0")
moved the MSI-X table and PBA to BAR 0 to make room for enabling CMR and
PMR at the same time. As reported by Julien Grall in #2184, this breaks
migration through system hibernation.

Add a machine compatibility parameter and set it on machines pre 6.0 to
enable the old behavior automatically, restoring the hibernation
migration support.

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2184
Fixes: 1901b4967c3f ("hw/block/nvme: move msix table and pba to BAR 0")
Reported-by: Julien Grall julien@xen.org
Tested-by: Julien Grall julien@xen.org
Reviewed-by: Jesper Wendel Devantier <foss@defmacro.it>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>


  Commit: 982fa7da4331130000ec3c175985577088e4ea38
      
https://github.com/qemu/qemu/commit/982fa7da4331130000ec3c175985577088e4ea38
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M MAINTAINERS
    M docs/system/devices/nvme.rst
    M hw/core/machine.c
    M hw/nvme/ctrl.c
    M hw/nvme/meson.build
    A hw/nvme/nguid.c
    M hw/nvme/ns.c
    M hw/nvme/nvme.h

  Log Message:
  -----------
  Merge tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu into 
staging

hw/nvme updates

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmXvVsYACgkQTeGvMW1P
# DemWtwf9HU3cjtvCp8AeHGoPFTwp8/Vx3cQlQ6ilADKSDm44up2+M504xE/Mdviv
# 6y3PTPe1yiEpg/MbjWTX/df5lo+VdNoCuCyjph9mea0s1QAjCfVpl+KLMUVF/Oj5
# y1Iz9PQqOVDJ3O4xlgmPTfd8NXE/frNJaiXAjFuBxF2+4lilD5kMxpyu7DXbLiy2
# Szd1I3DhFAEOLEbrSSRDI3Fpy0KBdRzdKuUfmRdrHzbmhzHJefW7wnZ3aAiDboaD
# Ny7y/aovmjGymMp9GrBKWhUFPfSUtJ8l8j4Z7acQs+VDxg8lcAHCJKOyqCBTspUL
# PSnDe6E/CRyjrG2fUVXTLb6YW1eibQ==
# =Ld7a
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 11 Mar 2024 19:08:54 GMT
# gpg:                using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9
# gpg: Good signature from "Klaus Jensen <its@irrelevant.dk>" [full]
# gpg:                 aka "Klaus Jensen <k.jensen@samsung.com>" [full]
# Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468  4272 63D5 6FC5 E55D A838
#      Subkey fingerprint: 5228 33AA 75E2 DCE6 A247  66C0 4DE1 AF31 6D4F 0DE9

* tag 'nvme-next-pull-request' of https://gitlab.com/birkelund/qemu:
  hw/nvme: add machine compatibility parameter to enable msix exclusive bar
  hw/nvme: generalize the mbar size helper
  hw/nvme: Add NVMe NGUID property
  MAINTAINERS: add Jesper as reviewer on hw/nvme
  hw/nvme: fix invalid check on mcl
  hw/nvme: separate 'serial' property for VFs

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


  Commit: 7e7d112a0037fc8f29b00bb14c651317d6e16fd4
      
https://github.com/qemu/qemu/commit/7e7d112a0037fc8f29b00bb14c651317d6e16fd4
  Author: Peter Maydell <peter.maydell@linaro.org>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M MAINTAINERS
    M contrib/elf2dmp/addrspace.c
    M contrib/elf2dmp/addrspace.h
    M contrib/elf2dmp/download.c
    M contrib/elf2dmp/download.h
    M contrib/elf2dmp/main.c
    M contrib/elf2dmp/pdb.c
    M contrib/elf2dmp/pdb.h
    M contrib/elf2dmp/qemu_elf.c
    M contrib/elf2dmp/qemu_elf.h
    M docs/about/deprecated.rst
    M docs/conf.py
    M hw/arm/gumstix.c
    M hw/arm/mainstone.c
    M hw/arm/nseries.c
    M hw/arm/palm.c
    M hw/arm/spitz.c
    M hw/arm/tosa.c
    M hw/arm/z2.c
    M include/qemu/help-texts.h

  Log Message:
  -----------
  Merge tag 'pull-target-arm-20240311' of 
https://git.linaro.org/people/pmaydell/qemu-arm into staging

target-arm queue:
 * contrib/elf2dmp: Improve robustness to corrupt input files
 * docs: update copyright date to the year 2024
 * hw/arm: Deprecate various old Arm machine types

# -----BEGIN PGP SIGNATURE-----
#
# iQJNBAABCAA3FiEE4aXFk81BneKOgxXPPCUl7RQ2DN4FAmXvV4gZHHBldGVyLm1h
# eWRlbGxAbGluYXJvLm9yZwAKCRA8JSXtFDYM3oe5EACvvve9LOJ7UA4teEbn8zzs
# O7GGsycpu3XWINX98sUi5Cuu+uexkcXsHf2Vg8GABj2fUuA+EEqPIdIWZhVcfB2t
# RYGPgat/JVTwRUsl38OQ97l4joI2JeW18B20Pmh4/2tbZCJuIHoiHxxb+3aQl6Nl
# gz/H137ayy+Q5utt1b6z1qXnw4etiUhk4wg2ltGVtAw63w5GZOvamTicSQ1DC3ZP
# zfbIKW2WpGNjzrC1tCvaW/dNojt2blpZbsnpdPsL8cNE8puo01FnFLsUZCzOtu3m
# 23uoQq0KjQZBJrU2oZMtshc+sKT/FGPADJ9B+J8jjU0EY6cV+Qo7FT4E78mxzoR0
# JbY9SLATtY7RE1Fbh3/Am+3OEyb3ZDor5nCux0CWOsuFoBk96dzD7r5MXxM2eft1
# pGmdJStYysZkdlSyx61bu6OifHOaGjnOe+lYWpaCrVy1U3cO3hbMWH2siSQygppM
# 8EfjyfadzfST+nAnXfduSgWMv7Nc4ql4GIOxVnMIfGig32PIp545IvM9neh6GIp/
# 8fzw6TdoCQkHcWaazV1ibPF0ceH6JwRvLIMkWlNpr/QBSNdsx+zkdh7WZD+3S91U
# XrCAA7hgf7OIvHauSD0ucSbztIiFRMROcHxIoh0ui6BermtaD6fnlei4QcsJI17o
# 6XZSNSWm5/+JEsn+dcVh4g==
# =UHyi
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 11 Mar 2024 19:12:08 GMT
# gpg:                using RSA key E1A5C593CD419DE28E8315CF3C2525ED14360CDE
# gpg:                issuer "peter.maydell@linaro.org"
# gpg: Good signature from "Peter Maydell <peter.maydell@linaro.org>" [ultimate]
# gpg:                 aka "Peter Maydell <pmaydell@gmail.com>" [ultimate]
# gpg:                 aka "Peter Maydell <pmaydell@chiark.greenend.org.uk>" 
[ultimate]
# gpg:                 aka "Peter Maydell <peter@archaic.org.uk>" [ultimate]
# Primary key fingerprint: E1A5 C593 CD41 9DE2 8E83  15CF 3C25 25ED 1436 0CDE

* tag 'pull-target-arm-20240311' of 
https://git.linaro.org/people/pmaydell/qemu-arm:
  docs: update copyright date to the year 2024
  contrib/elf2dmp: Ensure phdrs fit in file
  contrib/elf2dmp: Clamp QEMU note to file size
  contrib/elf2dmp: Use GPtrArray
  MAINTAINERS: Add Akihiko Odaki as a elf2dmp reviewer
  contrib/elf2dmp: Use rol64() to decode
  contrib/elf2dmp: Use lduw_le_p() to read PDB
  contrib/elf2dmp: Ensure segment fits in file
  contrib/elf2dmp: Always destroy PA space
  contrib/elf2dmp: Always check for PA resolution failure
  contrib/elf2dmp: Fix error reporting style in main.c
  contrib/elf2dmp: Fix error reporting style in qemu_elf.c
  contrib/elf2dmp: Fix error reporting style in pdb.c
  contrib/elf2dmp: Fix error reporting style in download.c
  contrib/elf2dmp: Fix error reporting style in addrspace.c
  contrib/elf2dmp: Change pa_space_create() signature
  contrib/elf2dmp: Continue even contexts are lacking
  contrib/elf2dmp: Assume error by default
  contrib/elf2dmp: Remove unnecessary err flags
  hw/arm: Deprecate various old Arm machine types

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>


Compare: https://github.com/qemu/qemu/compare/05ec97467120...7e7d112a0037

To unsubscribe from these emails, change your notification settings at 
https://github.com/qemu/qemu/settings/notifications



reply via email to

[Prev in Thread] Current Thread [Next in Thread]