[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection o
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 0/3] e1000: allow model/device_id selection on command line |
|
Date: |
Mon, 2 Jun 2014 14:28:24 +0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, May 31, 2014 at 11:33:13PM -0400, Gabriel L. Somlo wrote:
> Allow selection of different card models from the qemu
> command line, to better accomodate a wider range of guests.
>
> New in v3:
>
> - 1/3 and 2/3 from v2 now merged into a single patch (1/3), with:
> - s/TYPE_E1000/TYPE_E1000_BASE/ as suggested by Stefan
> - improved QOM-ification as suggested by Peter Crosthwaite
>
> - *OPTIONAL* patch to remove stale support for 8257xx (see commit blurb
> in patch 3/3 for details
> (this can be squashed on top of 1/3, but I'm including it separately
> here for clarity, and as an RFC).
Looks very close now. I just had a comment about E1000DeviceClass,
which should be called E1000BaseClass.
Stefan