[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 29/33] pc: propagate memory hotplug event to ACPI
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH v4 29/33] pc: propagate memory hotplug event to ACPI device |
Date: |
Mon, 2 Jun 2014 15:25:25 +0200 |
Notify PIIX4_PM/ICH9LPC device about hotplug event,
so that it would send SCI to guest notifying about
newly added memory.
Signed-off-by: Igor Mammedov <address@hidden>
Acked-by: Peter Crosthwaite <address@hidden>
---
v2:
* fix memory leak, reported by pbonzini
* use link to ACPI device instead of looking it up in QOM tree
---
hw/i386/pc.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 6b8940a..7c23274 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1553,6 +1553,7 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp)
{
int slot;
+ HotplugHandlerClass *hhc;
Error *local_err = NULL;
PCMachineState *pcms = PC_MACHINE(hotplug_dev);
MachineState *machine = MACHINE(hotplug_dev);
@@ -1595,9 +1596,18 @@ static void pc_dimm_plug(HotplugHandler *hotplug_dev,
}
trace_mhp_pc_dimm_assigned_slot(slot);
+ if (!pcms->acpi_dev) {
+ error_setg(&local_err,
+ "memory hotplug is not enabled: missing acpi device");
+ goto out;
+ }
+
memory_region_add_subregion(&pcms->hotplug_memory,
addr - pcms->hotplug_memory_base, mr);
vmstate_register_ram(mr, dev);
+
+ hhc = HOTPLUG_HANDLER_GET_CLASS(pcms->acpi_dev);
+ hhc->plug(HOTPLUG_HANDLER(pcms->acpi_dev), dev, &local_err);
out:
error_propagate(errp, local_err);
}
--
1.7.1
- [Qemu-devel] [PATCH v4 22/33] trace: pc: add PC_DIMM slot & address allocation, (continued)
- [Qemu-devel] [PATCH v4 22/33] trace: pc: add PC_DIMM slot & address allocation, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 25/33] pc: ich9 lpc: make it work with global/compat properties, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 24/33] acpi:piix4: add memory hotplug handling, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 26/33] acpi:ich9: add memory hotplug handling, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 27/33] pc: migrate piix4 & ich9 MemHotplugState, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 30/33] pc: ACPI BIOS: implement memory hotplug interface, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 28/33] pc: add acpi-device link to PCMachineState, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 31/33] pc: add "hotplug-memory-region-size" property to PC_MACHINE, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 32/33] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole, Igor Mammedov, 2014/06/02
- [Qemu-devel] [PATCH v4 29/33] pc: propagate memory hotplug event to ACPI device,
Igor Mammedov <=
- [Qemu-devel] [PATCH v4 33/33] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines, Igor Mammedov, 2014/06/02
- Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug, Eric Blake, 2014/06/02
- Re: [Qemu-devel] [PATCH v4 00/33] pc: ACPI memory hotplug, Michael S. Tsirkin, 2014/06/08