qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v1 02/72] qapi: Extract VersionInfo definition i


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v1 02/72] qapi: Extract VersionInfo definition in qapi/common.json
Date: Mon, 02 Jun 2014 08:43:26 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/31/2014 05:50 AM, BenoƮt Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  qapi-schema.json | 26 --------------------------
>  qapi/common.json | 27 +++++++++++++++++++++++++++
>  2 files changed, 27 insertions(+), 26 deletions(-)

Why the difference in line counts?


> +           'package': 'str'} }
> +
> 

Ah, because you ended the file in a trailing blank line.  git can be set
up to have a commit hook that flags trailing blank lines, but as it is
cosmetic and probably transient based on the rest of the series, I can
overlook it.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]