Re: [Qemu-devel] [PATCH v1 06/72] qapi: create two block related json modules

[Eric Blake]

On 05/31/2014 05:50 AM, Benoît Canet wrote:
> qapi/block-core.json contains block definitions unrelated to emulation.
> 
> qapi/block.json is a superset of the previous and contains definitions related
> to emulation.
> 
> The purpose of these extractions is to be able to hook qapi/block-core.json
> generated code on qemu-nbd.
> 
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  qapi-schema.json     | 3 +++
>  qapi/block-core.json | 8 ++++++++
>  qapi/block.json      | 7 +++++++
>  3 files changed, 18 insertions(+)
>  create mode 100644 qapi/block-core.json
>  create mode 100644 qapi/block.json

> --- /dev/null
> +++ b/qapi/block-core.json
> @@ -0,0 +1,8 @@
> +# -*- Mode: Python -*-
> +#
> +# QAPI block core definitions (vm unrelated)

Same comment as in 1/72 about adding a copyright comment; and same
conclusion that doing it as a followup patch for all affected files
being okay.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature