Re: [Qemu-devel] [PATCH v1 38/72] qapi: Extract block-stream definition into qapi/block-core.json

[Eric Blake]

On 05/31/2014 05:51 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  qapi-schema.json     | 38 --------------------------------------
>  qapi/block-core.json | 38 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+), 38 deletions(-)

21-38: Reviewed-by: Eric Blake <address@hidden>

I will point out that all this refactoring work will have conflicts with
other pending patches in the same area, such as Jeff's work on using
node-name in block-stream; but such conflicts should be obvious
resolutions (either series can go first, as long as the final result is
the improved command ending up in the new file).  I don't know which
series going in first would be more of a conflict magnet to the other
series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature