Re: [Qemu-devel] [PATCH 2/3] rng-egd: Free old chr_name value before setting new one

[Eduardo Habkost]

On Mon, Jun 02, 2014 at 02:58:05PM +0200, Markus Armbruster wrote:
> Eduardo Habkost <address@hidden> writes:
> 
> > Signed-off-by: Eduardo Habkost <address@hidden>
> > ---
> > Cc: Anthony Liguori <address@hidden>
> > Cc: Amos Kong <address@hidden>
> > ---
> >  backends/rng-egd.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/backends/rng-egd.c b/backends/rng-egd.c
> > index 25bb3b4..2962795 100644
> > --- a/backends/rng-egd.c
> > +++ b/backends/rng-egd.c
> > @@ -169,6 +169,7 @@ static void rng_egd_set_chardev(Object *obj, const char 
> > *value, Error **errp)
> >      if (b->opened) {
> >          error_set(errp, QERR_PERMISSION_DENIED);
> >      } else {
> > +        g_free(s->chr_name);
> >          s->chr_name = g_strdup(value);
> >      }
> >  }
> 
> I see you searched for the bug elsewhere.  Appreciated.  Do you think
> you got them all?

I grepped for all object_property_add_str occurrences, and (unless I
made a mistake) I fixed all of them.

-- 
Eduardo