qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH memory v2 7/9] memory: MemoryRegion: Add contain


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH memory v2 7/9] memory: MemoryRegion: Add container and addr props
Date: Tue, 03 Jun 2014 09:51:41 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 02/06/2014 04:40, Peter Crosthwaite ha scritto:
>  {
>      MemoryRegion *mr = MEMORY_REGION(obj);
> +    gchar *container_link_type = g_strdup_printf("link<%s>",
> +                                                 TYPE_MEMORY_REGION);
Since TYPE_MEMORY_REGION is a literal string constant, this can be
done with regular "" "" style string concatenation. Dropped the strdup
in V3.

Note that object_resolve_path_component expects link<FOO> properties to have a LinkProperty stored in prop->opaque. Does this hold in your case?

Perhaps we can instead add a new ->resolve function pointer to properties.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]