Re: [Qemu-devel] [Xen-devel] [RFC PATCH 1/2] xen: pass kernel initrd to qemu

[Ian Campbell]

On Mon, 2014-06-02 at 22:49 -0600, Chun Yan Liu wrote:
> 
> >>> On 6/2/2014 at 11:24 PM, in message
> <address@hidden>, Ian Campbell
> <address@hidden> wrote: 
> > On Thu, 2014-05-29 at 11:23 +0800, Chunyan Liu wrote: 
> > > [support xen HVM direct kernel boot] 
> >  
> > What is this? 
> 
> Just to indicate this is part of work to support xen HVM direct kernel boot.
> To make it work, there is another patch to qemu.

Putting it there means that it will end up in the eventual commit
message unless the committed takes some special steps. I'd recommend
either adding it to the subject (i.e. "[RFC PATCH XEN 1/2]", "[RFC PATCH
QEMU 2/2]") or after the --- which follows your Signed-off-by.

> 
> >  
> > > xen side patch: support 'kernel', 'ramdisk', 'root', 'extra' 
> > > in HVM config file, parse config file, pass -kernel, -initrd 
> > > and -append parameters to qemu. 
> >  
> > Is this a completely new feature or is this adding parity with a xend 
> > feature? 
> 
> I think it's new. Xend doesn't support HVM direct kernel boot.

OK, then you certainly don't want the old qemu support (which you were
going to remove anyway)

> > > @@ -196,6 +196,16 @@ static char **  
> > libxl__build_device_model_args_old(libxl__gc *gc, 
> >  
> > Does this work with old qemu+rombios? 
> 
> Oh, no. I'll remove this piece.

Thanks.

Ian.