Re: [Qemu-devel] [PATCH v2 5/6] arm/virt: enable PSCI emulation support for system emulation

[Peter Maydell]

On 23 May 2014 03:30, Rob Herring <address@hidden> wrote:
> From: Rob Herring <address@hidden>
>
> Now that we have PSCI emulation, enable it for the virt platform.
> This simplifies the virt machine a bit now that PSCI and SMP no longer
> need to be KVM only features.
>
> Signed-off-by: Rob Herring <address@hidden>
> ---
> v2:
> - Rebased. Mostly a whitespace change removing the kvm_enabled() check.
>
> @@ -446,6 +432,9 @@ static void machvirt_init(QEMUMachineInitArgs *args)
>          }
>          cpuobj = object_new(object_class_get_name(oc));
>
> +        object_property_set_int(cpuobj, QEMU_PSCI_METHOD_HVC, "psci-method",
> +                                NULL);

Similarly to patch 6, this should use &error_abort, not NULL.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM