Re: [Qemu-devel] [PATCH v1 72/72] qapi: Extract nbd-server-stop definition into qapi/block.json

[Eric Blake]

On 05/31/2014 05:51 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  qapi-schema.json | 10 ----------
>  qapi/block.json  | 10 ++++++++++
>  2 files changed, 10 insertions(+), 10 deletions(-)

45-72: Reviewed-by: Eric Blake <address@hidden>

If you resend this series for any reason, PLEASE consolidate into fewer
patches. As long as the types are copied out of qapi-schema.json in the
same order that they are copied into block.json, it's much faster to
review that the code motion was done correctly if there is only one such
patch describing the motion to block.json than to read lots of tiny
patches one per struct/command.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature